docbrown/spec/requests/user_organization_spec.rb
Andy Zhao 47d9ec27fb Allow users to belong to multiple orgs (#2583)
* Allow user to have many orgs

* Allow users to handle multi orgs in settings

* Make rounded buttons inline

* Add multi org function to dashboards

* Fix merge conflicts

* Fix mistake in merge conflict fix oops

* Display the correct membership level

* Fix accessibility issues

* Display organizations for article editors

* Handle submitting org id with preact editors

* Make listings work with multiple organizations

* Allow listings to have multiple orgs on create

* Display the correct number of credits for each org

* Move script tag to Webpack

* Allow multi orgs for purchasing and viewing credits

* Use OrganizationMembership as authorization check

* Display multiple organizations for notifications

* Allow dashboard to be viewable under multi-orgs

* Remove unused method

* Add multi-org functionality for article editors

* Show pro dashboard buttons for member+ org levels

* Leave the correct organization

* Allow article API to change org id

* Add left-out authorization method oops

* Make nav buttons a bit more clear

* Fix merge conflict

* Fix adding org id for /api/articles and tests

* Fix tests for org policy

* Use proper logic for displaying org members

* Update org actions with new authorization

* Use correct org when creating a listing

* Remove additional payment charge oops

* Mark org notifications as read with authorization

* Remove deprecated post_as_organization attribute

* Use new org_admin syntax

* Remove deprecated org logic for article create and update

* Default all RSS posts to not belong to any org

* Render org_member page for guest users

* Update org policy spec to work with multi orgs

* Use org_membership for org traits and move identity code

* Use org_member trait

* Update to work with multi-orgs

* Validate article's org_id if param org_id is blank

* Make  a let variable

* Remove unnecessary eager load for credits

* Fix HTML structure and org logic for non-org users

* Update credits spec for multi-org

* Add test for failed payment when purchased by org

* Lint listings_spec

* Test that the listing was created under the user

* Add tests for POST /listings multi-org

* Use double quotes for classes

* Fix /manage and a few other multi-org bugs

* Fix test for multi org

* Use correct method SQL exists? not Rails exist?

* Fix reads spec for multi-org

* Fix org_controller actions to work with multi org

* Test only multi org and not old usage and fix leave_org

* Fix org showing user profile img test for multi-org

* Fix org logic for users with no orgs

* Remove switch org functionality

* Update tests and add hidden param for org id

* Redirect to the specific organization

* Test other org button actions

* Use settings_notice instead of legacy notice and refactor

* Fix weird extra end issue prob from merge conflicts

* Test for with new flash key

* Fix user_views_org tests for multi-org

* Test for new flash message

* Update snapshot with new a11y html

* Move styling to stylesheet

* Add site admins functionality

* Move org_member? method in user model and refactor

* Use unspent_credits_count for organizations

* Add tests for /listings/new and minor bug fixes

* Use .present? in case of empty array

* Fix a lingering deprecated method

* Use greater than 1 for random numbers

* Add tests for counting spent and unspent credits
2019-06-04 09:30:52 -04:00

127 lines
4.8 KiB
Ruby

require "rails_helper"
RSpec.describe "UserOrganization", type: :request do
let(:user) { create(:user) }
let(:organization) { create(:organization, secret: "SECRET", approved: true) }
context "when joining an org" do
before { sign_in user }
it "creates an organization_membership association" do
post "/users/join_org", params: { org_secret: organization.secret }
org_membership = OrganizationMembership.first
expect(org_membership.persisted?).to eq true
expect(org_membership.user).to eq user
expect(org_membership.organization).to eq organization
expect(org_membership.type_of_user).to eq "member"
end
it "shows an error message if secret is invalid" do
post "/users/join_org", params: { org_secret: "NOT SECRET" }
expect(flash[:error]).to eq "The given organization secret was invalid."
end
it "correctly strips the secret of the org_secret param" do
post "/users/join_org", params: { org_secret: organization.secret + " " }
expect(OrganizationMembership.exists?(user: user, organization: organization)).to eq true
end
end
context "when creating a new org" do
before do
sign_in user
org_params = build(:organization).attributes
org_params["profile_image"] = Rack::Test::UploadedFile.new(Rails.root.join("app", "assets", "images", "android-icon-36x36.png"), "image/jpeg")
post "/organizations", params: { organization: org_params }
end
it "creates the correct organization_membership association" do
org_membership = OrganizationMembership.first
expect(org_membership.persisted?).to eq true
expect(org_membership.user).to eq user
expect(org_membership.organization).to eq Organization.last
expect(org_membership.type_of_user).to eq "admin"
end
it "redirects to the proper org settings page" do
expect(response.status).to eq 302
expect(response.redirect_url).to include "/settings/organization/#{Organization.last.id}"
end
end
context "when leaving an org" do
let(:org_member) { create(:user, :org_member) }
before { sign_in org_member }
it "leaves org and deletes the member's organization membership" do
org_id = org_member.organizations.first.id
post "/users/leave_org/#{org_id}"
expect(OrganizationMembership.exists?(user_id: org_member.id, organization_id: org_id)).to eq false
end
end
context "when adding an org admin" do
let(:org_admin) { create(:user, :org_admin) }
let(:org_member) { create(:user, :org_member) }
let(:org_id) { org_admin.organizations.first.id }
let(:user2) { create(:user) }
def add_org_admin
org_admin
create(:organization_membership, user_id: user2.id, organization_id: org_id)
sign_in org_admin
post "/users/add_org_admin", params: { user_id: user2.id, organization_id: org_id }
end
it "adds org admin" do
org = org_admin.organizations.first
add_org_admin
expect(user2.org_admin?(org)).to eq(true)
end
it "creates the org_membership association" do
add_org_admin
org_membership = OrganizationMembership.last
expect(org_membership.persisted?).to eq true
expect(org_membership.user_id).to eq user2.id
expect(org_membership.organization_id).to eq org_id
expect(org_membership.type_of_user).to eq "admin"
end
it "raises not_authorized if user is not org_admin" do
org_member_org_id = org_member.organizations.first.id
sign_in org_member
expect { post "/users/add_org_admin", params: { user_id: user2.id, organization_id: org_member_org_id } }.
to raise_error Pundit::NotAuthorizedError
end
end
context "when removing an org admin" do
let(:org_admin) { create(:user, :org_admin) }
let(:org_id) { org_admin.organizations.first.id }
let(:second_org_admin) { create(:user, :org_admin) }
before do
second_org_admin.organization_memberships.update_all(organization_id: org_id)
sign_in org_admin
end
it "removes org admin" do
post "/users/remove_org_admin", params: { user_id: second_org_admin.id, organization_id: org_id }
expect(second_org_admin.org_admin?(org_id)).to eq false
end
it "updates the correct org_membership association to a member level" do
org_membership = second_org_admin.organization_memberships.first
post "/users/remove_org_admin", params: { user_id: second_org_admin.id, organization_id: org_id }
expect(org_membership.reload.type_of_user).to eq "member"
end
it "remove_org_admin raises if user not org_admin" do
org_admin.organization_memberships.update_all(type_of_user: "member")
expect { post "/users/remove_org_admin", params: { user_id: second_org_admin.id, organization_id: org_id } }.
to raise_error Pundit::NotAuthorizedError
end
end
end