* Allow user to have many orgs * Allow users to handle multi orgs in settings * Make rounded buttons inline * Add multi org function to dashboards * Fix merge conflicts * Fix mistake in merge conflict fix oops * Display the correct membership level * Fix accessibility issues * Display organizations for article editors * Handle submitting org id with preact editors * Make listings work with multiple organizations * Allow listings to have multiple orgs on create * Display the correct number of credits for each org * Move script tag to Webpack * Allow multi orgs for purchasing and viewing credits * Use OrganizationMembership as authorization check * Display multiple organizations for notifications * Allow dashboard to be viewable under multi-orgs * Remove unused method * Add multi-org functionality for article editors * Show pro dashboard buttons for member+ org levels * Leave the correct organization * Allow article API to change org id * Add left-out authorization method oops * Make nav buttons a bit more clear * Fix merge conflict * Fix adding org id for /api/articles and tests * Fix tests for org policy * Use proper logic for displaying org members * Update org actions with new authorization * Use correct org when creating a listing * Remove additional payment charge oops * Mark org notifications as read with authorization * Remove deprecated post_as_organization attribute * Use new org_admin syntax * Remove deprecated org logic for article create and update * Default all RSS posts to not belong to any org * Render org_member page for guest users * Update org policy spec to work with multi orgs * Use org_membership for org traits and move identity code * Use org_member trait * Update to work with multi-orgs * Validate article's org_id if param org_id is blank * Make a let variable * Remove unnecessary eager load for credits * Fix HTML structure and org logic for non-org users * Update credits spec for multi-org * Add test for failed payment when purchased by org * Lint listings_spec * Test that the listing was created under the user * Add tests for POST /listings multi-org * Use double quotes for classes * Fix /manage and a few other multi-org bugs * Fix test for multi org * Use correct method SQL exists? not Rails exist? * Fix reads spec for multi-org * Fix org_controller actions to work with multi org * Test only multi org and not old usage and fix leave_org * Fix org showing user profile img test for multi-org * Fix org logic for users with no orgs * Remove switch org functionality * Update tests and add hidden param for org id * Redirect to the specific organization * Test other org button actions * Use settings_notice instead of legacy notice and refactor * Fix weird extra end issue prob from merge conflicts * Test for with new flash key * Fix user_views_org tests for multi-org * Test for new flash message * Update snapshot with new a11y html * Move styling to stylesheet * Add site admins functionality * Move org_member? method in user model and refactor * Use unspent_credits_count for organizations * Add tests for /listings/new and minor bug fixes * Use .present? in case of empty array * Fix a lingering deprecated method * Use greater than 1 for random numbers * Add tests for counting spent and unspent credits
288 lines
11 KiB
Ruby
288 lines
11 KiB
Ruby
class ArticlesController < ApplicationController
|
|
include ApplicationHelper
|
|
before_action :authenticate_user!, except: %i[feed new]
|
|
before_action :set_article, only: %i[edit manage update destroy]
|
|
before_action :raise_banned, only: %i[new create update]
|
|
before_action :set_cache_control_headers, only: %i[feed]
|
|
after_action :verify_authorized
|
|
|
|
def feed
|
|
skip_authorization
|
|
|
|
@articles = Article.published.
|
|
select(:published_at, :processed_html, :user_id, :organization_id, :title, :path).
|
|
order(published_at: :desc).
|
|
page(params[:page].to_i).per(12)
|
|
|
|
@articles = if params[:username]
|
|
handle_user_or_organization_feed
|
|
elsif params[:tag]
|
|
handle_tag_feed
|
|
else
|
|
@articles.where(featured: true).includes(:user)
|
|
end
|
|
|
|
unless @articles
|
|
render body: nil
|
|
return
|
|
end
|
|
|
|
set_surrogate_key_header "feed"
|
|
response.headers["Surrogate-Control"] = "max-age=600, stale-while-revalidate=30, stale-if-error=86400"
|
|
|
|
render layout: false
|
|
end
|
|
|
|
def new
|
|
base_editor_assigments
|
|
@article = if @tag.present? && @user&.editor_version == "v2"
|
|
authorize Article
|
|
submission_template = @tag.submission_template_customized(@user.name).to_s
|
|
Article.new(body_markdown: submission_template.split("---").last.to_s.strip, cached_tag_list: @tag.name,
|
|
processed_html: "", user_id: current_user&.id, title: submission_template.split("title:")[1].to_s.split("\n")[0].to_s.strip)
|
|
elsif @tag&.submission_template.present? && @user
|
|
authorize Article
|
|
Article.new(body_markdown: @tag.submission_template_customized(@user.name),
|
|
processed_html: "", user_id: current_user&.id)
|
|
elsif @prefill.present? && @user&.editor_version == "v2"
|
|
authorize Article
|
|
Article.new(body_markdown: @prefill.split("---").last.to_s.strip, cached_tag_list: @prefill.split("tags:")[1].to_s.split("\n")[0].to_s.strip,
|
|
processed_html: "", user_id: current_user&.id, title: @prefill.split("title:")[1].to_s.split("\n")[0].to_s.strip)
|
|
elsif @prefill.present? && @user
|
|
authorize Article
|
|
Article.new(body_markdown: @prefill,
|
|
processed_html: "", user_id: current_user&.id)
|
|
elsif @tag.present?
|
|
skip_authorization
|
|
Article.new(
|
|
body_markdown: "---\ntitle: \npublished: false\ndescription: \ntags: " + @tag.name + "\n---\n\n",
|
|
processed_html: "", user_id: current_user&.id
|
|
)
|
|
else
|
|
skip_authorization
|
|
if @user&.editor_version == "v2"
|
|
Article.new(user_id: current_user&.id)
|
|
else
|
|
Article.new(
|
|
body_markdown: "---\ntitle: \npublished: false\ndescription: \ntags: \n---\n\n",
|
|
processed_html: "", user_id: current_user&.id
|
|
)
|
|
end
|
|
end
|
|
end
|
|
|
|
def edit
|
|
authorize @article
|
|
@version = @article.has_frontmatter? ? "v1" : "v2"
|
|
@user = @article.user
|
|
@organizations = @user&.organizations
|
|
end
|
|
|
|
def manage
|
|
@article = @article.decorate
|
|
authorize @article
|
|
@user = @article.user
|
|
@rating_vote = RatingVote.where(article_id: @article.id, user_id: @user.id).first
|
|
@buffer_updates = BufferUpdate.where(composer_user_id: @user.id, article_id: @article.id)
|
|
@organizations = @user&.organizations
|
|
# TODO: fix this for multi orgs
|
|
@org_members = @organization.users.pluck(:name, :id) if @organization
|
|
end
|
|
|
|
def preview
|
|
authorize Article
|
|
|
|
begin
|
|
fixed_body_markdown = MarkdownFixer.fix_for_preview(params[:article_body])
|
|
parsed = FrontMatterParser::Parser.new(:md).call(fixed_body_markdown)
|
|
parsed_markdown = MarkdownParser.new(parsed.content)
|
|
processed_html = parsed_markdown.finalize
|
|
rescue StandardError => e
|
|
@article = Article.new(body_markdown: params[:article_body])
|
|
@article.errors[:base] << ErrorMessageCleaner.new(e.message).clean
|
|
end
|
|
|
|
respond_to do |format|
|
|
if @article
|
|
format.json { render json: @article.errors, status: :unprocessable_entity }
|
|
else
|
|
format.json do
|
|
render json: {
|
|
processed_html: processed_html,
|
|
title: parsed["title"],
|
|
tags: (Article.new.tag_list.add(parsed["tags"], parser: ActsAsTaggableOn::TagParser) if parsed["tags"]),
|
|
cover_image: (ApplicationController.helpers.cloud_cover_url(parsed["cover_image"]) if parsed["cover_image"])
|
|
}
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def create
|
|
authorize Article
|
|
|
|
@user = current_user
|
|
@article = ArticleCreationService.new(@user, article_params_json).create!
|
|
|
|
render json: if @article.persisted?
|
|
@article.to_json(only: [:id], methods: [:current_state_path])
|
|
else
|
|
@article.errors.to_json
|
|
end
|
|
end
|
|
|
|
def update
|
|
authorize @article
|
|
@user = @article.user || current_user
|
|
not_found if @article.user_id != @user.id && !@user.has_role?(:super_admin)
|
|
edited_at_date = if @article.user == current_user && @article.published
|
|
Time.current
|
|
else
|
|
@article.edited_at
|
|
end
|
|
|
|
updated = @article.update(article_params_json.merge(edited_at: edited_at_date))
|
|
Notification.send_to_followers(@article, "Published") if updated && @article.published && @article.saved_changes["published_at"]&.include?(nil)
|
|
|
|
respond_to do |format|
|
|
format.html do
|
|
# NOTE: destination is used by /dashboard/organization when it re-assigns an article
|
|
# not a great solution but for now it will do
|
|
redirect_to(params[:destination] || @article.path)
|
|
end
|
|
|
|
format.json do
|
|
render json: if updated
|
|
@article.to_json(only: [:id], methods: [:current_state_path])
|
|
else
|
|
@article.errors.to_json
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def delete_confirm
|
|
@article = current_user.articles.find_by(slug: params[:slug])
|
|
authorize @article
|
|
end
|
|
|
|
def destroy
|
|
authorize @article
|
|
@article.destroy!
|
|
Notification.remove_all_without_delay(notifiable_id: @article.id, notifiable_type: "Article", action: "Published")
|
|
Notification.remove_all(notifiable_id: @article.id, notifiable_type: "Article", action: "Reaction")
|
|
respond_to do |format|
|
|
format.html { redirect_to "/dashboard", notice: "Article was successfully deleted." }
|
|
format.json { head :no_content }
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def base_editor_assigments
|
|
@user = current_user
|
|
@version = @user.editor_version if @user
|
|
@organizations = @user&.organizations
|
|
@tag = Tag.find_by(name: params[:template])
|
|
@prefill = params[:prefill].to_s.gsub("\\n ", "\n").gsub("\\n", "\n")
|
|
end
|
|
|
|
def handle_user_or_organization_feed
|
|
if (@user = User.find_by(username: params[:username]))
|
|
@articles = @articles.where(user_id: @user.id)
|
|
elsif (@user = Organization.find_by(slug: params[:username]))
|
|
@articles = @articles.where(organization_id: @user.id).includes(:user)
|
|
end
|
|
end
|
|
|
|
def handle_tag_feed
|
|
tag = Tag.find_by(name: params[:tag].downcase)
|
|
|
|
return unless tag
|
|
|
|
@tag = tag.alias_for.presence || tag
|
|
@articles = @articles.cached_tagged_with(@tag)
|
|
end
|
|
|
|
def set_article
|
|
owner = User.find_by(username: params[:username]) || Organization.find_by(slug: params[:username])
|
|
found_article = if params[:slug]
|
|
owner.articles.find_by(slug: params[:slug])
|
|
else
|
|
Article.includes(:user).find(params[:id])
|
|
end
|
|
@article = found_article || not_found
|
|
end
|
|
|
|
def article_params
|
|
params[:article][:published] = true if params[:submit_button] == "PUBLISH"
|
|
modified_params = policy(Article).permitted_attributes
|
|
modified_params << :user_id if org_admin_user_change_privilege
|
|
modified_params << :comment_template if current_user.has_role?(:admin)
|
|
params.require(:article).permit(modified_params)
|
|
end
|
|
|
|
# TODO: refactor all of this update logic into the Articles::Updater possibly,
|
|
# ideally there should only be one place to handle the update logic
|
|
def article_params_json
|
|
params.require(:article) # to trigger the correct exception in case `:article` is missing
|
|
|
|
params["article"].transform_keys!(&:underscore)
|
|
|
|
# handle series/collections
|
|
if params["article"]["series"].present?
|
|
params["article"]["collection_id"] = Collection.find_series(params["article"]["series"], @user)&.id
|
|
elsif params["article"]["series"] == ""
|
|
params["article"]["collection_id"] = nil
|
|
end
|
|
|
|
allowed_params = if params["article"]["version"] == "v1"
|
|
%i[body_markdown]
|
|
else
|
|
%i[
|
|
title body_markdown main_image published description
|
|
tag_list canonical_url series collection_id
|
|
]
|
|
end
|
|
|
|
# NOTE: the organization logic is still a little counter intuitive but this should
|
|
# fix the bug <https://github.com/thepracticaldev/dev.to/issues/2871>
|
|
if params["article"]["user_id"] && org_admin_user_change_privilege
|
|
allowed_params << :user_id
|
|
elsif params["article"]["organization_id"] && allowed_to_change_org_id?
|
|
# change the organization of the article only if explicitly asked to do so
|
|
allowed_params << :organization_id
|
|
end
|
|
|
|
params.require(:article).permit(allowed_params)
|
|
end
|
|
|
|
def redirect_after_creation
|
|
@article.decorate
|
|
if @article.persisted?
|
|
redirect_to @article.current_state_path, notice: "Article was successfully created."
|
|
else
|
|
if @article.errors.to_h[:body_markdown] == "has already been taken"
|
|
@article = current_user.articles.find_by(body_markdown: @article.body_markdown)
|
|
redirect_to @article.current_state_path
|
|
return
|
|
end
|
|
render :new
|
|
end
|
|
end
|
|
|
|
def allowed_to_change_org_id?
|
|
potential_user = @article&.user || current_user
|
|
potential_org_id = params["article"]["organization_id"].presence || @article&.organization_id
|
|
OrganizationMembership.exists?(user: potential_user, organization_id: potential_org_id) ||
|
|
current_user.any_admin?
|
|
end
|
|
|
|
def org_admin_user_change_privilege
|
|
params[:article][:user_id] &&
|
|
# if current_user is an org admin of the article's org
|
|
current_user.org_admin?(@article.organization_id) &&
|
|
# and if the author being changed to belongs to the article's org
|
|
OrganizationMembership.exists?(user_id: params[:article][:user_id], organization_id: @article.organization_id)
|
|
end
|
|
end
|