docbrown/spec/requests/listings_spec.rb
Fabbri Paolo 89e893f157 Fix rubocop detected offenses (#4552)
* Run Inspecting 1050 files
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....................................................................................................................................................................................................................................................................................................

Offenses:

spec/models/article_spec.rb:195:7: C: RSpec/NestedGroups: Maximum example group nesting exceeded [4/3]. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups)
      context "when description is empty" do
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1050 files inspected, 1 offense detected to fix autofixable errors

* Refactor  to correct test

it was braking the rule RSpec/NestedGroups: Maximum example group nesting exceeded [4/3]. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups)

* Run `rubocop --auto-gen-config` to regenrate `.rubocop_todo.yml`
2019-10-24 11:53:03 -04:00

157 lines
5.6 KiB
Ruby

require "rails_helper"
RSpec.describe "/listings", type: :request do
let(:user) { create(:user) }
let(:organization) { create(:organization) }
describe "GETS /listings" do
it "has page content" do
get "/listings"
expect(response.body).to include("classified-filters")
end
it "has page content for category page" do
get "/listings/saas"
expect(response.body).to include("classified-filters")
end
end
describe "GETS /listings/new" do
it "has page content" do
get "/listings"
expect(response.body).to include("classified-filters")
end
end
describe "POST /listings" do
before do
create_list(:credit, 20, user_id: user.id)
sign_in user
end
it "creates proper listing if credits are available" do
post "/listings", params: {
classified_listing: { title: "Hey", category: "education", body_markdown: "hey hey my my" }
}
expect(ClassifiedListing.last.processed_html).to include("hey my")
end
it "spends credits" do
num_credits = Credit.where(spent: true).size
post "/listings", params: {
classified_listing: { title: "Hey", category: "education", body_markdown: "hey hey my my" }
}
expect(Credit.where(spent: true).size).to be > num_credits
end
it "adds tags" do
post "/listings", params: {
classified_listing: { title: "Hey", category: "education", body_markdown: "hey hey my my", tag_list: "ruby, rails, go" }
}
expect(ClassifiedListing.last.cached_tag_list).to include("rails")
end
it "creates the listing under the user" do
post "/listings", params: {
classified_listing: { title: "Hey", category: "education", body_markdown: "hey hey my my", tag_list: "ruby, rails, go" }
}
expect(ClassifiedListing.last.user_id).to eq user.id
end
it "creates the listing for the user if no organization_id is selected" do
create(:organization_membership, user_id: user.id, organization_id: organization.id)
post "/listings", params: {
classified_listing: { title: "Hey", category: "education", body_markdown: "hey hey my my", tag_list: "ruby, rails, go" }
}
expect(ClassifiedListing.last.organization_id).to eq nil
expect(ClassifiedListing.last.user_id).to eq user.id
end
it "creates the listing for the organization" do
create(:organization_membership, user_id: user.id, organization_id: organization.id)
post "/listings", params: {
classified_listing: { title: "Hey", category: "education", body_markdown: "hey hey my my", tag_list: "ruby, rails, go", organization_id: organization.id }
}
expect(ClassifiedListing.last.organization_id).to eq(organization.id)
end
it "does not create an org listing if a different org member doesn't belong to the org" do
another_org = create(:organization)
create(:organization_membership, user_id: user.id, organization_id: another_org.id)
expect do
post "/listings", params: {
classified_listing: { title: "Hey", category: "education", body_markdown: "hey hey my my", tag_list: "ruby, rails, go", organization_id: organization.id }
}
end.to raise_error Pundit::NotAuthorizedError
end
end
describe "GETS /listings/edit" do
let(:classified_listing) { create(:classified_listing, user_id: user.id) }
before do
create_list(:credit, 20, user_id: user.id)
sign_in user
end
it "has page content" do
get "/listings/#{classified_listing.id}/edit"
expect(response.body).to include("You can bump your listing")
end
end
describe "PUT /listings/:id" do
let(:classified_listing) { create(:classified_listing, user_id: user.id) }
before do
create_list(:credit, 20, user_id: user.id)
sign_in user
end
it "updates bumped_at if action is bump" do
put "/listings/#{classified_listing.id}", params: {
classified_listing: { action: "bump" }
}
expect(ClassifiedListing.last.bumped_at).to be > 10.seconds.ago
end
it "updates publish if action is unpublish" do
put "/listings/#{classified_listing.id}", params: {
classified_listing: { action: "unpublish" }
}
expect(ClassifiedListing.last.published).to eq(false)
end
it "updates body_markdown" do
put "/listings/#{classified_listing.id}", params: {
classified_listing: { body_markdown: "hello new markdown" }
}
expect(ClassifiedListing.last.body_markdown).to eq("hello new markdown")
end
it "does not update body_markdown if not bumped/created recently" do
classified_listing.update_column(:bumped_at, 50.hours.ago)
put "/listings/#{classified_listing.id}", params: {
classified_listing: { body_markdown: "hello new markdown" }
}
expect(ClassifiedListing.last.body_markdown).not_to eq("hello new markdown")
end
it "updates other fields" do
put "/listings/#{classified_listing.id}", params: {
classified_listing: { body_markdown: "hello new markdown", title: "New title!", tag_list: "new, tags, hey" }
}
expect(ClassifiedListing.last.title).to eq("New title!")
expect(ClassifiedListing.last.cached_tag_list).to include("hey")
end
it "does not update other fields" do
classified_listing.update_column(:bumped_at, 50.hours.ago)
put "/listings/#{classified_listing.id}", params: {
classified_listing: { body_markdown: "hello new markdown", title: "New title!", tag_list: "new, tags, hey" }
}
expect(ClassifiedListing.last.title).not_to eq("New title!")
expect(ClassifiedListing.last.cached_tag_list).not_to include("hey")
end
end
end