docbrown/app
Jeremy Friesen 446e74ca83
Documenting and addl testing FeatureFlag.enabled? (#16420)
Prior to this commit, we had a single test for `FeatureFlag.enabled?`,
namely that it delegates to `Flipper.enabled?`.  This commit adds some
tests to both verify behavior and communicate to developers the
intentions of the related methods:

- `FeatureFlag.enabled?`
- `FeatureFlag.accessible?`

My hope is the documentation and tests will help address the horrors
mentioned in conversation in #16416:

> I have lived the horrors of having a feature flag accidently
> flipped or incorrectly setup in the first place and half baked
> functionality going live.

Note: I'm not proposing that we test other `Flipper` methods, but
instead to ensure that we're testing and documenting the behavior of
what I believe to be the two primary mechanisms of "putting something
behind a feature flag."

Related to #16406, #16416
2022-02-07 08:53:30 -05:00
..
assets Copy organization secret code to clipboard (#16358) 2022-02-04 08:22:03 +00:00
components/admin/users Change UI instances of "vomit" to "flag" (#16397) 2022-02-03 12:22:32 +00:00
controllers A suspended user returns 403 instead of 500 (#16408) 2022-02-04 09:42:23 -05:00
decorators app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
errors A suspended user returns 403 instead of 500 (#16408) 2022-02-04 09:42:23 -05:00
forms Using a Form Object that will persist for the Creator Settings Form (#15684) 2021-12-10 17:07:40 +02:00
helpers Adding conditional rendering of navigation links (#16362) 2022-02-01 12:23:58 -05:00
javascript Reworked some webpack aliases as prework for #16174. (#16412) 2022-02-04 06:34:37 -05:00
lib Easier feature flag handling for Cypress (#16379) 2022-02-03 10:42:13 -05:00
liquid_tags Implement Unified Embeds for Glitch URLs (#16378) 2022-02-01 12:01:26 -05:00
mailers app/mailers i18n (#16191) 2022-01-20 07:33:29 -07:00
models app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
policies Allow for skipping navigation link creation (#16112) 2022-01-17 17:22:24 -05:00
queries small non-views ruby i18n (#16004) 2022-01-11 10:05:18 +07:00
refinements
sanitizers Extracting container for allowed tags & attrs (#15338) 2021-12-16 12:24:45 -05:00
serializers Added "Tags" category to search results (#16265) 2022-01-26 20:51:15 +03:00
services Documenting and addl testing FeatureFlag.enabled? (#16420) 2022-02-07 08:53:30 -05:00
uploaders small non-views ruby i18n (#16004) 2022-01-11 10:05:18 +07:00
validators Remove the "Getting Started" Section from the Config (#16033) 2022-01-20 07:31:35 -07:00
view_objects Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
views A suspended user returns 403 instead of 500 (#16408) 2022-02-04 09:42:23 -05:00
workers Use perform_bulk in Podcasts::EnqueueGetEpisodesWorker (#16325) 2022-01-28 11:32:25 +07:00