docbrown/app/javascript/CommentSubscription/CommentSubscription.jsx
Jeremy Friesen 58a4d805d7
Preventing author profile from going transparent (#15478)
* Preventing author profile from going transparent

Prior to this change, when you would hover over an author profile that
was "close to" the bottom of the page, the card would be transparent
instead of the expected opaque.

With this change, when you hover over an author profile that is "close"
to the bottom of the page, the card renders as an opaque card.

Now why does this work?  I don't really know, except to say that a
`display: table` imperative is a more "chunky" display element than a
block.  I would love for someone to explain why this works.

Tested against on MacOS Safari, Firefox, and Chrome.

https://developer.mozilla.org/en-US/docs/Web/CSS/display

Fixes #15290

* revert table

* fix

* missed spot

* actions dropdown

Co-authored-by: Paweł Ludwiczak <ludwiczakpawel@gmail.com>
2021-11-24 09:38:13 -05:00

210 lines
6.5 KiB
JavaScript
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

/* global showLoginModal */
import { h, Component } from 'preact';
import PropTypes from 'prop-types';
import {
Button,
ButtonGroup,
Dropdown,
FormField,
RadioButton,
} from '@crayons';
export const COMMENT_SUBSCRIPTION_TYPE = Object.freeze({
ALL: 'all_comments',
TOP: 'top_level_comments',
AUTHOR: 'only_author_comments',
NOT_SUBSCRIBED: 'not_subscribed',
});
export class CommentSubscription extends Component {
constructor(props) {
const { subscriptionType } = props;
super(props);
const subscribed =
subscriptionType &&
(subscriptionType.length > 0 && subscriptionType) !==
COMMENT_SUBSCRIPTION_TYPE.NOT_SUBSCRIBED;
const initialState = {
subscriptionType: subscribed
? subscriptionType
: COMMENT_SUBSCRIPTION_TYPE.ALL,
subscribed,
showOptions: false,
};
this.state = initialState;
}
commentSubscriptionClick = (event) => {
this.setState({
subscriptionType: event.target.value,
});
};
render() {
const { subscriptionType, subscribed } = this.state;
const {
onSubscribe,
onUnsubscribe,
positionType = 'relative',
isLoggedIn,
} = this.props;
const CogIcon = () => (
<svg
xmlns="http://www.w3.org/2000/svg"
width="24"
height="24"
role="img"
aria-labelledby="ai2ols8ka2ohfp0z568lj68ic2du21s"
className="crayons-icon"
>
<title id="ai2ols8ka2ohfp0z568lj68ic2du21s">Preferences</title>
<path d="M12 1l9.5 5.5v11L12 23l-9.5-5.5v-11L12 1zm0 2.311L4.5 7.653v8.694l7.5 4.342 7.5-4.342V7.653L12 3.311zM12 16a4 4 0 110-8 4 4 0 010 8zm0-2a2 2 0 100-4 2 2 0 000 4z" />
</svg>
);
return (
<div className={positionType}>
<ButtonGroup
ref={(element) => {
this.buttonGroupElement = element;
}}
>
<Button
variant="outlined"
onClick={(_event) => {
if (isLoggedIn) {
if (subscribed) {
onUnsubscribe(COMMENT_SUBSCRIPTION_TYPE.NOT_SUBSCRIBED);
this.setState({
subscriptionType: COMMENT_SUBSCRIPTION_TYPE.ALL,
});
} else {
onSubscribe(subscriptionType);
}
this.setState({ subscribed: !subscribed });
} else {
showLoginModal();
}
}}
>
{subscribed ? 'Unsubscribe' : 'Subscribe'}
</Button>
{subscribed ? (
<Button
id="subscription-settings-btn"
data-testid="subscription-settings"
variant="outlined"
icon={CogIcon}
contentType="icon"
/>
) : null}
</ButtonGroup>
{subscribed && (
<Dropdown
triggerButtonId="subscription-settings-btn"
dropdownContentId="subscription-settings-dropdown"
dropdownContentCloseButtonId="subscription-settings-done-btn"
data-repositioning-dropdown="true"
data-testid="subscriptions-panel"
className={`right-0 p-4 s:left-auto${
positionType === 'relative' ? ' w-full' : ''
}`}
ref={(element) => {
this.dropdownElement = element;
}}
onOpen={() => this.setState({ showOptions: true })}
onClose={() => this.setState({ showOptions: false })}
>
<div className="crayons-fields mb-5">
<FormField variant="radio">
<RadioButton
id="subscribe-all"
name="subscribe_comments"
value={COMMENT_SUBSCRIPTION_TYPE.ALL}
checked={subscriptionType === COMMENT_SUBSCRIPTION_TYPE.ALL}
onClick={this.commentSubscriptionClick}
/>
<label htmlFor="subscribe-all" className="crayons-field__label">
All comments
<p className="crayons-field__description">
Youll receive notifications for all new comments.
</p>
</label>
</FormField>
<FormField variant="radio">
<RadioButton
id="subscribe-toplevel"
name="subscribe_comments"
value={COMMENT_SUBSCRIPTION_TYPE.TOP}
onClick={this.commentSubscriptionClick}
checked={subscriptionType === COMMENT_SUBSCRIPTION_TYPE.TOP}
/>
<label
htmlFor="subscribe-toplevel"
className="crayons-field__label"
>
Top-level comments
<p className="crayons-field__description">
Youll receive notifications only for all new top-level
comments.
</p>
</label>
</FormField>
<FormField variant="radio">
<RadioButton
id="subscribe-author"
name="subscribe_comments"
value={COMMENT_SUBSCRIPTION_TYPE.AUTHOR}
onClick={this.commentSubscriptionClick}
checked={
subscriptionType === COMMENT_SUBSCRIPTION_TYPE.AUTHOR
}
/>
<label
htmlFor="subscribe-author"
className="crayons-field__label"
>
Post author comments
<p className="crayons-field__description">
Youll receive notifications only if post author sends a new
comment.
</p>
</label>
</FormField>
</div>
<Button
id="subscription-settings-done-btn"
className="w-100"
onClick={() => {
onSubscribe(this.state.subscriptionType);
}}
>
Done
</Button>
</Dropdown>
)}
</div>
);
}
}
CommentSubscription.displayName = 'CommentSubscription';
CommentSubscription.propTypes = {
positionType: PropTypes.oneOf(['absolute', 'relative', 'static']).isRequired,
onSubscribe: PropTypes.func.isRequired,
onUnsubscribe: PropTypes.func.isRequired,
subscriptionType: PropTypes.oneOf(
Object.entries(COMMENT_SUBSCRIPTION_TYPE).map(([, value]) => value),
).isRequired,
isLoggedIn: PropTypes.bool.isRequired,
};