maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/app/models
History
Jeremy Friesen 3fb085b3d9
Adding more context to /admin/abtests (#17821) 
* Adding more context to `/admin/abtests`

Prior to this commit, the `/admin/abtests` was fully rendered by the
field_test gem (see
https://github.com/ankane/field_test/blob/master/app/views/field_test/experiments/index.html.erb
and
https://github.com/ankane/field_test/blob/master/app/views/field_test/experiments/show.html.erb).

With this commit, we're pre-pending our own
partial (e.g. `app/views/field_test/experiments/_experiments.html.erb`)
in the view paths; which means instead of rendering
https://github.com/ankane/field_test/blob/master/app/views/field_test/experiments/_experiments.html.erb
we render our newly created
`app/views/field_test/experiments/_experiments.html.erb`)

Why the ugly antics in the view?  As I'm not fully certain if this will
"meet" the full needs of those monitoring the experiments.  I'm also
constructing this to most closely match the spreadsheet that has been
assembled for tracking this information.

Why introduce another caching layer for the variant assembly?  The
original caching
layer (e.g. `Articles::Feeds::VariantAssembler.pre_assembled_variants`)
is in place to provide the quickest access to the assembled variants.
But due to the nature of the implemented view, we are needing a
programmatic representation of all variants.  And the added Rails cache
is there to minimize disk reads.

Closes forem/forem#17820

* Update app/models/articles/feeds/variant_assembler.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Update app/models/articles/feeds/variant_assembler.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2022-06-03 11:27:09 -04:00
..
ab_experiment Adding page view goal for experiments (#17696) 2022-05-16 15:07:42 -04:00
ahoy Favoring delete_all on user relationships (#15443) 2021-11-23 11:50:12 -05:00
articles Adding more context to /admin/abtests (#17821) 2022-06-03 11:27:09 -04:00
concerns Remove CustomProfileField (#14286) 2021-07-22 10:05:39 +07:00
liquid_tags [deploy] Add role and docs for user subscription liquid tag (#9170) 2020-07-08 14:07:53 -04:00
settings Remove sustaining member newsletter, and its settings (#17514) 2022-04-29 11:47:12 -05:00
users Remove GDPR from the "users" namespace (#17536) 2022-05-03 19:42:20 +02:00
ab_experiment.rb Exposing past feed experiments in /admin/abtests (#17818) 2022-06-02 20:41:31 -04:00
admin_menu.rb Update the Sidebar to include the Member Manager (#17538) 2022-05-05 12:46:47 +02:00
announcement.rb Add Polymorphism to Broadcasts (Part 1) (#9231) [deploy] 2020-07-13 09:36:19 -06:00
api_secret.rb Change API key limit from 20 to 10 (#17811) 2022-06-02 15:35:21 -05:00
application_record.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
article.rb chore: € character at article model TITLE_CHARACTERS_ALLOWED (#17790) 2022-05-31 12:26:30 -04:00
async_info.rb Moving from user.trusted tests to policy tests (#17619) 2022-05-11 08:18:13 -04:00
audit_log.rb Favoring constant over magic string (#15852) 2021-12-27 11:31:29 -05:00
badge.rb Refactor cache purging (#12811) 2021-03-02 10:09:05 -05:00
badge_achievement.rb Extracting container for allowed tags & attrs (#15338) 2021-12-16 12:24:45 -05:00
banished_user.rb Introduce BanishedUser table (#5589) [deploy] 2020-01-21 17:15:58 -05:00
broadcast.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
campaign.rb [Small win] Add display name to campaign settings (#16653) 2022-02-22 10:01:52 -05:00
collection.rb Series count to only include non empty series (#16130) 2022-01-18 10:22:34 +07:00
comment.rb Moving Experiments into AbExperiment namespace (#17532) 2022-05-03 21:34:12 -04:00
config.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00
consumer_app.rb Fixes a name conflict in Rpush models (#15978) 2022-01-07 09:38:16 -06:00
context_notification.rb Context Notifications (#17243) 2022-04-18 10:30:30 +03:00
creator_setting.rb Creator Onboarding: Creator Setup View (#14728) 2021-11-01 15:50:08 -04:00
credit.rb Favor repurposing existing scope (#15914) 2022-01-03 09:30:34 -05:00
data_update_script.rb Navigation Items and Role access for Data Update Scripts (#12292) 2021-02-09 17:41:14 +02:00
device.rb Spelling (#15702) 2021-12-07 06:59:10 -07:00
discussion_lock.rb Renaming method for clarity (#16791) 2022-03-07 12:55:56 -05:00
display_ad.rb Extracting container for allowed tags & attrs (#15338) 2021-12-16 12:24:45 -05:00
display_ad_event.rb Extracting constants and tidying tests (#15946) 2022-01-05 09:19:39 -05:00
email_authorization.rb Refactor Admin Member Detail view - Tools section (#14283) 2021-08-17 18:55:53 +02:00
email_message.rb Delete old retained emails after certain period (#14949) 2021-10-12 16:27:13 -04:00
extension.rb Introduce "extensions" (#16840) 2022-03-18 11:22:17 +02:00
feedback_message.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
follow.rb Refactoring cached_followed_tags (#16175) 2022-01-24 19:53:48 -05:00
forem_instance.rb "Reply to" and "From" Email addresses for SMTP Configurations (#16499) 2022-02-16 16:14:54 +02:00
gdpr_delete_request.rb feat: add an inflection and change instances of gdpr to GDPR (#17567) 2022-05-04 16:20:46 +02:00
github_issue.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
github_repo.rb POC: use Sidekiq.perform_bulk for Github repos (#16293) 2022-01-26 09:11:07 +07:00
html_variant.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
html_variant_success.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
html_variant_trial.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
identity.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
invitation.rb [deploy] Invite users to join and create password (#9294) 2020-07-15 11:37:19 -04:00
listing.rb Conditionally disabling Listings (Waiting on Product but technically Good to Go) (#16437) 2022-04-11 20:23:56 -04:00
listing_category.rb [deploy] Manage listing categories in dashboard (#10506) 2020-10-02 11:05:09 -04:00
mention.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
mod.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00
moderator_action.rb [deploy] Moderator and admin actions log (#6797) 2020-03-26 16:59:24 -05:00
navigation_link.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
note.rb Favoring delete_all on user relationships (#15443) 2021-11-23 11:50:12 -05:00
notification.rb Ensure arguments to perform_async are json safe (#16285) 2022-01-25 18:07:40 -06:00
notification_subscription.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
organization.rb Ensuring article's cache updates on org image update (#17052) 2022-04-01 10:54:55 -04:00
organization_membership.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
overview.rb Add admin overview page (#12726) 2021-03-01 18:59:05 -06:00
page.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
page_view.rb Moving Experiments into AbExperiment namespace (#17532) 2022-05-03 21:34:12 -04:00
permission.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00
pinned_article.rb Pin posts to feed (#13807) 2021-06-04 10:54:53 +02:00
podcast.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
podcast_episode.rb Various cleanups (#14616) 2021-08-31 09:17:24 +07:00
podcast_episode_appearance.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
podcast_ownership.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
poll.rb Refactoring poll/vote/skip logic (#15441) 2021-11-29 10:52:32 -05:00
poll_option.rb Favoring dependent: :delete_all over :destroy (#15442) 2021-11-24 13:56:16 -05:00
poll_skip.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
poll_vote.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
privileged_reaction.rb [deploy] New Feature: Mod Actions Panel (#7777) 2020-06-08 13:24:18 -04:00
profile.rb Profile attribute names should be unique and non-empty (#16396) 2022-04-04 12:14:02 -05:00
profile_field.rb Profile attribute names should be unique and non-empty (#16396) 2022-04-04 12:14:02 -05:00
profile_field_group.rb [deploy] /profile/settings page rendering (Ridhwana/Michael) (#10733) 2020-10-20 09:18:13 -04:00
profile_pin.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
rating_vote.rb Removing deprecated User methods (#16435) 2022-02-07 10:32:58 -05:00
reaction.rb Adding more goals to feed experiments (#17673) 2022-05-13 13:22:06 -04:00
response_template.rb Removing deprecated User methods (#16435) 2022-02-07 10:32:58 -05:00
role.rb added ability to assign moderator role via admin/super admin (#17759) 2022-05-26 10:57:08 -04:00
secret.rb [deploy] Feature: Setup Admin Area to Update Vault Secrets (#8935) 2020-06-29 15:08:09 -05:00
space.rb Busting tag cache when space changes (#17384) 2022-04-20 16:37:34 -04:00
sponsorship.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
tag.rb Renaming method for clarity (#16791) 2022-03-07 12:55:56 -05:00
tag_adjustment.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
timeframe.rb Remove timeframer from app/labor (#11782) 2020-12-08 12:52:33 +07:00
tool.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00
tweet.rb Better error upon Tweet embed when Twitter keys missing (#16916) 2022-03-21 16:21:37 -04:00
user.rb Remove sustaining member newsletter, and its settings (#17514) 2022-04-29 11:47:12 -05:00
user_block.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
user_role.rb [Search 2.0] Users (#13453) 2021-04-24 19:06:06 +02:00
user_subscription.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
welcome.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00
welcome_notification.rb Add Polymorphism to Broadcasts (Part 1) (#9231) [deploy] 2020-07-13 09:36:19 -06:00