41463a7264
* De-duplicate giphy_img? function in favor of a tested service. Add a tested `GiphyService` and move `giphy_img?` function to it. Make `labor/markdown_parser.rb` and `models/html_variant.rb` use the service version of the function. * Refactor GiphyService into Giphy::Image class Based on comments from @rhymes, I've changed this into a `Giphy::Image` class sincethe repo is currently being moved away from `XYZService` objects for namespacing and organization purposes. * Fix typo Update describe case to mention the current method name.
78 lines
2.5 KiB
Ruby
78 lines
2.5 KiB
Ruby
class HtmlVariant < ApplicationRecord
|
|
include CloudinaryHelper
|
|
|
|
validates :html, presence: true
|
|
validates :name, uniqueness: true
|
|
validates :group, inclusion: { in: %w[article_show_sidebar_cta article_show_below_article_cta badge_landing_page] }
|
|
validates :success_rate, presence: true
|
|
validate :no_edits
|
|
belongs_to :user, optional: true
|
|
has_many :html_variant_trials
|
|
has_many :html_variant_successes
|
|
before_save :prefix_all_images
|
|
|
|
def calculate_success_rate!
|
|
self.success_rate = html_variant_successes.size.to_f / (html_variant_trials.size * 10.0) # x10 because we only capture every 10th
|
|
save!
|
|
end
|
|
|
|
def self.find_for_test(tags = [], group = "article_show_sidebar_cta")
|
|
tags_array = tags + ["", nil]
|
|
if rand(10) == 1 # 10% return completely random
|
|
find_random_for_test(tags_array, group)
|
|
else # 90% chance return one in top 10
|
|
find_top_for_test(tags_array, group)
|
|
end
|
|
end
|
|
|
|
def self.find_top_for_test(tags_array, group)
|
|
where(group: group, approved: true, published: true, target_tag: tags_array).order("success_rate DESC").limit(rand(1..15)).sample
|
|
end
|
|
|
|
def self.find_random_for_test(tags_array, group)
|
|
where(group: group, approved: true, published: true, target_tag: tags_array).order(Arel.sql("RANDOM()")).first
|
|
end
|
|
|
|
private
|
|
|
|
def no_edits
|
|
errors.add(:base, "cannot change once published and approved") if (approved && (html_changed? || name_changed? || group_changed?)) && persisted?
|
|
end
|
|
|
|
def prefix_all_images
|
|
# wrap with Cloudinary or allow if from giphy or githubusercontent.com
|
|
doc = Nokogiri::HTML.fragment(html)
|
|
doc.css("img").each do |img|
|
|
src = img.attr("src")
|
|
next unless src
|
|
next if allowed_image_host?(src)
|
|
|
|
img["src"] = if Giphy::Image.valid_url?(src)
|
|
src.gsub("https://media.", "https://i.")
|
|
else
|
|
img_of_size(src, 420)
|
|
end
|
|
end
|
|
self.html = doc.to_html
|
|
end
|
|
|
|
def allowed_image_host?(src)
|
|
src.start_with?("https://res.cloudinary.com/")
|
|
end
|
|
|
|
def img_of_size(source, width = 420)
|
|
quality = if source && (source.include? ".gif")
|
|
66
|
|
else
|
|
"auto"
|
|
end
|
|
cl_image_path(source,
|
|
type: "fetch",
|
|
width: width,
|
|
crop: "limit",
|
|
quality: quality,
|
|
flags: "progressive",
|
|
fetch_format: "auto",
|
|
sign_url: true).gsub(",", "%2C")
|
|
end
|
|
end
|