maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/app/services
History
Jeremy Friesen 6e81773319
Favoring explicit class declaration (#17042) 
In helping track down forem/forem#17041 I was looking at our cache
busting logic.  We were looking up a constant via the `.const_get` call
from a string already defined inline.  This refactor short-circuits
naming a string, capitalizing it, then looking in the class's registered
constants.

There's also a subtle bug in the original; When `provider` equals
"another_cache", the `#capitalize` method would return
`"Another_cache"`, whereas `#classify` will return `"AnotherCache"`.

Below are some benchmarks for the change.

```ruby
require "benchmark"

module EdgeCache
  class Bust
    def by_class
      Fastly
    end

    def by_const_get
      self.class.const_get("fastly".classify)
    end
  end
end

Benchmark.bmbm do |x|
  x.report("by_class") do
    1000.times do
      EdgeCache::Bust.new.by_class
    end
  end
  x.report("by_const_get") do
    1000.times do
      EdgeCache::Bust.new.by_const_get
    end
  end
end
```

```shell
> bin/rails runner /Users/jfriesen/git/forem/bench.rb

Rehearsal ------------------------------------------------
by_class       0.001239   0.000186   0.001425 (  0.001342)
by_const_get   0.011398   0.000136   0.011534 (  0.011538)
--------------------------------------- total: 0.012959sec

                   user     system      total        real
by_class       0.000973   0.000030   0.001003 (  0.000969)
by_const_get   0.011102   0.000032   0.011134 (  0.011104)
```
2022-03-29 13:52:11 -04:00
..
admin Admin analytics (#16528) 2022-03-28 21:51:51 +02:00
articles Improve the UX of the SMTP Section (#16223) 2022-02-15 18:40:14 +02:00
audit Adding :internal auditing for admin/spaces#update (#17010) 2022-03-25 14:25:13 -04:00
authentication Rebranding from passport to forem account (#16754) 2022-03-09 10:03:16 -06:00
badges app/services i18n (#16189) 2022-01-20 09:25:25 -05:00
broadcasts/welcome_notification app/services i18n (#16189) 2022-01-20 09:25:25 -05:00
color Color tokens (#16107) 2022-01-21 07:41:03 +01:00
credits More ListingsToolkit refactoring (#16221) 2022-01-27 09:47:41 +07:00
discover Add Forem Discover registration worker and service (#14865) 2021-10-01 10:27:31 -04:00
edge_cache Favoring explicit class declaration (#17042) 2022-03-29 13:52:11 -04:00
error_messages Add a contact email address to the /admin/customization/config (#16497) 2022-02-15 17:37:08 +02:00
exporter Fix app/services' ruby 2.7 kwargs warnings (#13177) 2021-04-01 18:40:50 -04:00
fastly_config Abstract DatadogStatsClient to ForemStatsClient (#12304) 2021-01-27 11:25:44 -05:00
feeds validate will send forem feeds importer user agent, just like import (#16925) 2022-03-21 16:43:24 -05:00
follows Fix UI showing "Following" after unfollowing a user (#13757) 2021-05-19 17:40:38 +01:00
giphy Deduplicate giphy_img? function and add tests (#4590) 2019-10-30 11:40:17 -04:00
github Spelling (#15702) 2021-12-07 06:59:10 -07:00
homepage Extracting duplicate logic (#16035) 2022-01-10 15:19:04 -05:00
html Refactor FastImage usage (#16304) 2022-01-26 09:48:03 -05:00
images Addressing rubocop violations (#16156) 2022-01-17 17:21:06 -05:00
listings More listings refactoring (#16343) 2022-02-23 13:44:30 +07:00
loggers Rubocop fixes (#15892) 2021-12-28 09:11:41 -06:00
mailchimp app/services i18n (#16189) 2022-01-20 09:25:25 -05:00
markdown_processor Allowing dependency injection for LiquidTag policy (#16511) 2022-02-10 07:47:16 -05:00
mentions Issue #9077 has already been resolved, added specs (#15342) 2021-11-17 11:27:50 +02:00
moderator app/services i18n (#16189) 2022-01-20 09:25:25 -05:00
notification_subscriptions Add Article post_commit when user_id changes with specs (#15132) 2021-10-25 10:53:21 +07:00
notifications Fix integer > nil error when sending reaction notifications (#16627) 2022-02-17 16:30:39 -06:00
organizations Organizations delete optimizations and refactoring (#13610) 2021-05-11 12:14:55 +03:00
payments app/services i18n (#16189) 2022-01-20 09:25:25 -05:00
podcasts Add Errno::EHOSTUNREACH to Podcasts's rescue list (#16884) 2022-03-15 14:05:04 -04:00
profile_fields Refactor profile refreshing (#14643) 2021-09-13 12:15:04 -04:00
push_notifications Have specs run without Redis and refactor ConsumerApp and Device (#13647) 2021-05-07 08:03:16 +02:00
re_captcha Spelling fixes to live code (#15670) 2021-12-06 12:11:25 +02:00
search Remove unused methods from User (#16616) 2022-02-18 09:02:17 +07:00
settings Addressing rubocop violations (#16156) 2022-01-17 17:21:06 -05:00
slack Ensure arguments to perform_async are json safe (#16285) 2022-01-25 18:07:40 -06:00
spam app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
tag_moderators Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
twitter_client Match error class using case instead of if/elsif/else (#16952) 2022-03-21 15:34:49 -05:00
user_subscriptions app/services i18n (#16189) 2022-01-20 09:25:25 -05:00
users Don't suggest author follows for anonymous visitors (#16825) 2022-03-08 11:15:06 -06:00
analytics_service.rb app/services i18n (#16189) 2022-01-20 09:25:25 -05:00
application_service.rb [deploy] Refactor 🚀 : Replaced Chat Channel Setting page with Preact component. (#8271) 2020-06-10 16:58:37 -04:00
article_api_index_service.rb Factoring code to define Article.approved (#15600) 2021-12-01 22:45:32 -05:00
article_with_video_creation_service.rb app/services i18n (#16189) 2022-01-20 09:25:25 -05:00
bulk_sql_delete.rb Remove txn from with_statement_timeout block (#15088) 2021-10-15 14:53:35 -04:00
email_digest.rb Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121) 2021-07-08 09:31:34 -05:00
email_digest_article_collector.rb Extracting a not_authored_by scope (#16123) 2022-01-17 15:20:49 -05:00
feature_flag.rb Add FeatureFlag.all (#16496) 2022-02-11 13:38:17 +07:00
flare_tag.rb [Search 2.0] Homepage query (#13339) 2021-04-21 12:41:24 +02:00
instrumentation.rb Instrument EmailDigestArticleCollector (#13153) 2021-03-29 09:33:32 -04:00
markdown_processor.rb Extracting container for allowed tags & attrs (#15338) 2021-12-16 12:24:45 -05:00
medium_article_retrieval_service.rb app/services i18n (#16189) 2022-01-20 09:25:25 -05:00
notifications.rb Remove notifiable access from articles and comments notifications (#5415) [deploy] 2020-01-09 10:19:45 -05:00
rate_limit_checker.rb app/services i18n (#16189) 2022-01-20 09:25:25 -05:00
tag_adjustment_creation_service.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
tag_adjustment_update_service.rb [WIP] Allow mods to remove tags and send user notification (#1252) 2018-12-04 16:45:32 -05:00