6929cd908c
In Travis I found the following message:
> Using `should` from rspec-expectations' old `:should` syntax without
> explicitly enabling the syntax is deprecated. Use the new `:expect`
> syntax or explicitly enable `:should` with
> `config.expect_with(:rspec) > { |c| c.syntax = :should }`
> instead. Called from
> /home/travis/build/forem/forem/spec/models/html_variant_spec.rb:76:in
> `block (2 levels) in <main>'.
78 lines
2.8 KiB
Ruby
78 lines
2.8 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe HtmlVariant, type: :model do
|
|
let(:html_variant) { create(:html_variant, approved: true, published: true) }
|
|
|
|
describe "validations" do
|
|
describe "builtin validations" do
|
|
subject { html_variant }
|
|
|
|
it { is_expected.to belong_to(:user).optional }
|
|
|
|
it { is_expected.to have_many(:html_variant_trials).dependent(:destroy) }
|
|
it { is_expected.to have_many(:html_variant_successes).dependent(:destroy) }
|
|
|
|
it { is_expected.to validate_inclusion_of(:group).in_array(described_class::GROUP_NAMES) }
|
|
it { is_expected.to validate_presence_of(:html) }
|
|
it { is_expected.to validate_presence_of(:success_rate) }
|
|
it { is_expected.to validate_uniqueness_of(:name) }
|
|
end
|
|
end
|
|
|
|
it "calculates success rate" do
|
|
4.times { HtmlVariantTrial.create!(html_variant_id: html_variant.id) }
|
|
HtmlVariantSuccess.create!(html_variant_id: html_variant.id)
|
|
|
|
html_variant.calculate_success_rate!
|
|
expect(html_variant.success_rate).to eq(0.025)
|
|
end
|
|
|
|
it "finds for test without tag" do
|
|
html_variant.save!
|
|
expect(described_class.find_for_test.id).to eq(html_variant.id)
|
|
end
|
|
|
|
it "finds for test with tag given" do
|
|
html_variant.target_tag = "hello"
|
|
html_variant.save!
|
|
expect(described_class.find_for_test(["hello"]).id).to eq(html_variant.id)
|
|
end
|
|
|
|
it "does not find if different tag targeted" do
|
|
html_variant.target_tag = "different_tag_yolo"
|
|
html_variant.save!
|
|
expect(described_class.find_for_test(["hello"])).to eq(nil)
|
|
end
|
|
|
|
it "finds if no tag targeted and tag given" do
|
|
html_variant.update(target_tag: nil)
|
|
expect(described_class.find_for_test(["hello"]).id).to eq(html_variant.id)
|
|
end
|
|
|
|
it "prefixes an image with cloudinary", cloudinary: true do
|
|
html = "<div><img src='https://devimages.com/image.jpg' /></div>"
|
|
html_variant.update(approved: false, html: html)
|
|
cloudinary_string = "/c_limit%2Cf_auto%2Cfl_progressive%2Cq_auto%2Cw_420/https://devimages.com/image.jpg"
|
|
expect(html_variant.html).to include(cloudinary_string)
|
|
end
|
|
|
|
it "does not add prefix if it already starts with cloudinary" do
|
|
allow(Images::Optimizer).to receive(:call)
|
|
html = %(<img src="https://res.cloudinary.com/image.jpg">)
|
|
html_variant.update(approved: false, html: html)
|
|
expect(Images::Optimizer).not_to have_received(:call)
|
|
end
|
|
|
|
it "does not add prefix if already on site root" do
|
|
allow(Images::Optimizer).to receive(:call)
|
|
html = "<img src=\"#{Images::Optimizer.get_imgproxy_endpoint}/image.jpg\">"
|
|
html_variant.update(approved: false, html: html)
|
|
html_variant.save
|
|
expect(Images::Optimizer).not_to have_received(:call)
|
|
end
|
|
|
|
it "strips whitespace from the name" do
|
|
variant = create(:html_variant, name: " hello world ")
|
|
expect(variant.reload.name).to eq "hello world"
|
|
end
|
|
end
|