docbrown/spec/requests/page_views_spec.rb
Ben Halpern 31b83a4511
Remove concept of "ongoing" field tests and clarify a/b test instructions/expectations. (#11734)
* Remove concept of 'ongoing' field tests

* Fix specs

* Feeds spec

* Fix spec

* Fix style issues

* More details on field tests
2020-12-07 13:52:54 -05:00

140 lines
4.4 KiB
Ruby

require "rails_helper"
RSpec.describe "PageViews", type: :request do
let(:user) { create(:user, :trusted) }
let(:article) { create(:article) }
before do
# rubocop:disable RSpec/AnyInstance
allow_any_instance_of(PageViewsController).to receive(:skip_page_view_update?).and_return(false)
allow_any_instance_of(PageViewsController).to receive(:skip_organic_page_view_update?).and_return(false)
# rubocop:enable RSpec/AnyInstance
end
describe "POST /page_views" do
context "when user signed in" do
before do
sign_in user
end
it "creates a new page view" do
post "/page_views", params: {
article_id: article.id
}
expect(article.reload.page_views.size).to eq(1)
expect(article.reload.page_views_count).to eq(1)
expect(user.reload.page_views.size).to eq(1)
expect(PageView.last.counts_for_number_of_views).to eq(1)
end
it "sends referrer" do
post "/page_views", params: {
article_id: article.id,
referrer: "test"
}
expect(PageView.last.referrer).to eq("test")
end
it "sends user agent" do
post "/page_views", params: {
article_id: article.id,
user_agent: "test"
}
expect(PageView.last.user_agent).to eq("test")
end
end
context "when part of field test" do
before do
sign_in user
allow(Users::RecordFieldTestEventWorker).to receive(:perform_async)
end
it "converts field test" do
post "/page_views", params: {
article_id: article.id,
referrer: "test"
}
expect(Users::RecordFieldTestEventWorker).to have_received(:perform_async)
.with(user.id, :follow_implicit_points, "user_views_article_four_days_in_week")
end
end
context "when user not signed in" do
it "creates a new page view" do
post "/page_views", params: {
article_id: article.id
}
expect(article.reload.page_views.size).to eq(1)
expect(article.reload.page_views_count).to eq(10)
expect(user.reload.page_views.size).to eq(0)
expect(PageView.last.counts_for_number_of_views).to eq(10)
end
it "stores aggregate page views" do
post "/page_views", params: { article_id: article.id }
post "/page_views", params: { article_id: article.id }
expect(article.reload.page_views_count).to eq(20)
end
it "stores aggregate organic page views" do
post "/page_views", params: { article_id: article.id, referrer: "https://www.google.com/" }
post "/page_views", params: { article_id: article.id }
expect(article.reload.organic_page_views_count).to eq(10)
expect(article.reload.organic_page_views_past_week_count).to eq(10)
expect(article.reload.organic_page_views_past_month_count).to eq(10)
post "/page_views", params: { article_id: article.id, referrer: "https://www.google.com/" }
expect(article.reload.organic_page_views_count).to eq(20)
post "/page_views", params: { article_id: article.id }
expect(article.reload.organic_page_views_count).to eq(20)
end
it "sends referrer" do
post "/page_views", params: {
article_id: article.id,
referrer: "test"
}
expect(PageView.last.referrer).to eq("test")
end
it "sends user agent" do
post "/page_views", params: {
article_id: article.id,
user_agent: "test"
}
expect(PageView.last.user_agent).to eq("test")
end
end
end
describe "PUT /page_views/:id" do
context "when user is signed in" do
before do
sign_in user
end
it "updates a new page view time on page by 15" do
post "/page_views", params: { article_id: article.id }
put "/page_views/#{article.id}"
expect(PageView.last.time_tracked_in_seconds).to eq(30)
end
it "does not update an invalid page view" do
invalid_id = article.id + 100
expect { put "/page_views/#{invalid_id}" }.not_to raise_error
end
end
context "when user is not signed in" do
it "updates a new page view time on page by 15" do
post "/page_views", params: {
article_id: article.id
}
put "/page_views/#{article.id}"
expect(PageView.last.time_tracked_in_seconds).to eq(15)
end
end
end
end