maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/app
History
Jeremy Friesen 2fd94fcc87
Ensuring that body.dataset is JSON parsable (#16441) 
Prior to this commit, if our community name included a `"` we would
encounter a parse error.  Using the [j][1] which is a terse alias for
[escape_javascript][2], we will now be escaping those characters that
cause grief in some of our parsings.

I believe there is a larger audit that needs to occur regarding all
`data-` renderings.

Hopefully this will catch a flakey test.

Closes #16440

[1]:https://api.rubyonrails.org/classes/ActionView/Helpers/JavaScriptHelper.html#method-i-j
[2]:https://api.rubyonrails.org/classes/ActionView/Helpers/JavaScriptHelper.html#method-i-escape_javascript
2022-02-08 07:30:43 -05:00
..
assets Add accessible color picker component (#16385) 2022-02-07 14:30:02 +00:00
components/admin/users Change UI instances of "vomit" to "flag" (#16397) 2022-02-03 12:22:32 +00:00
controllers A suspended user returns 403 instead of 500 (#16408) 2022-02-04 09:42:23 -05:00
decorators app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
errors A suspended user returns 403 instead of 500 (#16408) 2022-02-04 09:42:23 -05:00
forms
helpers Adding conditional rendering of navigation links (#16362) 2022-02-01 12:23:58 -05:00
javascript Add accessible color picker component (#16385) 2022-02-07 14:30:02 +00:00
lib Easier feature flag handling for Cypress (#16379) 2022-02-03 10:42:13 -05:00
liquid_tags Implement Unified Embeds for Github Repo, Issue, Pull-Request and Comment URLs (#16422) 2022-02-07 16:38:43 -05:00
mailers app/mailers i18n (#16191) 2022-01-20 07:33:29 -07:00
models Removing deprecated User methods (#16435) 2022-02-07 10:32:58 -05:00
policies Removing deprecated User methods (#16435) 2022-02-07 10:32:58 -05:00
queries
refinements
sanitizers
serializers Added "Tags" category to search results (#16265) 2022-01-26 20:51:15 +03:00
services Allow nil pubDate in Podcast sorting (#16349) 2022-02-07 11:18:51 -05:00
uploaders
validators Remove the "Getting Started" Section from the Config (#16033) 2022-01-20 07:31:35 -07:00
view_objects Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
views Ensuring that body.dataset is JSON parsable (#16441) 2022-02-08 07:30:43 -05:00
workers Use perform_bulk in Podcasts::EnqueueGetEpisodesWorker (#16325) 2022-01-28 11:32:25 +07:00