* Require profile fields to belong to a group Remove the empty group dropdown from the group select tag Remove the optional: true from the belongs_to validation (raise a validation error on save if the group is not provided) Update test to remove belongs_to's optional setting * Update ProfileFields::Add spec to include profile field group * update factory to ensure a non-empty profile field group * Add required profile field group to seeded profile fields Since profile field is required, create was failing (silently). Add required field so these are available in e2e tests. * Use factory `association` to create a profile field group https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#explicit-definition * provide required profile field group when posting data * Fix one spec, drop another Both of these scripts will be removed in the other branch (changing the attribute name) - dropping the test here seems lower trouble than modifying an out of data data update script to pass. * skip test slated for removal Similar to the last commit - this test exercises a script about to be archived in the other branch. |
||
|---|---|---|
| .. | ||
| acts_as_taggable_on | ||
| data_update_scripts | ||
| honeycomb | ||
| liquid | ||
| reverse_markdown/converters | ||
| sidekiq | ||
| app_secrets_spec.rb | ||
| black_box_spec.rb | ||
| html_css_to_image_spec.rb | ||
| rails_env_constraint_spec.rb | ||
| release_phase_notifier_spec.rb | ||
| string_attribute_cleaner_spec.rb | ||
| throttled_call_spec.rb | ||
| url_spec.rb | ||