docbrown/spec/requests/admin/reactions_spec.rb
Daniel Uber 76470febb7
Expect to raise error should use a block (#17131)
* Expect to raise error should use a block

This is kind of pedantic, since we _had_ been using a lambda, and
calling as a value. Now explicitly call the proc in a block and expect
the block to raise error.

* Replace lambda with block

Replace lambda passed as a value to an implicit block with a block.
2022-04-05 13:21:23 -06:00

68 lines
2.4 KiB
Ruby

require "rails_helper"
RSpec.describe "/admin/reactions", type: :request do
let(:user) { create(:user) }
let(:article) { create(:article, user_id: user.id) }
let(:admin) { create(:user, :super_admin) }
describe "PUT /admin/reactions as admin" do
before do
user.add_role(:trusted)
sign_in admin
end
let(:reaction) { create(:reaction, category: "vomit", user_id: user.id, reactable: article) }
it "updates reaction to be confirmed" do
put admin_reaction_path(reaction.id), params: { id: reaction.id, status: "confirmed" }
expect(reaction.reload.status).to eq("confirmed")
end
it "updates reaction to be invalid" do
put admin_reaction_path(reaction.id), params: { id: reaction.id, status: "invalid" }
expect(reaction.reload.status).to eq("invalid")
end
it "does not set a non-valid status" do
put admin_reaction_path(reaction.id), params: { id: reaction.id, status: "confirmedsssss" }
expect(reaction.reload.status).not_to eq("confirmedsssss")
end
it "returns HTTP Status 200 upon status update" do
put admin_reaction_path(reaction.id), params: { id: reaction.id, status: "confirmed" }
expect(response).to have_http_status(:ok)
end
it "returns HTTP Status 422 upon status update failure" do
put admin_reaction_path(reaction.id), params: { id: reaction.id, status: "confirmedsssss" }
expect(response).to have_http_status(:unprocessable_entity)
end
it "returns expected JSON upon status update" do
put admin_reaction_path(reaction.id), params: { id: reaction.id, status: "confirmed" }
expect(JSON.parse(response.body)).to eq("outcome" => "Success")
end
it "returns error upon status update failure" do
put admin_reaction_path(reaction.id), params: { id: reaction.id, status: "confirmedsssss" }
expect(JSON.parse(response.body)).to include("error")
end
end
describe "PUT /admin/reactions as non-admin" do
before do
user.add_role(:trusted)
sign_in user
end
let(:reaction) { create(:reaction, category: "vomit", user_id: user.id, reactable: article) }
it "updates reaction to be confirmed" do
invalid_request = lambda do
put admin_reaction_path(reaction.id), params: { id: reaction.id, status: "confirmed" }
end
expect { invalid_request.call }.to raise_error(Pundit::NotAuthorizedError)
end
end
end