* Bump rubocop from 1.18.4 to 1.19.0 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.18.4 to 1.19.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.18.4...v1.19.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Rubocop autofixes * Manually fix some Rubocop warnings/errors * How about another coffee, Michael? * Maybe Rubocop needs a coffee too Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Kohl <citizen428@forem.com>
104 lines
3.2 KiB
Ruby
104 lines
3.2 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe Profile, type: :model do
|
|
let(:user) { create(:user) }
|
|
let(:profile) { user.profile }
|
|
|
|
describe "validations" do
|
|
subject { profile }
|
|
|
|
it { is_expected.to validate_uniqueness_of(:user_id) }
|
|
|
|
describe "conditionally validating summary" do
|
|
let(:invalid_summary) { "x" * ProfileValidator::MAX_SUMMARY_LENGTH.next }
|
|
|
|
it "is valid if users previously had long summaries and are grandfathered" do
|
|
profile.summary = invalid_summary
|
|
profile.save(validate: false)
|
|
profile.summary = "x" * 999
|
|
expect(profile).to be_valid
|
|
end
|
|
|
|
it "is not valid if the summary is too long and the user is not grandfathered" do
|
|
profile.summary = invalid_summary
|
|
expect(profile).not_to be_valid
|
|
expect(profile.errors_as_sentence).to eq "Summary is too long"
|
|
end
|
|
|
|
it "is valid if the summary is less than the limit" do
|
|
profile.summary = "Hello 👋"
|
|
expect(profile).to be_valid
|
|
end
|
|
end
|
|
|
|
describe "validating text areas" do
|
|
it "is valid if the text is short enough" do
|
|
profile.skills_languages = "Ruby"
|
|
expect(profile).to be_valid
|
|
end
|
|
|
|
it "is invalid if the text is too long" do
|
|
profile.skills_languages = "x" * ProfileValidator::MAX_TEXT_AREA_LENGTH.next
|
|
expect(profile).not_to be_valid
|
|
expect(profile.errors_as_sentence)
|
|
.to eq "Skills languages is too long (maximum is 200 characters)"
|
|
end
|
|
end
|
|
|
|
describe "validating text fields" do
|
|
it "is valid if the text is short enough" do
|
|
profile.location = "Somewhere"
|
|
expect(profile).to be_valid
|
|
end
|
|
|
|
it "is invalid if the text is too long" do
|
|
profile.location = "x" * ProfileValidator::MAX_TEXT_FIELD_LENGTH.next
|
|
expect(profile).not_to be_valid
|
|
expect(profile.errors_as_sentence).to eq "Location is too long (maximum is 100 characters)"
|
|
end
|
|
end
|
|
|
|
describe "validating website_url" do
|
|
it "is valid if blank" do
|
|
profile.website_url = nil
|
|
expect(profile).to be_valid
|
|
end
|
|
|
|
it "is valid with a complete url" do
|
|
profile.website_url = "https://dev.to"
|
|
expect(profile).to be_valid
|
|
end
|
|
|
|
it "is invalid with an incomplete url" do
|
|
profile.website_url = "dev.to"
|
|
expect(profile).not_to be_valid
|
|
expect(profile.errors_as_sentence).to eq "Website url is not a valid URL"
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when accessing profile fields" do
|
|
before do
|
|
create(:profile_field, label: "Test 1")
|
|
create(:profile_field, label: "Test 2", input_type: :check_box)
|
|
described_class.refresh_attributes!
|
|
end
|
|
|
|
let(:profile) { described_class.new }
|
|
|
|
it "defines accessors for active profile fields", :aggregate_failures do
|
|
expect(profile).to respond_to(:test1)
|
|
expect(profile).to respond_to(:test2)
|
|
end
|
|
|
|
it "performs ActiveRecord typecasting for profile fields", :aggregate_failures do
|
|
expect do
|
|
profile.test2 = "true"
|
|
end.to change(profile, :test2).from(nil).to(true)
|
|
|
|
expect do
|
|
profile.test2 = "f"
|
|
end.to change(profile, :test2).to(false)
|
|
end
|
|
end
|
|
end
|