docbrown/app
Lawrence 0c93bde6c2
Subscribe to Comment Functionality (#19555)
* Move save over and add button labels

* comment notification design and functionality

* controller error handling

* add ternery operator for background class

* minor cleanup

* add proper styling toggles

* tests and mobile spec

* add for all buttons

* add article as a param

* comment is not required on article preview

* update policy spec

* add test for coverage

* add proper button titles

* use the last user comment as comment id

* add better error handling and remove multiple fetch calls in js

* copy change to threads

* update copy, fix multiple fetch calls, add observer for loading more notifications

* update spec

* add rspecs

* more test specs

* fix test specs

* subscribe button text tests

* add export

* optimistically update ui function tests

* button initialize test

* check for comment ancestry

* add feature flag block

* some cleanup

* update logic and specs

* oops

* rubocop issues

* change config names

* change config names

* fix spec

* add one more conditional

* check for comments

* service-object the toggler

* separate routes

* continual refactoring

* refine spec tests

* clean up policy

* Adjust js and view files to match be params

* some service object refactoring

* separate endpoints on client-side

* broken spec

* service specs

* policy spec fixes

* remove action param

* remove action param from spec

* minor updates

* trigger build

* update to post

* Services don't need permitted params

* Notifications continue to be a mess, decorator specs to follow

* Not toggling now

* This doesn't really belong here

* Fix tests after moving

* Streamline front-end

* There could be errors?

* polymorphic_name is a class thing

* ☠️ json_data in notification views

* Use feature_flag helper to get current_user

* Cannot derive current subscription status from notification, only from subscription

* Default is subscribe to all article comments

* Sync up matching unsubscribe, make subscribe idempotent-ish

* Temporarily comment-out button jest tests to see if I can unstick CI

* Stop trying to detect potential subscribe-to-comment

* Stop trying to detect potential subscribe-to-comment

* Minor spec refactoring

* Add specs for article notification decoration

* NotificationDecorator specs are rather long

* Rubocop likes it?

* Minor spec refactoring

* Doesn't need to stay pending

* Add spec for subscription finder

* Expand Subscribe service specs

* YAGNI, but I don't like hard-coded config

* Refactor Unsubscribe service specs

* nobody expects the infinite scroll

* This *might* work, except for feature flag

* Ancestry can be quite deep actually

* Rubocop

* Update subscribe button for subscribe-to-thread

* Jest tests are just tests

* hasAttribute != getAttribute

* Test knows **nothing** about window size

* Tests have been lying about mobileLabel this whole time

* Make payload/endpoint testable

* Is Jest actually happy???

* Still cleaning up jest/eslint

* Temporarily comment-out cypress tests pending feature flag

* Thanks, Rubocop, what would we do without you

* Preserve round-trip for 'top-level' and 'only-author' subscriptions

* Update specs

* Move save button icon

* Update test with better config param

* Try feature flag specific to cypress env

* Tell cypress to wait for (un)subscribing to work

---------

Co-authored-by: Lawrence S <lawrence@forem.com>
Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-07-10 17:11:46 +02:00
..
assets Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
controllers Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
decorators Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
errors Favoring re-use of authorization error (#16992) 2022-03-24 08:16:28 -04:00
forms Refactor CreatorSettingsForm & spec (#19011) 2023-01-27 08:39:07 -05:00
helpers Refactor the home feed + add user tag filtering on in-feed billboards (#19600) 2023-07-06 16:47:08 +02:00
javascript Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
lib Remove manual user follow suggestions (#19457) 2023-05-16 15:01:03 +02:00
liquid_tags Fix Windows tweet schrinking phenomenon (#19686) 2023-07-06 17:25:04 -04:00
mailers "Reply to" and "From" Email addresses for SMTP Configurations (#16499) 2022-02-16 16:14:54 +02:00
models Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
policies Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
queries Refactor the home feed + add user tag filtering on in-feed billboards (#19600) 2023-07-06 16:47:08 +02:00
refinements
sanitizers Don't sanitize anchor elements with no href (#16667) 2022-02-22 11:27:38 -06:00
serializers Remove deprecated Organization's columns (#19396) 2023-06-26 10:36:33 -04:00
services Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
uploaders small non-views ruby i18n (#16004) 2022-01-11 10:05:18 +07:00
validators Skips newline when validating character count (#19646) 2023-07-07 14:35:29 -04:00
view_objects Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
views Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
workers notify mod on new user articles (#19478) 2023-05-23 10:51:46 -04:00