docbrown/spec/requests/user_subscriptions_spec.rb
Alex 8714a36d27
[deploy] User subscriptions API and backend updates (#8779)
* Create "blank" EmailSubscriptionTag

* Refactor liquid_tags_used with spec

* Create /user_subscriptions#create

- Update liquid tag name to UserSubscriptionTag

* Add rate limiting and specs

* Add counter_culture for user_subscriptions

* Update /async_info/base_data

- Alphabetize user_data
- Add email
- Add subscription_source_article_ids
- Cache subscription_source_article_ids on User model

* Add stale email check and specs

* Change user_email to subscriber_email for clarity

* Restrict UserSubscriptionTag

* Rename RESTRICTED_TAGS to RESTRICTED_LIQUID_TAGS

* Make TODO comment more clear

* Refactor error responses and update specs

* Update type to source_type in error message

* Use constantize over safe_constantize

* Add check for active source

* Refactor checking of current_user's subscriptions

- Remove data from async_info
- Create a new service to fetch/cache a user's existing subscriptions

* Restrict email in base_data to admin roles

* Oops! Rename liquid tag file

* Change error back to result...oops!

* It's not goodbye, it's see you later. RIP email :/

* Add current_email to /user_subscriptions/base_data

* Revert adding current_email

* Undo async_info_controller changes/fix conflict

* Move params to constant

* Refactor SubscriptionCacheChecker

* Remove duplicate status code in JSON response

* Remove duplicate status code for #subscribed

* Use response.parsed_body

* Remove user guard in SubscriptionCacheChecker
2020-06-23 13:43:32 -04:00

174 lines
8.2 KiB
Ruby

require "rails_helper"
RSpec.describe "UserSubscriptions", type: :request do
# TODO: (Alex Smith) remove super_admin restriction before final release
let(:super_admin_user) { create(:user, :super_admin) }
let(:user) { create(:user) }
before { sign_in user }
describe "GET /user_subscriptions/subscribed - UserSubscriptions#subscribed" do
it "raises an error for missing params" do
expect { get subscribed_user_subscriptions_path, params: {} }.to raise_error(ActionController::ParameterMissing)
end
it "returns true if a user is already subscribed" do
article = create(:article)
create(:user_subscription,
subscriber_id: user.id,
subscriber_email: user.email,
author_id: article.user_id,
user_subscription_sourceable: article)
valid_params = { source_type: article.class_name, source_id: article.id }
get subscribed_user_subscriptions_path, params: valid_params
expect(response).to have_http_status(:ok)
expect(response.parsed_body["is_subscribed"]).to eq true
end
it "returns false if a user is not already subscribed" do
valid_params = { source_type: "Article", source_id: 999 }
get subscribed_user_subscriptions_path, params: valid_params
expect(response).to have_http_status(:ok)
expect(response.parsed_body["is_subscribed"]).to eq false
end
end
describe "POST /user_subscriptions - UserSubscriptions#create" do
it "creates a UserSubscription" do
article = create(:article, user: super_admin_user, body_markdown: "---\ntitle: User Subscription#{rand(1000)}\npublished: true\n---\n\n{% user_subscription 'CTA text' %}")
valid_attributes = { source_type: article.class_name, source_id: article.id, subscriber_email: user.email }
expect do
post user_subscriptions_path,
headers: { "Content-Type" => "application/json" },
params: { user_subscription: valid_attributes }.to_json
end.to change(UserSubscription, :count).by(1)
user_subscription = UserSubscription.last
expect(user_subscription.subscriber_id).to eq user.id
expect(user_subscription.author_id).to eq article.user_id
expect(user_subscription.user_subscription_sourceable_type).to eq article.class_name
expect(user_subscription.user_subscription_sourceable_id).to eq article.id
end
it "returns an error for an invalid source_type" do
invalid_source_type_attributes = { source_type: "NonExistentSourceType", source_id: "1", subscriber_email: user.email }
expect do
post user_subscriptions_path,
headers: { "Content-Type" => "application/json" },
params: { user_subscription: invalid_source_type_attributes }.to_json
end.to change(UserSubscription, :count).by(0)
expect(response).to have_http_status(:unprocessable_entity)
expect(response.parsed_body["error"]).to eq("invalid source_type")
end
it "returns an error for a source that can't be found" do
invalid_source_attributes = { source_type: "Article", source_id: "99999999" }
expect do
post user_subscriptions_path,
headers: { "Content-Type" => "application/json" },
params: { user_subscription: invalid_source_attributes }.to_json
end.to change(UserSubscription, :count).by(0)
expect(response).to have_http_status(:unprocessable_entity)
expect(response.parsed_body["error"]).to eq("source not found")
end
it "returns an error for an inactive source" do
unpublished_article = create(:article, user: super_admin_user, body_markdown: "---\ntitle: User Subscription#{rand(1000)}\npublished: false\n---\n\n{% user_subscription 'CTA text' %}")
invalid_source_attributes = { source_type: unpublished_article.class_name, source_id: unpublished_article.id, subscriber_email: user.email }
expect do
post user_subscriptions_path,
headers: { "Content-Type" => "application/json" },
params: { user_subscription: invalid_source_attributes }.to_json
end.to change(UserSubscription, :count).by(0)
expect(response).to have_http_status(:unprocessable_entity)
expect(response.parsed_body["error"]).to eq("source not found")
end
it "returns an error for a source that doesn't have the UserSubscription liquid tag enabled" do
article = create(:article)
invalid_source_attributes = { source_type: article.class_name, source_id: article.id, subscriber_email: user.email }
expect do
post user_subscriptions_path,
headers: { "Content-Type" => "application/json" },
params: { user_subscription: invalid_source_attributes }.to_json
end.to change(UserSubscription, :count).by(0)
expect(response).to have_http_status(:unprocessable_entity)
expect(response.parsed_body["error"]).to eq("user subscriptions are not enabled for the requested source")
end
it "returns an error for an invalid UserSubscription" do
article = create(:article, user: super_admin_user, body_markdown: "---\ntitle: User Subscription#{rand(1000)}\npublished: true\n---\n\n{% user_subscription 'CTA text' %}")
# Create the UserSubscription directly so it results in a
# duplicate/invalid record and returns an error. This mimics a user
# trying to subscribe to the same user via the same source, twice.
create(:user_subscription,
subscriber_id: user.id,
subscriber_email: user.email,
author_id: article.user.id,
user_subscription_sourceable: article)
invalid_source_attributes = { source_type: article.class_name, source_id: article.id, subscriber_email: user.email }
expect do
post user_subscriptions_path,
headers: { "Content-Type" => "application/json" },
params: { user_subscription: invalid_source_attributes }.to_json
end.to change(UserSubscription, :count).by(0)
expect(response).to have_http_status(:unprocessable_entity)
expect(response.parsed_body["error"]).to eq("Subscriber has already been taken")
end
it "returns an error for an email mismatch" do
article = create(:article, user: super_admin_user, body_markdown: "---\ntitle: User Subscription#{rand(1000)}\npublished: true\n---\n\n{% user_subscription 'CTA text' %}")
invalid_source_attributes = { source_type: article.class_name, source_id: article.id, subscriber_email: "old_email@test.com" }
expect do
post user_subscriptions_path,
headers: { "Content-Type" => "application/json" },
params: { user_subscription: invalid_source_attributes }.to_json
end.to change(UserSubscription, :count).by(0)
expect(response).to have_http_status(:unprocessable_entity)
expect(response.parsed_body["error"]).to eq("subscriber email mismatch")
end
end
context "when rate limiting" do
let(:rate_limiter) { RateLimitChecker.new(user) }
let(:article) { create(:article, user: super_admin_user, body_markdown: "---\ntitle: User Subscription#{rand(1000)}\npublished: true\n---\n\n{% user_subscription 'CTA text' %}") }
let(:valid_attributes) { { source_type: article.class_name, source_id: article.id, subscriber_email: user.email } }
before { allow(RateLimitChecker).to receive(:new).and_return(rate_limiter) }
it "increments rate limit for user_subscription_creation" do
allow(rate_limiter).to receive(:track_limit_by_action)
post user_subscriptions_path,
headers: { "Content-Type" => "application/json" },
params: { user_subscription: valid_attributes }.to_json
expect(rate_limiter).to have_received(:track_limit_by_action).with(:user_subscription_creation)
end
it "returns a 429 status when rate limit is reached" do
allow(rate_limiter).to receive(:limit_by_action).and_return(true)
post user_subscriptions_path,
headers: { "Content-Type" => "application/json" },
params: { user_subscription: valid_attributes }.to_json
expect(response).to have_http_status(:too_many_requests)
expected_retry_after = RateLimitChecker::ACTION_LIMITERS.dig(:user_subscription_creation, :retry_after)
expect(response.headers["Retry-After"]).to eq(expected_retry_after)
end
end
end