* Create "blank" EmailSubscriptionTag * Refactor liquid_tags_used with spec * Create /user_subscriptions#create - Update liquid tag name to UserSubscriptionTag * Add rate limiting and specs * Add counter_culture for user_subscriptions * Update /async_info/base_data - Alphabetize user_data - Add email - Add subscription_source_article_ids - Cache subscription_source_article_ids on User model * Add stale email check and specs * Change user_email to subscriber_email for clarity * Restrict UserSubscriptionTag * Rename RESTRICTED_TAGS to RESTRICTED_LIQUID_TAGS * Make TODO comment more clear * Refactor error responses and update specs * Update type to source_type in error message * Use constantize over safe_constantize * Add check for active source * Refactor checking of current_user's subscriptions - Remove data from async_info - Create a new service to fetch/cache a user's existing subscriptions * Restrict email in base_data to admin roles * Oops! Rename liquid tag file * Change error back to result...oops! * It's not goodbye, it's see you later. RIP email :/ * Add current_email to /user_subscriptions/base_data * Revert adding current_email * Undo async_info_controller changes/fix conflict * Move params to constant * Refactor SubscriptionCacheChecker * Remove duplicate status code in JSON response * Remove duplicate status code for #subscribed * Use response.parsed_body * Remove user guard in SubscriptionCacheChecker
107 lines
3.1 KiB
Ruby
107 lines
3.1 KiB
Ruby
class RateLimitChecker
|
|
attr_reader :user, :action
|
|
|
|
# retry_after values are the seconds until a user can retry an action
|
|
ACTION_LIMITERS = {
|
|
article_update: { retry_after: 30 },
|
|
feedback_message_creation: { retry_after: 300 },
|
|
image_upload: { retry_after: 30 },
|
|
listing_creation: { retry_after: 60 },
|
|
organization_creation: { retry_after: 300 },
|
|
published_article_creation: { retry_after: 30 },
|
|
reaction_creation: { retry_after: 30 },
|
|
send_email_confirmation: { retry_after: 120 },
|
|
user_subscription_creation: { retry_after: 30 },
|
|
user_update: { retry_after: 30 }
|
|
}.with_indifferent_access.freeze
|
|
|
|
def initialize(user = nil)
|
|
@user = user
|
|
end
|
|
|
|
class LimitReached < StandardError
|
|
attr_reader :retry_after
|
|
|
|
def initialize(retry_after)
|
|
@retry_after = retry_after
|
|
end
|
|
|
|
def message
|
|
"Rate limit reached, try again in #{retry_after} seconds"
|
|
end
|
|
end
|
|
|
|
def check_limit!(action)
|
|
return unless limit_by_action(action)
|
|
|
|
retry_after = ACTION_LIMITERS.dig(action, :retry_after)
|
|
raise LimitReached, retry_after
|
|
end
|
|
|
|
def limit_by_action(action)
|
|
check_method = "check_#{action}_limit"
|
|
result = respond_to?(check_method, true) ? send(check_method) : false
|
|
|
|
if result
|
|
@action = action
|
|
log_to_datadog
|
|
end
|
|
result
|
|
end
|
|
|
|
def track_limit_by_action(action)
|
|
expires_in = ACTION_LIMITERS.dig(action, :retry_after).seconds
|
|
Rails.cache.increment(limit_cache_key(action), 1, expires_in: expires_in, raw: true)
|
|
end
|
|
|
|
def limit_by_email_recipient_address(address)
|
|
# This is related to the recipient, not the "user" initiator, like in action.
|
|
EmailMessage.where(to: address).where("sent_at > ?", 2.minutes.ago).size >
|
|
SiteConfig.rate_limit_email_recipient
|
|
end
|
|
|
|
private
|
|
|
|
ACTION_LIMITERS.each_key do |action|
|
|
define_method("check_#{action}_limit") do
|
|
Rails.cache.read(limit_cache_key(action), raw: true).to_i > action_rate_limit(action)
|
|
end
|
|
end
|
|
|
|
def limit_cache_key(action)
|
|
unique_key_component = @user&.id || @user&.ip_address
|
|
raise "Invalid Cache Key: no unique component present" if unique_key_component.blank?
|
|
|
|
"#{unique_key_component}_#{action}"
|
|
end
|
|
|
|
def action_rate_limit(action)
|
|
SiteConfig.public_send("rate_limit_#{action}")
|
|
end
|
|
|
|
def check_comment_creation_limit
|
|
user.comments.where("created_at > ?", 30.seconds.ago).size >
|
|
SiteConfig.rate_limit_comment_creation
|
|
end
|
|
|
|
def check_published_article_creation_limit
|
|
user.articles.published.where("created_at > ?", 30.seconds.ago).size >
|
|
SiteConfig.rate_limit_published_article_creation
|
|
end
|
|
|
|
def check_follow_account_limit
|
|
user_today_follow_count > SiteConfig.rate_limit_follow_count_daily
|
|
end
|
|
|
|
def user_today_follow_count
|
|
following_users_count = user.following_users_count
|
|
return following_users_count if following_users_count < SiteConfig.rate_limit_follow_count_daily
|
|
|
|
now = Time.zone.now
|
|
user.follows.where(created_at: (now.beginning_of_day..now)).size
|
|
end
|
|
|
|
def log_to_datadog
|
|
DatadogStatsClient.increment("rate_limit.limit_reached", tags: ["user:#{user.id}", "action:#{action}"])
|
|
end
|
|
end
|