21b81e3605
* Restoring tracking of custom impressions without GA In #15967 I (@jeremyf) introduced the "don't do tracking if Google Analytics ID is blank". However, we still likely want to trackCustomImpressions(). Further, I did some sleuthing and adding a couple of comments on whether we should record page views for articles in draft status or any views by the author. * Ensuring we don't track views of author or unpublished Prior to this commit, I was surprised to learn that we: 1) Tracked an author's view of their article. 2) Tracked views of an unpublished article. This came up from a Forem creator asking if they could reset the view counter. Or trigger the reset on publication. I think a general business logic policy of don't track views for the author and don't track views for unpublished articles is a reasonable default. Were we to pursue the clear views on publication, we'd need to consider something that went from unpublished -> published -> unpublished -> published. Without a more explicit state machine, triggering a busineiss logic behavior seems a bit unexpected. In other words, I wrote an article. There are 20 views when I realize that I need to unpublished it. I make the changes in the unpublished state, and re-publish. I'd assume that those 20 views would still be "recorded" and counted towards my article's view counts. * Revert "Ensuring we don't track views of author or unpublished" This reverts commit 321ecbed0ac4552e175d39bf17655a2fc93b265c. |
||
|---|---|---|
| .. | ||
| initializers | ||
| lib | ||
| utilities | ||
| .eslintrc.js | ||
| base.js.erb | ||
| initializePage.js | ||
| jquery_s3_upload.js | ||