* Create alternate editor * Install linkstate (?) Not sure how it disappear in the first place * Run yarn install * Modulize ArticleForm component * Refactor * Isolating css WIP * Implement simplified frontmatter-less editor * Modulize individual form element * Ajust props names * Transform json params to snakecase * Remove codes * Update /new, almost there for release * Fix editor resize issues * Change defaultvalue to value in article form tag element * Modify html buttons in article form |
||
|---|---|---|
| .vscode | ||
| app | ||
| bin | ||
| config | ||
| db | ||
| lib | ||
| log | ||
| public | ||
| spec | ||
| vendor/assets | ||
| .babelrc | ||
| .eslintrc.js | ||
| .gitignore | ||
| .postcssrc.yml | ||
| .prettierignore | ||
| .rspec | ||
| .rubocop.yml | ||
| .ruby-version | ||
| .simplecov | ||
| .travis.yml | ||
| after_deploy.sh | ||
| config.ru | ||
| empty-module.js | ||
| Envfile | ||
| Gemfile | ||
| Gemfile.lock | ||
| Guardfile | ||
| ISSUE_TEMPLATE.md | ||
| jest.config.js | ||
| LICENSE.md | ||
| package-lock.json | ||
| package.json | ||
| Procfile | ||
| Procfile.dev | ||
| Procfile.dev-hot | ||
| Rakefile | ||
| README.md | ||
| yarn.lock | ||
The DEV Community 👩💻👨💻
The Human Layer of the Stack
Introduction and Contribution Guideline
Welcome to the dev.to codebase. We are so excited to have you. Most importantly, all contributors must abide by the code of conduct.
With your help, we can build out the DEV Community platform to be more stable and better serve the community. We are a Ruby on Rails app. When in doubt, try to do things "The Rails Way", but it is an evolving codebase and we will learn from all new contributions in order to evolve.
How to contribute
When in doubt, ask! This is a new process and we need to learn from pain points.
Refactoring code, e.g. improving the code without modifying the behavior is an area that can probably be done based on intuition and may not require much communication to be merged.
Fixing bugs may also not require a lot of communication, but the more the better. Please surround bug fixes with ample tests. Bugs are magnets for other bugs. Write tests near bugs!
Building features is the area which will require the most communication and/or negotiation. Every feature is subjective and open for debate. Let's talk about the features!
Clean code with tests
Even though some of the existing code is poorly written or untested, we must have more scrutiny for code going forward. We test with rspec, let us know if you have any questions about this!
The bottom line
We are all humans trying to work together to improve things for the community. Always be kind and appreciate the need for tradeoffs. ❤️
Getting Started
Prerequisite
- Ruby: we recommend using rbenv to install the Ruby version listed on the badge.
- Bundler:
gem install bundler - Foreman:
gem install foreman - Yarn: use
brew install yarnto install yarn. It will also install node if you don't already have it. - PostgresSQL: the easiest way to get started with this is to use Postgres.app.
Installation steps
git clone git@github.com:thepracticaldev/dev.to_core.gitbundle installbin/yarn- Set up your environment variables/secrets
- Take a look at
Envfile. This file lists all theENVvariables we use and provides a fake default for any missing keys. You'll need to get your own free API keys for a few services in order to get your development environment running. Follow this wiki to get them. - For any key that you wish to enter/replace:
- Create
config/application.ymlby copying from the provided template (cp config/sample_application.yml config/application.yml). This is a personal file that is ignored in git. - Obtain the development variable and apply the key you wish to enter/replace. ie:
GITHUB_KEY: "afaslkjdflkj2398jflskdjfljk" GITHUB_SECRET: "23r8dcvlk23jekljfslkdfjlks" - Create
- If you are missing
ENVvariables on bootup,enviedgem will alert you with messages similar to'error_on_missing_variables!': The following environment variables should be set: A_MISSING_KEY.. - You do not need "real" keys for basic development. Some features require certain keys, so you may be able to add them as you go.
- Take a look at
- Run
bin/setup
Starting the application
We're mostly a Rails app, with a bit of Webpack sprinkled in. For most cases, simply running bin/rails server will do. If you're working with Webpack though, you'll need to run the following:
- Run
bin/startupto start the server, Webpack, and our job runnerdelayed_job.bin/startuprunsforeman start -f Procfile.devunder the hood. alias start="bin/startup"makes this even faster. 😊- If you're using
pryfor debugging in Rails, note that usingforemanandprytogether works, but it's not as clean asbin/rails server.
Here are some singleton commands you may need, usually in a separate instance/tab of your shell.
- Running the job server (if using
bin/rails server) -- this is for mostly for notifications and emails:bin/rails jobs:work - Clearing jobs (in case you don't want to wait for the backlog of jobs):
bin/rails jobs:clear
Current gotchas: potential environment issues with external services need to be worked out.
⚛ Front-End Development
There is some legacy code which is old school JS, but for all things new, Preact is the where it's at. If you're new to Preact, check out their documentation. Also, consider following the #preact tag on dev.to.
👷 Building components
We use Storybook to develop components. It allows you to focus on building components without the burden of the whole application running. If you're new to Storybook, check out their documentation. Also, consider following the #storybook tag on dev.to.
To get Storybook running on your local:
- 📦 Run
npm installoryarnto ensure all your dependencies are installed. - 🏁 Run
npm run storybookoryarn storybookto start Storybook. - 🏗️ Start working on your component and see the changes in Storybook as you save.
🔑 Key App tech/services
- We use Puma for the server
- We rely heavily on edge caching with Fastly
- We use Cloudinary for image manipulation/serving
- We use Keen for event storage
- We use Airbrake for error monitoring
- We use Timber for logging
- We use Delayed Job for background workers
- We use Algolia for search
- We use Redcarpet/Rouge for Markdown
- We use Carrierwave/Fog/AWS S3 for image upload/storage
- We use a modified version of InstantClick instead of Turbolinks
- We are hosted on Heroku
- We use Heroku scheduler for scheduled jobs (default)
- We use Sendgrid for API-triggered mailing
- We use Mailchimp for marketing/outreach emails
- We use Figaro for app configuration.
- We use CounterCulture to keep track of association counts (counter caches)
- We use Rolify for role management.
- We use Pundit for authorization.
- We use Service Workers to proxy traffic
There's more, but that's a decent overview of the key need-to-knows.
Workflow Suggestion
We use Spring and it is already included in the project.
- Use the provided bin stubs to automatically start Spring, i.e.
bin/rails server,bin/rspec spec/models/,bin/rake db:migrate. - If Spring isn't picking up on new changes, use
spring stop. For example, Spring should always be restarted if there's a change in environment key. - Check Spring's status whenever with
spring status.
Caveat: bin/rspec is not equipped with Spring because it affect Simplecov's result. Instead use bin/spring rspec.
Style Guide
This project follows Bbatsov's Ruby Style Guide, using Rubocop along with Rubocop-Rspec as the code analyzer. If you have Rubocop installed with your text editor of choice, you should be up and running. Settings can be edited in .rubocop.yml.
For Javascript, we follow Airbnb's JS Style Guide, using ESLint and prettier. If you have ESLint installed with your text editor of choice, you should be up and running.
When commits are made, a git precommit hook runs via husky and lint-staged on front-end code that will run eslint and prettier on your code before committing it. If there are linting errors and eslint isn't able to automatically fix it, the commit will not happen. You will need to fix the issue manually then attempt to commit again.
Note: if you've already installed the husky package at least once (used for precommit npm script), you will need to run yarn --force or npm install --no-cache. For some reason the post-install script of husky does not run, when the package is pulled from yarn's or npm's cache. This is not husky specific, but rather a cached package specific issue.
Testing
The following technologies are used for testing:
- Rspec
- Capybara with selenium-webdriver
- chromedriver-helper for standard JS testing.
- guard-rspec for automated testing
- Jest for testing in the front-end.
Previewing emails in development
You can modify the test in /test/mailers/previews
You can view the previews at (for example) http://localhost:3000/rails/mailers/notify_mailer/new_reply_email
How to contribute
- Fork the project & clone locally.
- Create a feature branch:
git checkout -b my-name/feature/that-new-feature - Code and Commit your changes. Bonus point if you write a good commit message:
git commit -am 'Add some feature' - Push to the branch:
git push origin my-name/feature/that-new-feature - Create a new pull request for your feature branch 🎉
Pull request guideline
- Try to keep the pull request small; a pull request should try it's very best to address only a single concern.
- Make sure all the tests pass and add additional tests for the code you submit.
- Document your reasoning behind the changes. Explain why you wrote the code in the way you did, not what it does.
- If there's an existing issue related to the pull request, reference to it. More info here
Please note that we squash all pull request.
Continuous Integration & Continuous Deployment
We are using Travis for CI and CD. Travis will run a build (in isolated environment for testing) for every push to this repository. Keep in mind that a passing-build does not necessarily mean the project won't run into any issues. Strive to write good tests for any chunk of code you wish to contribute. Travis will deploy a pull request to production after CI passes. Our test suite is not perfect and sometimes a re-rerun is needed.
Skipping CI build (Not recommended)
If your changes are minor (i.e. updating README), you can skip CI by adding [skip ci] to your commit message.
CodeClimate and Simplecov
We are using CodeClimate to track code quality and code coverage. Codeclimate will grade the quality of the code of every PR but not the entirety of the project. If you feel that the current linting rule is unreasonable, feel free to submit a separate PR to change it. Fix any errors that Codeclimate provides and strive to leave code better than you found it.
Simplecov is a gem that is tracking the coverage of our test suite. Travis will upload Simplecov data to CodeClimate. We are still in the early stage of using it so it may not provide an accurate measurement our of codebase.
Using simplecov locally
- Run
bundle exec rspec specorbin/rspec spec. You can run rspec on the whole project or a single file. - After rspec is complete, open
index.htmlwithin the coverage folder to view code coverages.
Run bin/rspecov to do all of this in one step