docbrown/spec/requests/admin
Julianna Tetreault 0ee74d1e26
Validate Image URLs in SiteConfig (#11299) [deploy]
* Adds image URL validation to image URLs in configs_controller.rb

* Adds additional image URLs to #valid_image_url in configs_controller.rb

* Adds tests around valid image URLs to configs_spec.rb

* WIP: sets strict conditions for before_action

* WIP: comments out unused code for draft PR

* WIP: cleans up configs_controller.rb for draft PR review

* Renames constant to more explicit IMAGE_FIELDS in configs_controller.rb

* Removes unnecessary comments from admin/configs_spec.rb

* Checks for matching keys in params and IMAGE_FIELDS in configs_controller

* Refactors #valid_image_urls and #valid_image_url in ConfigsController (THANK U, ANDY)

* Refactors image-related code and error messages in Admin::ConfigsController

* Renames expected_image_url to invalid_image_url and removes useless test

* Fix: update the tests to contain valid image urls so that they pass the validation.

* Adjusts tests & VALID_URL regex to validate images rather than image-specific URL

* Replaces $ with \z per Rhymes suggestion and feedback

* Adds accidentally removed code

Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
2020-11-12 12:02:07 -07:00
..
tags Add trusted role to new tag moderators (#11242) 2020-11-05 10:36:26 -05:00
admin_portals_spec.rb Replace calls to Flipper with FeatureFlag (#11386) 2020-11-12 14:15:33 +01:00
articles_spec.rb [deploy] Mark Posts as Published in Admin Articles (#11142) 2020-10-30 10:39:31 -04:00
badge_achievements_spec.rb Add the Ability to Remove Badge Achievements From Users (#9896) [deploy] 2020-08-25 11:14:47 -06:00
badges_spec.rb Add the Ability to Remove Badge Achievements From Users (#9896) [deploy] 2020-08-25 11:14:47 -06:00
broadcasts_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
buffer_updates_spec.rb [deploy] Add missing FKs to BadgeAchievements BanishedUsers BufferUpdates (#10366) 2020-09-29 21:43:14 +02:00
chat_channel_spec.rb [deploy] [Admin Tooling] Allow admins delete empty Connect Channels (#9873) 2020-08-20 14:55:48 +02:00
comments_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
configs_spec.rb Validate Image URLs in SiteConfig (#11299) [deploy] 2020-11-12 12:02:07 -07:00
display_ads_spec.rb [deploy] Extracts DisplayAds from Administrate into admin (#10153) 2020-09-02 09:28:22 -06:00
events_spec.rb Refactor Admin Events Index (#11103) [deploy] 2020-10-29 10:11:15 -06:00
feedback_messages_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
growth_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
html_variants_spec.rb [deploy] HTML Variant admin dashboard (#10188) 2020-09-28 09:22:13 -06:00
invitations_spec.rb Give Admins Ability to Delete Invitations (#10959) 2020-10-20 12:07:36 -04:00
listings_categories_spec.rb Rename misspelled spec file (#10537) 2020-10-02 17:25:22 +02:00
listings_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
moderator_actions_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
moderator_logs_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
mods_spec.rb Fixes 500 error when viewing the "Tag Mods" page without having the role on the database (#10515) 2020-10-01 12:55:25 -06:00
navigation_link_spec.rb [deploy] Bust caches when navigation links are changed (#10865) 2020-10-21 21:30:31 -04:00
organizations_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
pages_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
permissions_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
podcasts_spec.rb [Team Email Login] Refactor Authentication Provider Enable/Disable (#11185) 2020-11-06 18:19:34 -05:00
privileged_reactions_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
profile_field_groups_spec.rb Replace calls to Flipper with FeatureFlag (#11386) 2020-11-12 14:15:33 +01:00
profile_fields_spec.rb Replace calls to Flipper with FeatureFlag (#11386) 2020-11-12 14:15:33 +01:00
reactions_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
response_templates_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
secrets_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
sidebar_spec.rb Replace calls to Flipper with FeatureFlag (#11386) 2020-11-12 14:15:33 +01:00
sponsorships_spec.rb Adds ability to create new sponsorships from admin dashboard (#10187) 2020-09-03 10:10:37 -06:00
tags_spec.rb Add trusted role to new tag moderators (#11242) 2020-11-05 10:36:26 -05:00
tools_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
users_manage_spec.rb [deploy] Add missing FKs to BadgeAchievements BanishedUsers BufferUpdates (#10366) 2020-09-29 21:43:14 +02:00
users_spec.rb Update data exporter to handle admin send (#10274) 2020-10-26 18:00:56 -04:00
welcome_spec.rb [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00