* schema file undelete description * feat: v1 of the script * Flesh out remaining enums under their categories * complete UsersSettings data update script * complete DUS for relevant attributes in users and profiles tables * complete DUS for users_notification_settings * alphabetize user_settings sql file * safeguard against null values for "null: false" settings * Set up actual UsersSettings DUS and specs files * fix broken DUS script * complete specs for UsersSetting DUS * Address QA of specs * complete specs for users_notification_settings DUS * fix the typos (thanks Julianna!) * begin implementation * still building * add missing attribute "email_membership_newsletter" * complete sync code (except race condition for user profile) * complete implementation, remains tests * Address PR review and fix Travis fails * remove superfluous Profile.new * fix travis fails * feat: update the users_notification_setting attributes from the user model * feat: use the config fonts enums to display the fonts * feat: loop through the keys * fix profile = nil blowing up; add specs for notification_setting model * remove unneeded spec * remove feed validation until after sync code removed; fixes feed_import spec failures * remove spec associated with feed_url validation in user_setting model * fix failing spec 😅 * add TODO * feat: set the user settings in the user controller and use it in the customization form * feat: move some update logic to the users settings controller thats being used from customization * feat: show the updated values form the users_settingd and not the user instance * Generalize redirect back to current tab * still trying to reflect changed theme upon refresh * customizations take effect on refresh * remove 'with_feed' scope from user model Co-authored-by: Jamie Gaskins <jamie@forem.com> * start with takeover for fields previously in profiles table * Takeover code for `publishing_from_rss` section in Settings (#13914) * implement takeover code part 1 * implement takeover code * fix feed fetch * need rhymes help * complete implementation; specs pending * fix STUPID omission that caused so many headaches 😫 * implement profile fields pointing to users_settings 🎉 * run migrations * implement inbox type & guidelines takeover code; specs pending (#13911) * Point changes in notification settings to `users_notification_settings` table (#13910) * implement takeover code; remains specs * address PR feedback; remove related sync code * address PR review feedback * need help with routing and specs * address pr review * addressing pr review * Treat implementation edge cases and omissions 😅 * fix uncommented comment * fixing implementation cases * address more PR review feedback * fixing notifications use-cases * refactor settings controller * more pr review changes * solving bugs * fix broken onboarding * handle eperience_level calls * more fixes * remove unneeded mappings * add To-dos for quety updates * remove done TODO * purge done TODOs * update notification_settings-related queries * start fixing specs * fixing specs * fix notification and lrg_forem specs * fixing broken specs * still fixing * fix line dif and remove reloads from user.rb * run specs * silence bullet and other fixes * remove setting migration scripts and specs, fix more settings for specs * handle missing user for article builder and fix notification specs * fix some final controller specs and re-add incorrectly removed specs * remove deprecated data update scripts and related workers, put travis back * refactor admin tags mods controller, write/move specs for users notifications settings controller * schema cleanup and other small refactors for consistency * set field we can invalidate in spec via active record instead of at the db level * remove I think an uneccessary hook call from subscribe_to_mailchimp_newsletter * use bnefore_create to setup settings, please dont blow up the test suite * mailchimp bot fix * remove decorator in favor of single model method Co-authored-by: Arit Amana <msarit@gmail.com> Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com> Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com> Co-authored-by: Jamie Gaskins <jamie@forem.com>
93 lines
3 KiB
Ruby
93 lines
3 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe Follow, type: :model do
|
|
let(:user) { create(:user) }
|
|
let(:tag) { create(:tag) }
|
|
let(:user_2) { create(:user) }
|
|
|
|
describe "validations" do
|
|
subject { user.follow(user_2) }
|
|
|
|
it { is_expected.to validate_inclusion_of(:subscription_status).in_array(%w[all_articles none]) }
|
|
it { is_expected.to validate_presence_of(:followable_id) }
|
|
it { is_expected.to validate_presence_of(:followable_type) }
|
|
it { is_expected.to validate_presence_of(:follower_id) }
|
|
it { is_expected.to validate_presence_of(:follower_type) }
|
|
it { is_expected.to validate_presence_of(:subscription_status) }
|
|
end
|
|
|
|
it "follows user" do
|
|
user.follow(user_2)
|
|
expect(user.following?(user_2)).to eq(true)
|
|
end
|
|
|
|
it "calculates points with explicit and implicit combined" do
|
|
user.follow(tag)
|
|
follow = described_class.last
|
|
follow.explicit_points = 2.0
|
|
follow.implicit_points = 3.0
|
|
follow.save
|
|
expect(follow.points).to eq(5.0)
|
|
end
|
|
|
|
context "when enqueuing jobs" do
|
|
it "enqueues create channel job" do
|
|
expect do
|
|
described_class.create(follower: user, followable: user_2)
|
|
end.to change(Follows::CreateChatChannelWorker.jobs, :size).by(1)
|
|
end
|
|
|
|
it "enqueues send notification worker" do
|
|
expect do
|
|
described_class.create(follower: user, followable: user_2)
|
|
end.to change(Follows::SendEmailNotificationWorker.jobs, :size).by(1)
|
|
end
|
|
end
|
|
|
|
context "when creating and inline" do
|
|
it "touches the follower user while creating" do
|
|
timestamp = 1.day.ago
|
|
user.update_columns(updated_at: timestamp, last_followed_at: timestamp)
|
|
described_class.create!(follower: user, followable: user_2)
|
|
|
|
user.reload
|
|
expect(user.updated_at).to be > timestamp
|
|
expect(user.last_followed_at).to be > timestamp
|
|
end
|
|
|
|
it "doesn't create a channel when a followable is an org" do
|
|
expect do
|
|
sidekiq_perform_enqueued_jobs do
|
|
described_class.create!(follower: user, followable: create(:organization))
|
|
end
|
|
end.not_to change(ChatChannel, :count)
|
|
end
|
|
|
|
it "doesn't create a chat channel when users don't follow mutually" do
|
|
expect do
|
|
sidekiq_perform_enqueued_jobs do
|
|
described_class.create!(follower: user, followable: user_2)
|
|
end
|
|
end.not_to change(ChatChannel, :count)
|
|
end
|
|
|
|
it "creates a chat channel when users follow mutually" do
|
|
described_class.create!(follower: user_2, followable: user)
|
|
expect do
|
|
sidekiq_perform_enqueued_jobs do
|
|
described_class.create!(follower: user, followable: user_2)
|
|
end
|
|
end.to change(ChatChannel, :count).by(1)
|
|
end
|
|
|
|
it "sends an email notification" do
|
|
allow(ForemInstance).to receive(:smtp_enabled?).and_return(true)
|
|
user_2.notification_setting.update(email_follower_notifications: true)
|
|
expect do
|
|
Sidekiq::Testing.inline! do
|
|
described_class.create!(follower: user, followable: user_2)
|
|
end
|
|
end.to change(EmailMessage, :count).by(1)
|
|
end
|
|
end
|
|
end
|