0d0464be2f
* Allowing VariantQuery for Feed Generation Apologies for the breadth of this pull request, I had considered many small commits, but felt that would've been more effort for the value provided. This commit includes the following: - Documentation updates to the feed variant (though not the final pass) - Renaming and adding RelevancyLevers that help differentiate - Adding RelevancyLever#range to provide documentation - Reducing redundent controller logic by making a `Articles::Feeds.feed_for` method. - Adding some configuration validation for RelevancyLevers - Adding constants for better clarification - Testing unhappy paths for feed configuration - Adjusting the module namespace of some objects - Exposing top-level configurations for variants (along with their defaults) - Creating the VariantyQuery that at present inherits from the `Articles::Feeds::WeightedQueryStrategy` As implemented, we can deploy this code to production without using the new VariantQuery. Once we toggle on the `:feed_uses_variant_query_feature` FeatureFlag, it will switch to using the VariantQuery. The VariantQuery's two variants and the internal configuration of `Articles::Feeds::WeightedQueryStrategy` produce the same query. The goal of this factor is to allow for a quick on and off toggle of the feed query; to ensure that what we introduce remains performant. - Closes forem/forem#17272 - Closes forem/forem#17276 - Closes forem/forem#17216 In addition, I will be recording a code-walkthrough and linking that recording to the pull request. * Apply suggestions from code review Co-authored-by: Mac Siri <krairit.siri@gmail.com> Co-authored-by: Mac Siri <krairit.siri@gmail.com>
21 lines
766 B
Ruby
21 lines
766 B
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe Articles::Feeds::VariantAssembler do
|
|
describe ".call" do
|
|
Rails.root.glob("#{described_class::DIRECTORY}/*.#{described_class::EXTENSION}").each do |pathname|
|
|
variant = pathname.basename(".json").to_s.to_sym
|
|
context "for #{variant.inspect}" do
|
|
# NOTE: We're providing the variants so as to not pollute the cache for other tests.
|
|
subject { described_class.call(variant: variant, variants: {}) }
|
|
|
|
it { is_expected.to be_a(Articles::Feeds::VariantQuery::Config) }
|
|
end
|
|
end
|
|
|
|
context "with missing variant" do
|
|
subject { described_class.call(variant: :obviously_missing, variants: {}) }
|
|
|
|
it { within_block_is_expected.to raise_error(Errno::ENOENT) }
|
|
end
|
|
end
|
|
end
|