* Remove hardcoded instances of education field * WIP Access display_email_on_profile via User Settings * Remove unused profile column * WIP Fix reference to bg_color_hex and text_color_hex * WIP fix issues revealed by systems specs * WIP fix issues revealed by services specs * WIP Fix failing tests * WIP Fix spec failures * wip * Move two attributes from controller to decorator * Update comment * Match user settings changes * More consistently use user.tag_line Even before the profile changes we sometimes used the user.summary attribute directly but used the user.tag_line method in other places. * Remove delegation, rename inline concern * Drop profile columns from users table * Remove duplicated work display from header * Update work profile field handling * Update DUS + spec * Delegate more carefully * Update delegation guard * Adapt for removed delegation * Undo accidental schema changes * Fix seeds * Remove accidentaly change * Fix User#processed_website_url * Update guard clause * Update profile card content * Add Organization#profile * Be more conservative with profile fields * Spec fixes round 1 * Fix typo * Update spec * Limit number of header fields and update card content * Decorate correct model * Update factory * Update schema.rb * Fix validation * How bad could this possibly be? * Pretty bad, nevermind * Remove obsolete code * Reset profile fields during test runs * Move profile fields back to before(:suite) * Spec fixes * Remove accidentally re-added files * More spec fixes * Specs * Change User#tag_keywords_for_search * More spec fixes * Add comment * Undo accidental schema changes * Attempt spec fix * Remove fix attempt * Fix e2e test * Update spec * Remove guard clause * Remove hardcoded instances of education field * WIP Access display_email_on_profile via User Settings * Remove unused profile column * WIP fix issues revealed by systems specs * WIP fix issues revealed by services specs * WIP Fix failing tests * WIP Fix spec failures * wip * Move two attributes from controller to decorator * Update comment * More consistently use user.tag_line Even before the profile changes we sometimes used the user.summary attribute directly but used the user.tag_line method in other places. * Remove education * Add comment * WIP * Clean up mostly_work_with * WIP * Update work profile field handling * More work-related changes * Remove settings_only from display_area enum * Remove quickfix from _metadata partial * Remove special attributes * Remove leftover spec * Retrieve location from profile, not user * Profile.special_attributes no longer exists * Update specs * More spec fixes * Update UsersController * Update UsersController and spec * Fix e2e seeds * Minor cleanup * More e2e seed fixes * Fix profile field CSV * Fix e2e seeds * Move one more attribute in e2e seeds * Remove duplicate line * Clear inputs before typing in them * Fix formatting issues * Profiles::Update -> Users::Update * Remove RegistrationsController#resolve_profile_field_issues * Fix schema.rb * More cleanup * Fix specs * Fix remaining spec Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
54 lines
1.7 KiB
Ruby
54 lines
1.7 KiB
Ruby
class ProfileValidator < ActiveModel::Validator
|
|
SUMMARY_ATTRIBUTE = "summary".freeze
|
|
MAX_SUMMARY_LENGTH = 200
|
|
|
|
MAX_TEXT_AREA_LENGTH = 200
|
|
MAX_TEXT_FIELD_LENGTH = 100
|
|
|
|
ERRORS = {
|
|
text_area: "is too long (maximum is #{MAX_TEXT_AREA_LENGTH} characters)",
|
|
text_field: "is too long (maximum is #{MAX_TEXT_FIELD_LENGTH} characters)"
|
|
}.with_indifferent_access.freeze
|
|
|
|
def validate(record)
|
|
# NOTE: The summary is a base profile field, which we add to all new Forem
|
|
# instances, so it should be safe to validate. The method itself also guards
|
|
# against the field's absence.
|
|
record.errors.add(:summary, "is too long") if summary_too_long?(record)
|
|
|
|
ProfileField.all.each do |field|
|
|
attribute = field.attribute_name
|
|
next if attribute == SUMMARY_ATTRIBUTE # validated above
|
|
next unless record.respond_to?(attribute) # avoid caching issues
|
|
next if __send__("#{field.input_type}_valid?", record, attribute)
|
|
|
|
record.errors.add(attribute, ERRORS[field.input_type])
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def summary_too_long?(record)
|
|
return if record.summary.blank?
|
|
|
|
# Grandfather in people who had a too long summary before
|
|
previous_summary = record.summary_was
|
|
return if previous_summary && previous_summary.size > MAX_SUMMARY_LENGTH
|
|
|
|
record.summary.size > MAX_SUMMARY_LENGTH
|
|
end
|
|
|
|
def check_box_valid?(_record, _attribute)
|
|
true # checkboxes are always valid
|
|
end
|
|
|
|
def text_area_valid?(record, attribute)
|
|
text = record.public_send(attribute)
|
|
text.nil? || text.size <= MAX_TEXT_AREA_LENGTH
|
|
end
|
|
|
|
def text_field_valid?(record, attribute)
|
|
text = record.public_send(attribute)
|
|
text.nil? || text.size <= MAX_TEXT_FIELD_LENGTH
|
|
end
|
|
end
|