docbrown/spec
Jacob Herrington 00dd84f9e1 Add a default message to badge award action (#5160)
* Add a default message to badge award action

Because:
 - The only badges routinely awarded manually use the same message
 - Right now, unfriendly/unsafe UI can result in an error notification

The only badges that are currently awarded manually (afaik) have the
message "Congrats!!!" so for the time being, if a message is not
supplied to the UI, it will simply use the "Congrats!!!" message as a
default.

That being said, I'm not totally convinced this message won't work for
the long term. Generally, if we are awarding badges by hand, I'd imagine
we'd want a specific message explaining why we are doing that, or just
be okay with "Congrats!"

After talking with Peter about it, the longer term goal should be to
move badge messages into the database so they can be modified in the app
and not hardcoded. That also make sense regarding the effort to
genericize the app eventually.

* Test Badge notifications
2019-12-19 10:38:57 -05:00
..
black_box Adjust type tags for RSpec (#4864) 2019-11-20 13:01:30 -05:00
decorators Improve speed of model tests by around 50/60 seconds (#5016) 2019-12-09 16:33:48 -05:00
factories Fix rubocop Rails.root.path complaints (#5114) 2019-12-16 12:13:15 -05:00
fixtures Add lazy loading to iframes (#4673) 2019-11-18 18:31:56 -05:00
helpers Fix linting (#4933) [deploy] 2019-11-26 08:35:34 -05:00
initializers Group Internal Errors when sending to HoneyBadger (#5067) 2019-12-10 13:48:06 -06:00
jobs Fix Algolia deserialization errors by indexing by record_type and id rather than AR object (#5063) [deploy] 2019-12-11 11:49:35 -06:00
labor Dont Raise Error For Incorrect Liquid Tags (#5089) [deploy] 2019-12-18 11:23:39 -06:00
lib Remove RedisRailsCache and replace with Rails.cache (#5059) [deploy] 2019-12-10 13:11:08 -06:00
liquid_tags Add Next Tech Liquid Tag (#4958) [deploy] 2019-12-10 15:19:30 -05:00
mailers Make The Default Email An Enviroment Variable. (#4677) 2019-11-01 09:03:06 -04:00
models Refactor all has_enough_credits to enough_credits (#5119) 2019-12-16 15:00:59 -05:00
observers Remove unused spec support BackgroundJobs (#4464) [ci skip] 2019-10-24 16:49:45 -04:00
policies Fix Rubocop lints (#5155) 2019-12-19 10:09:37 -05:00
requests Add a default message to badge award action (#5160) 2019-12-19 10:38:57 -05:00
routing Enabled rubocop/lint (#2130) 2019-03-21 10:53:44 -04:00
services Add a default message to badge award action (#5160) 2019-12-19 10:38:57 -05:00
support Add Next Tech Liquid Tag (#4958) [deploy] 2019-12-10 15:19:30 -05:00
system Add a default message to badge award action (#5160) 2019-12-19 10:38:57 -05:00
uploaders Adjust type tags for RSpec (#4864) 2019-11-20 13:01:30 -05:00
views Improve test speed (#3957) [ci skip] 2019-09-12 16:17:20 -04:00
rails_helper.rb Fix rubocop Rails.root.path complaints (#5114) 2019-12-16 12:13:15 -05:00
spec_helper.rb Temporarily comment out random (#2486) 2019-04-18 11:56:38 -04:00