maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/app/controllers
History
Jacob Herrington 00dd84f9e1 Add a default message to badge award action (#5160) 
* Add a default message to badge award action

Because:
 - The only badges routinely awarded manually use the same message
 - Right now, unfriendly/unsafe UI can result in an error notification

The only badges that are currently awarded manually (afaik) have the
message "Congrats!!!" so for the time being, if a message is not
supplied to the UI, it will simply use the "Congrats!!!" message as a
default.

That being said, I'm not totally convinced this message won't work for
the long term. Generally, if we are awarding badges by hand, I'd imagine
we'd want a specific message explaining why we are doing that, or just
be okay with "Congrats!"

After talking with Peter about it, the longer term goal should be to
move badge messages into the database so they can be modified in the app
and not hardcoded. That also make sense regarding the effort to
genericize the app eventually.

* Test Badge notifications
2019-12-19 10:38:57 -05:00
..
admin Pro: memberships (#3461) 2019-09-24 10:38:54 -07:00
api/v0 Remove RedisRailsCache and replace with Rails.cache (#5059) [deploy] 2019-12-10 13:11:08 -06:00
concerns Monkeypatch method to ensure https redirect (#5145) [deploy] 2019-12-16 18:15:14 -05:00
internal Add a default message to badge award action (#5160) 2019-12-19 10:38:57 -05:00
notifications Allow users to belong to multiple orgs (#2583) 2019-06-04 09:30:52 -04:00
oauth Destroy webhook endpoints when user revokes oaurh app access (#4099) 2019-09-26 06:23:38 -04:00
additional_content_boxes_controller.rb Make AdditionalContentBoxesController#randomize private (#3115) [ci skip] 2019-06-11 10:27:29 -04:00
api_secrets_controller.rb Make The Default Email An Enviroment Variable. (#4677) 2019-11-01 09:03:06 -04:00
application_controller.rb Return ActionController::RoutingError error when Invalid Format is Requested (#5140) [deploy] 2019-12-17 10:00:12 -05:00
application_metal_controller.rb Add ApplicationMetalController to relevant controllers (#4937) 2019-11-26 16:29:07 -05:00
articles_controller.rb Return not_found response rather than trying to authorize a nil object (#5093) [deploy] 2019-12-13 09:39:40 -06:00
async_info_controller.rb Migrate to streaming app shell via serviceworkers (#5020) [deploy] 2019-12-16 12:21:33 -05:00
badges_controller.rb Add badges index page. (#4236) 2019-10-06 17:34:52 -04:00
blocks_controller.rb Rubocop Style cops enabled (#2056) 2019-03-15 18:33:54 -04:00
buffer_updates_controller.rb Add page for users to "manage" their posts after publication (distribution, etc.) (#2627) 2019-05-01 09:00:09 -04:00
buffered_articles_controller.rb Select path when loading buffered article urls (#4651) [ci skip] 2019-10-30 10:37:22 -04:00
chat_channel_memberships_controller.rb Added rubocop-rails (#3059) 2019-06-06 09:47:57 -04:00
chat_channels_controller.rb Remove RedisRailsCache and replace with Rails.cache (#5059) [deploy] 2019-12-10 13:11:08 -06:00
classified_listings_controller.rb Listings creation and update API (#4014) 2019-09-24 07:03:52 -07:00
comments_controller.rb Fix Rubocop lints (#5155) 2019-12-19 10:09:37 -05:00
credits_controller.rb Pro: memberships (#3461) 2019-09-24 10:38:54 -07:00
dashboards_controller.rb Add pagination to followers and following page in dashboard (#258) (#4375) [deploy] 2019-11-20 18:21:18 -05:00
display_ad_events_controller.rb Add ApplicationMetalController to relevant controllers (#4937) 2019-11-26 16:29:07 -05:00
downloads_controller.rb Add android and ios apps download page (#3736) (#3798) 2019-08-22 21:04:58 -04:00
email_subscriptions_controller.rb Use timezone aware methods (#893) 2018-10-18 16:26:29 -04:00
events_controller.rb Remove Honeycomb from the app (#2366) 2019-04-11 10:49:35 -04:00
feedback_messages_controller.rb Removed bug reports from app (#1565) 2019-01-16 11:28:59 -05:00
follows_controller.rb Store FollowChecker responses to Avoid Multiple db Hits (#4886) [deploy] 2019-11-26 13:03:19 -06:00
ga_events_controller.rb Remove RedisRailsCache and replace with Rails.cache (#5059) [deploy] 2019-12-10 13:11:08 -06:00
github_repos_controller.rb Enable Layout/AlignParameters (#2340) 2019-04-08 18:47:34 -04:00
history_controller.rb Pro: memberships (#3461) 2019-09-24 10:38:54 -07:00
html_variant_successes_controller.rb Add ApplicationMetalController to relevant controllers (#4937) 2019-11-26 16:29:07 -05:00
html_variant_trials_controller.rb Add ApplicationMetalController to relevant controllers (#4937) 2019-11-26 16:29:07 -05:00
html_variants_controller.rb Fixed rubocop issues, new .rubocop_todo.yml (#3255) 2019-06-21 14:26:39 -04:00
image_uploads_controller.rb Simplify the images uploading code (#3907) [ci skip] 2019-09-04 08:14:59 -04:00
liquid_embeds_controller.rb Modify headers to allow embed (#3935) 2019-09-03 16:38:04 -04:00
live_articles_controller.rb Fix rubocop lints (#794) 2018-10-03 13:00:09 -04:00
messages_controller.rb Feature🚀: Ability to Delete Messages realtime (#5056) 2019-12-10 13:58:34 -05:00
moderations_controller.rb Mod tooling: add tags via /mod refactor (#5017) 2019-12-13 13:02:45 -05:00
notification_subscriptions_controller.rb Fixed rubocop issues, new .rubocop_todo.yml (#3255) 2019-06-21 14:26:39 -04:00
notifications_controller.rb Default return all user notifications if filter is unknown (#5103) [deploy] 2019-12-13 14:35:53 -05:00
omniauth_callbacks_controller.rb Use Redis for session storage (#4004) [deploy] 2019-11-12 10:10:34 -06:00
organizations_controller.rb Fix encoding of special characters on organization page rendering (#3944) 2019-09-09 14:13:23 -04:00
page_views_controller.rb switch back to update_column to improve performance (#5074) [deploy] 2019-12-10 18:38:04 -05:00
pages_controller.rb Remove all old membership code, see 97040ab6 (#3575) 2019-07-30 12:33:50 -04:00
partnerships_controller.rb Sponsorship Updates (#3719) 2019-08-16 14:54:26 -04:00
podcast_episodes_controller.rb Feat: #3498 Display episode's published_at (#4272) 2019-10-08 17:06:46 -04:00
poll_skips_controller.rb Use find_or_create_by to avoid duplicate records (#5092) 2019-12-12 12:01:15 -06:00
poll_votes_controller.rb Fixed rubocop issues, new .rubocop_todo.yml (#3255) 2019-06-21 14:26:39 -04:00
pro_accounts_controller.rb Add basic pro accounts lander test (#3433) 2019-07-09 22:10:50 -04:00
pro_memberships_controller.rb Pro: memberships (#3461) 2019-09-24 10:38:54 -07:00
profile_pins_controller.rb CacheBuster refactoring (#4766) 2019-11-13 10:51:23 -05:00
push_notification_subscriptions_controller.rb Added rubocop-rails (#3059) 2019-06-06 09:47:57 -04:00
pusher_controller.rb Enable Layout/AlignParameters (#2340) 2019-04-08 18:47:34 -04:00
rating_votes_controller.rb Add experience level averaging to articles (#1922) 2019-02-28 08:17:29 -08:00
reactions_controller.rb Remove RedisRailsCache and replace with Rails.cache (#5059) [deploy] 2019-12-10 13:11:08 -06:00
reading_list_items_controller.rb Replace current_user.id with session_current_user_id (#4880) [deploy] 2019-11-22 14:27:43 -05:00
registrations_controller.rb Use timezone aware methods (#893) 2018-10-18 16:26:29 -04:00
service_worker_controller.rb Replace serviceworker-rails gem with custome implementation (#4987) [deploy] 2019-12-03 08:50:56 -05:00
shell_controller.rb Add edge caching to shell (#5146) [deploy] 2019-12-16 19:08:59 -05:00
social_previews_controller.rb Fix black-on-black etc. buttons and update social preview cards (#4954) 2019-11-28 09:39:07 -05:00
stories_controller.rb Fix Rubocop lints (#5155) 2019-12-19 10:09:37 -05:00
stripe_active_cards_controller.rb Enable Layout/AlignParameters (#2340) 2019-04-08 18:47:34 -04:00
tag_adjustments_controller.rb Mod tooling: add tags via /mod refactor (#5017) 2019-12-13 13:02:45 -05:00
tags_controller.rb Refactoring possible unprotected redirect. (#3825) 2019-08-27 10:13:38 -04:00
twilio_tokens_controller.rb Added rubocop-rails (#3059) 2019-06-06 09:47:57 -04:00
twitch_live_streams_controller.rb Embed Twitch Live Streaming (#2591) 2019-04-29 18:11:53 -04:00
twitch_stream_updates_controller.rb Replace Airbrake with Honeybadger (#5007) [deploy] 2019-12-05 11:29:51 -06:00
user_blocks_controller.rb Routine rubocop lint fixes (#4638) [ci skip] 2019-10-30 10:46:57 -04:00
users_controller.rb Return not_found response rather than trying to authorize a nil object (#5093) [deploy] 2019-12-13 09:39:40 -06:00
video_states_controller.rb Added rubocop-rails (#3059) 2019-06-06 09:47:57 -04:00
videos_controller.rb Refactor VideosController (#3806) [ci skip] 2019-08-26 18:59:31 -04:00