060e426389
* Prefer compact_blank! to delete_if blank Rubocop suggested this. Why would I argue. * When sort_direction is anything other than asc or desc, remove it There is initializer code in the search/query classes that handles nil sort_direction by adding a default value, so deleting the sort direction is reasonable here. * Set a default sort direction for articles of :desc * Only sort if sort_direction and sort_by are present * Add test case for article search with invalid parameter
32 lines
998 B
Ruby
32 lines
998 B
Ruby
module Search
|
|
class Article
|
|
DEFAULT_SORT_BY = "hotness_score DESC, comments_count DESC".freeze
|
|
|
|
def self.search_documents(
|
|
term: nil,
|
|
user_id: nil,
|
|
sort_by: nil,
|
|
sort_direction: nil,
|
|
page: nil,
|
|
per_page: nil
|
|
)
|
|
relation = Homepage::ArticlesQuery.call(user_id: user_id, page: page, per_page: per_page)
|
|
|
|
relation = relation.search_articles(term) if term.present?
|
|
|
|
relation = sort(relation, term, sort_by, sort_direction)
|
|
|
|
Homepage::ArticleSerializer.serialized_collection_from(relation: relation)
|
|
end
|
|
|
|
def self.sort(relation, term, sort_by, sort_direction)
|
|
# By skipping ordering, we rely on the custom ranking defined in the article's tsvector document
|
|
return relation if term.present? && sort_by.blank?
|
|
|
|
return relation.reorder(sort_by => sort_direction) if sort_by&.to_sym == :published_at && sort_direction
|
|
|
|
relation.reorder(DEFAULT_SORT_BY)
|
|
end
|
|
private_class_method :sort
|
|
end
|
|
end
|