docbrown/app/controllers/omniauth_callbacks_controller.rb
Fernando Valverde 1eafd7388e
Fix email confirmation logic when registering via Omniauth (#17878)
* Move .skip_confirmation! call to .find_or_create_user! method

* Add regression tests to avoid email confirmation delivery

* Keep the original place where we had user.skip_confirmation! too

* Update logic to require email confirmation from omniauth

* test confirmation is required with SMTP

* Keep :notice instead of :global_notice

* Forem Account bypass email confirmation reorg

* inline comment reorder + clarification

* Apply suggestions from code review

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

Co-authored-by: Fernando Valverde <fernando@visualcosita.com>
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2022-06-23 16:26:26 -04:00

108 lines
4 KiB
Ruby

class OmniauthCallbacksController < Devise::OmniauthCallbacksController
include Devise::Controllers::Rememberable
# Rails actionpack only allows POST requests that come with an ORIGIN header
# that matches `request.base_url`, it raises CSRF exception otherwise.
# There is no way to allow specific ORIGIN values in order to securely bypass
# trusted origins (i.e. Apple OAuth) so `protect_from_forgery` is skipped
# ONLY when it's safe to do so (i.e. ORIGIN == 'https://appleid.apple.com').
# The hardcoded CSRF check can be found in the method `valid_request_origin?`:
# https://github.com/rails/rails/blob/901f12212c488f6edfcf6f8ad3230bce6b3d5792/actionpack/lib/action_controller/metal/request_forgery_protection.rb#L449-L459
protect_from_forgery unless: -> { safe_apple_callback_request? }
# Each available authentication method needs a related action that will be called
# as a callback on successful redirect from the upstream OAuth provider
Authentication::Providers.available.each do |provider_name|
define_method(provider_name) do
callback_for(provider_name)
end
end
# Callback for third party failures (shared by all providers)
def failure
error = request.env["omniauth.error"]
class_name = error.present? ? error.class.name : ""
ForemStatsClient.increment(
"omniauth.failure",
tags: [
"class:#{class_name}",
"message:#{error&.message}",
"reason:#{error.try(:error_reason)}",
"type:#{error.try(:error)}",
"uri:#{error.try(:error_uri)}",
"provider:#{request.env['omniauth.strategy'].name}",
"origin:#{request.env['omniauth.strategy.origin']}",
"params:#{request.env['omniauth.params']}",
],
)
super
end
def passthru
redirect_to root_path(signin: "true")
end
private
def callback_for(provider)
auth_payload = request.env["omniauth.auth"]
cta_variant = request.env["omniauth.params"]["state"].to_s
@user = Authentication::Authenticator.call(
auth_payload,
current_user: current_user,
cta_variant: cta_variant,
)
if user_persisted_and_valid? && @user.confirmed?
# User is allowed to start onboarding
set_flash_message(:notice, :success, kind: provider.to_s.titleize) if is_navigational_format?
# Devise's Omniauthable does not automatically remember users
# see <https://github.com/heartcombo/devise/wiki/Omniauthable,-sign-out-action-and-rememberable>
remember_me(@user)
sign_in_and_redirect(@user, event: :authentication)
elsif user_persisted_and_valid?
redirect_to confirm_email_path(email: @user.email)
else
# Devise will clean this data when the user is not persisted
session["devise.#{provider}_data"] = request.env["omniauth.auth"]
user_errors = @user.errors.full_messages
Honeybadger.context({
username: @user.username,
user_id: @user.id,
auth_data: request.env["omniauth.auth"],
auth_error: request.env["omniauth.error"].inspect,
user_errors: user_errors
})
Honeybadger.notify("Omniauth log in error")
flash[:alert] = user_errors
redirect_to new_user_registration_url
end
rescue ::Authentication::Errors::PreviouslySuspended, ::Authentication::Errors::SpammyEmailDomain => e
flash[:global_notice] = e.message
redirect_to root_path
rescue StandardError => e
Honeybadger.notify(e)
flash[:alert] = I18n.t("omniauth_callbacks_controller.log_in_error", e: e)
redirect_to new_user_registration_url
end
def user_persisted_and_valid?
@user.persisted? && @user.valid?
end
# We only bypass CSRF checks on Apple callback path & Apple trusted ORIGIN
def safe_apple_callback_request?
trusted_origin = Authentication::Providers::Apple::TRUSTED_CALLBACK_ORIGIN
request.fullpath == Authentication::Providers::Apple::CALLBACK_PATH &&
request.headers["ORIGIN"] == trusted_origin
end
end