1b2aa68a4d
* Ensuring confirmation and flash message for spaces This change delivers an accessible form, and while it doesn't remove the Save button nor produce a modal it does deliver the minimum viable functionality. In conversations with Suzanne, we spent an hour looking at how we might make an accessible modal with the checkbox and state management required as we as removing save buttons. There are two paths: 1. Extend the current, yet deprecated, stimulus modal controller. 2. Extend the Preact modal work done for the Members Detail View. We spent about 15 minutes pursuing the stimulus modal controller route, and realized how much cruft it added to the system. Not ideal and very opaque in it's interaction. The second one we talked about, but for our alloted time was inadequate to begin further work. To deliver on that generalized preact modal will require at least an afternoon of work. Closes forem/forem#17032 * Update config/locales/controllers/admin/fr.yml Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com> * Update app/views/admin/spaces/index.html.erb Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com> Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
55 lines
2 KiB
Ruby
55 lines
2 KiB
Ruby
module Admin
|
|
# @note The ./config/routes/admin.rb file has a constraint around this controller
|
|
#
|
|
# @see https://github.com/orgs/forem/projects/46/views/1 project
|
|
class SpacesController < Admin::ApplicationController
|
|
layout "admin"
|
|
|
|
after_action only: %i[update] do
|
|
Audit::Logger.log(:internal, current_user, params.dup)
|
|
end
|
|
|
|
# When we change the settings of a Space, this can impact what user's see. Thus, we need to
|
|
# ensure we are busting the cache.
|
|
#
|
|
# @see ApplicationHelper#release_adjusted_cache_key ApplicationHelper#release_adjusted_cache_key
|
|
# produces the cache key we use for caching the homepage's top bar.
|
|
after_action :bust_content_change_caches, only: %i[update]
|
|
|
|
# @note I'm instantiating the @space because in the index view I'm rendering a form that then
|
|
# PUTs to the update action.
|
|
def index
|
|
authorize(Space)
|
|
@space = Space.new
|
|
end
|
|
|
|
# @note The initial implementation of Spaces is simply exposing a means of toggling on or off a
|
|
# feature flag. Further, the Space model is an ApplicationRecord model, but instead is
|
|
# the bare bones for a quick yet verbose implementation of the [Authorization System: use
|
|
# case 1-1](see https://github.com/orgs/forem/projects/46/views/1)
|
|
def update
|
|
# NOTE: We're not trying to find a space, we simply are treating this as a singleton type
|
|
# resource.
|
|
@space = Space.new(space_params)
|
|
authorize(@space)
|
|
|
|
# NOTE: As of <2022-03-16 Wed> we don't have validation on a space.
|
|
@space.save
|
|
|
|
respond_to do |wants|
|
|
wants.html do
|
|
redirect_to admin_spaces_path, notice: t("admin.spaces_controller.update_success")
|
|
end
|
|
wants.json do
|
|
render json: { message: t("admin.spaces_controller.update_success") }, status: :ok
|
|
end
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def space_params
|
|
params.fetch(:space).permit(:limit_post_creation_to_admins)
|
|
end
|
|
end
|
|
end
|