Commit graph

309 commits

Author SHA1 Message Date
Ben Halpern
c60566b8a5
[deploy] Modify code to deal with flaky tests (#10616)
* Modify code to deal with flaky tests

* Remove uneeded x
2020-10-05 14:54:11 -04:00
Ben Halpern
c0d5486023
[deploy] Fix current_user cache issue in comments (#10609) 2020-10-05 10:52:12 -04:00
ludwiczakpawel
1375e8a4df
[deploy] Redesigned Comment Form (#10355)
* init

* .

* .

* better

* last bits

* specs

* merge

* fix response templates for replies

* copy

* active inactive buttons + cleanup

* labels

* specs

* specs

* response templates fix

* ....

* wtf

* .
2020-10-05 12:01:48 +02:00
ludwiczakpawel
9d384e1a93
CSS Cleanups, part 2 (#10527)
* padding-top on body

* padding-top on body

* move cheese around

* .

* :(

* rename
2020-10-03 06:57:57 +02:00
Robin Gagnon
87590e77d3
[deploy] feat: Disable autoplay on native videos (#10516) 2020-10-01 16:52:12 -06:00
Mac Siri
02bd3111af
[deploy] Refactor: Create setCurrentUserToNavBar (#10501) 2020-09-30 16:20:23 -04:00
narender2031
649c23f854
add no console rule front-end (#10362)
* add no console rule front-end

* add no-console to root eslintrc

* disbale no console rule

* remove console
2020-09-29 09:56:37 +02:00
Fernando Valverde
b5309c4a21
[deploy] User agent check fix for native iOS (#10472) 2020-09-28 14:45:36 -04:00
Molly Struve
6193ceeace
[deploy] Refactor: Cleanup Frontend Code (#10466) 2020-09-28 08:57:34 -05:00
ludwiczakpawel
3e9b56a7dd
[deploy] Frontend cleanups (#10416) 2020-09-24 08:15:12 -05:00
Ben Halpern
3e09a7768f
[deploy] Remove need for ENV vars during asset precompile (#10349)
* Remove need for ENV vars during asset precompile

* Add open-search test
2020-09-16 13:57:05 -04:00
Fernando Valverde
1aa8233d9e
Adds runtime copy to clipboard (#10323) 2020-09-14 14:45:54 -04:00
Vaidehi Joshi
abe2489394
Hide active broadcasts from /connect routes (#10312)
Fixes https://github.com/forem/forem/issues/9683.
Also refactors the initializeBroadcast function to handle all
broadcast-related logic, and removes broadcast checks from the articleForm component.
2020-09-14 11:28:18 +02:00
Ben Halpern
a1f664ab5b
Fetch GA Tracking ID from SiteConfig (#10262) 2020-09-09 18:17:44 -04:00
ludwiczakpawel
74b398d876
New Profile Header (#10185)
* init

* profile header

* merge

* two headers

* centerd

* link fix

* remove comments

* whoops

* Fix specs

Co-authored-by: rhymes <rhymes@hey.com>
2020-09-03 16:47:01 +02:00
Lisa Sy
54c071856e
[deploy] Update top-header for logged-out user (#9874)
* Create first start at desktop top header updates

* Update mobile styling of top header

* Stylize sign in widget card

* Update nav menu and top bar

* Changes based on user being logged-in or not

* Uses user_signed_in? on top nav bar

* Fix lingering old cloudinary helper method

* Trigger CI

* Fixes specs

* Adds redirect_using_referer_spec, fixes other specs & cleanup

* Adds nav-menu.scss to layouts/_styles.html.erb for inline & small edit in referer check

* Remove logged-out styles to make it more uniform with logged in

* Remove nav-menu.scss file

* cleanup markup and JS a little

* Fixes FB auth specs to new login links

* Makes sure unauthenticated /new redirects back to editor

* CI fix Sing in with -> Continue with

* Update db/schema.rb

* Update db/schema.rb

* Update db/schema.rb

Co-authored-by: Fernando Valverde <fdov88@gmail.com>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-08-31 18:12:22 -04:00
Fernando Valverde
9da71a47c7
[deploy] Introduces Runtime class for standardized & other native cleanup + replace podcast GA with ahoy (#10026) 2020-08-28 05:52:04 -06:00
ludwiczakpawel
1776377234
Improve styling for series (#9893)
* .

* flare tag line height

* .

* series switcher

* .

* revert

* editor preview fix

* Fix broken spec

Co-authored-by: Mac Siri <krairit.siri@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
2020-08-24 09:53:51 +02:00
Andy Zhao
f4b50a11b4
Check for meta payment pointer first before attempting to load (#9722) 2020-08-10 18:12:48 -04:00
Fernando Valverde
5d55299ac3
[deploy] Removes intrusive mobile video autoplay & adds ahoy for visibility (#9539)
* Removes intrusive mobile video autoplay & adds ahoy for visibility

* web video has autoplay enabled

* Implements feedback on video player ahoy events

* use strict equality
2020-07-27 13:11:40 -06:00
Alberto Pérez de Rada Fiol
e35f4a699d
Don't show badge when reading list is left empty (#9437) 2020-07-22 08:55:33 -04:00
Lisa Sy
949b092dbd
[deploy] Update broadcast styling (#9411) 2020-07-20 20:17:53 -04:00
Fernando Valverde
154a3629ee
Add Native bridge video support (#9303) 2020-07-20 11:22:32 -04:00
Pavel Tkachenko
9e94b80741
[deploy] Add local_date helper to handle dates with respect of user timezone (#9285)
* Add local_date helper to handle dates with respect of user timezone

* Fix date timezone bug for articles/show

* Fix date_helper to meet system specs requirements
2020-07-16 08:45:44 -06:00
Vaidehi Joshi
2fadc24d28
Fix TypeError: null is not an object in initializeArticleReactions.js (#9297) [deploy]
* Fix TypeError: null is not an object in initializeArticleReactions.js

Should fix https://app.honeybadger.io/fault/67192/6f9b4fdf475e2229c968fa26d785b90f

* Return 0 rather than undefined if reactionEl doesn't exist
2020-07-14 08:12:07 -07:00
Vaidehi Joshi
3391593de1
Fix TypeError: userData is null in initializeOnboardingTaskCard.js (#9298) [deploy]
* Fix TypeError: userData is null in initializeOnboardingTaskCard.js

Should fix https://app.honeybadger.io/fault/67192/65045742fda3390a067960f53a894e87.

* Combine return statements in initializeOnboardingTaskCard
2020-07-14 07:32:57 -07:00
Rembrandt Reyes
14b410cb39
Article page: edit and manage button spacing (#9230) 2020-07-10 11:54:57 -04:00
Michael Kohl
fb27f52ed0
[deploy] Display banner if site hasn't been configured (PRE DEPLOYMENT TASKS) (#8435) 2020-07-07 07:37:04 -05:00
ludwiczakpawel
30c9175f80
Tags index design update (#9072)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .

* .

* js

* little updates

* improve contrast ratio

* Remove unused id and duplicated element id

Co-authored-by: rhymes <rhymes@hey.com>
2020-07-06 11:43:58 +02:00
Yash Dave
5c1222d912
fix lint errors in initializeSwipeGestures (#8972)
Co-authored-by: Nick Taylor <nick@iamdeveloper.com
2020-07-05 14:20:49 -05:00
Nick Taylor
322628c4ef
[deploy] Fixed remaining lint issues in the frontend. (#9093) 2020-07-03 08:00:25 -05:00
Ben Halpern
4a8936a18e
[deploy] Slight fix in dropdown menu code (#9095) 2020-07-03 00:08:22 -04:00
Nick Taylor
dcc882c0c5
[deploy] Fixed the three dot menu on the article page. (#9088) 2020-07-02 21:13:26 -04:00
Ben Halpern
2a31f7b9de
[deploy] Remove report-abuse link from base HTML document into JavaScript (#9059) 2020-07-01 16:29:22 -04:00
Vaidehi Joshi
38ae790183
Do not render active announcements in iframes (#8981) [deploy]
* Do not render active announcements in mod tools

* Add a TODO around refactoring broadcast initialization

* Refactor initializeBroadcast to short-circuit on window.frameElement
2020-06-29 11:15:27 -07:00
Fernando Valverde
a7c56034a2
Fixes archived button in dashboard for PWA (#8930) 2020-06-26 11:26:12 -04:00
ludwiczakpawel
c9c88c7cc1
[deploy] Dashboard updates (#8879)
* flare tag line height

* .

* .

* .

* .

* specs

* spec

* .

* init

* .

* .

* js refactor

* js

* update spec

* Fix infinite scroll

* typo

* move IF

* pro analytics link fix

* Clean up tests

* Refactor adding of html

Co-authored-by: benhalpern <bendhalpern@gmail.com>
2020-06-25 13:10:17 -04:00
rhymes
9cdd03f0dc
Fix typo in dashboard sort element (#8875) 2020-06-24 08:03:27 -04:00
ludwiczakpawel
8c83aa3365
Table component & Dashboard update (#8778)
* flare tag line height

* .

* .

* .

* .

* specs

* spec

* .

* spec
2020-06-22 18:47:17 +02:00
Molly Struve
3d4a079572
[deploy] Refactor: Remove Additional Content Box Code (#8776) 2020-06-22 10:36:23 -05:00
ludwiczakpawel
9c471640b6
Footer redesign (#8684)
* flare tag line height

* .

* init

* moar

* user siteconfig for mascot

* .
2020-06-18 12:52:03 +02:00
ludwiczakpawel
16f4d7d46a
[deploy] Article Design update (#8234)
* flare tag line height

* .

* init

* widgets

* widgets lists

* new tabs on home

* instantclick

* .

* rethinking css

* .

* .

* empty space

* init

* campaign widget

* .

* merge

* .

* update layout

* fix sidebars on home page

* .

* fix onboarding x

* test

* spec

* test

* toolbar fix

* more

* test

* better handling ads

* .

* spec

* card border

* .

* .

* actions bar

* cleanup

* animation

* test

* button width

* .

* better responsiveness and author boxes

* meta info

* padding

* better animation

* optimize videos

* fixes

* spec

* .

* codeblocks in comments

* whoops

* Use .present? correctly as it preloads items

* sticky nav

* Update app/views/articles/_sticky_nav.html.erb

I don't know what I'm doing but @benhalpern says so! e8c0f337a5 (r440248874)

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>

* Update app/views/articles/show.html.erb

I don't know what I'm doing but @benhalpern says so! e8c0f337a5 (r440247802)

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>

* little fixes

* Update app/assets/stylesheets/article-show.scss

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>

* pawel updating ruby code......

* actually better merge

* semantic updates

* .

Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-06-17 09:57:57 -04:00
Lisa Sy
5e1fc2c4cd
Update connect chat container (part 2) (#8717) [deploy]
* Update chat container of Connect

- Rename certain class names to improve BEM syntax and naming
- Update typography of message cells
- Update header of message area
- Use new 'info' icon to expand sidebar
- Update form fields for both writing and editing a message
- Implement Crayons styling for 'delete' modal

https://github.com/thepracticaldev/dev.to/issues/8437

* Update some tests aand class names

* Update tests

* Update info icon

* Update reference
2020-06-16 15:15:59 -07:00
Ben Halpern
b51647c59a
[deploy] Remove unnecessary comment links and clean up logic (#8686)
* Remove unnecessary comment links and clean up logic

* Fix links
2020-06-15 17:40:21 -04:00
Vaidehi Joshi
38993608cf
Hide active announcements from logged-in users on the editor (#8427) [deploy] 2020-06-11 16:02:54 -07:00
Vaidehi Joshi
a3665406d5
Hide site-wide messaging for opted-out users (#8409) [deploy] 2020-06-11 11:34:04 -07:00
Vaidehi Joshi
e532ccbe42
Allow users to dismiss announcements (#8396) [deploy]
* Provide default crayon styles when creating banners

* Import crayons styles into /internal pages.
* Allow admins to use crayons banner styles when creating broadcasts.
* Preview banner styles with crayons.

* Add a "x" close button to announcements, fix styling to accommodate it

* Use constant and helper for broadcast banner styles

* Add VALID_BANNER_STYLES frozen constant to Broadcast class.
* Add banner_style helper for determining banner style class.

* Clean up preview CSS, import broadcast styles into preview

* Add close button click handler, clean up initializeBroadcast

* Add close functionality to announcement banner

Also hide announcement if the user has explicitly seen and "X"-ed out of it.

* Add system specs around rendering + dismissing broadcasts

* Add some (truly beautiful) JS documentation

* Add visible class to broadcast when previewed from internal
2020-06-11 08:24:43 -07:00
Ben Halpern
c1dca335c7
[deploy] Allow users to set a payment pointer for their content (#8304)
* Initial user payment pointer work

* Finalize functionality and tests

* Fix schema

* Update app/views/shared/_payment_pointer.html.erb

* Add function to list
2020-06-09 16:28:16 -04:00
Vaidehi Joshi
defab11a4d
Provide default crayon styles when creating banners (#8361) [deploy]
* Provide default crayon styles when creating banners

* Import crayons styles into /internal pages.
* Allow admins to use crayons banner styles when creating broadcasts.
* Preview banner styles with crayons.

* Use constant and helper for broadcast banner styles

* Add VALID_BANNER_STYLES frozen constant to Broadcast class.
* Add banner_style helper for determining banner style class.
2020-06-09 11:26:14 -07:00
icncsx
d86b9d9ce5
Replace querySelector and getElementsByTagName when selecting for head and body (#8315)
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-06-08 20:08:40 -04:00