rhymes
8b4a909aac
Rubocop fixes ( #14868 )
2021-09-30 13:22:09 -04:00
Ben Halpern
a5e8ed66ee
Fix inconsistencies with DisplayAd ( #14789 )
...
* Fix inconsistencies with DisplayAd
* Remove console log
* Fix tests
* Fix width/height being backwards
* Stub FastImage
* Update app/services/html/parser.rb
Co-authored-by: Michael Kohl <citizen428@forem.com>
* Update spec/factories/display_ads.rb
Co-authored-by: Michael Kohl <citizen428@forem.com>
* Fix display language
* Add check for img
* Change name of rotatingDisplayUnits
* Update app/helpers/display_ad_helper.rb
Co-authored-by: Michael Kohl <citizen428@forem.com>
Co-authored-by: Michael Kohl <citizen428@forem.com>
2021-09-28 09:22:07 -04:00
Mac Siri
94d2261d42
Remove #sanitize_and_decode ( #14727 )
2021-09-15 11:05:06 -04:00
Michael Kohl
1ebec4b67f
Remove hardcoded user profile fields ( #14079 )
...
* Remove duplicated work display from header
* Update work profile field handling
* Update DUS + spec
* Delegate more carefully
* Update delegation guard
* Adapt for removed delegation
* Undo accidental schema changes
* Fix seeds
* Remove accidentaly change
* Fix User#processed_website_url
* Update guard clause
* Update profile card content
* Add Organization#profile
* Be more conservative with profile fields
* Spec fixes round 1
* Fix typo
* Update spec
* Limit number of header fields and update card content
* Decorate correct model
* Update factory
* Update schema.rb
* Fix validation
* How bad could this possibly be?
* Pretty bad, nevermind
* Remove obsolete code
* Reset profile fields during test runs
* Move profile fields back to before(:suite)
* Spec fixes
* Remove accidentally re-added files
* More spec fixes
* Specs
* Change User#tag_keywords_for_search
* More spec fixes
* Add comment
* Undo accidental schema changes
* Attempt spec fix
* Remove fix attempt
* Fix e2e test
* Update spec
* Remove guard clause
* Remove hardcoded instances of education field
* WIP Access display_email_on_profile via User Settings
* Remove unused profile column
* WIP fix issues revealed by systems specs
* WIP fix issues revealed by services specs
* WIP Fix failing tests
* WIP Fix spec failures
* wip
* Move two attributes from controller to decorator
* Update comment
* More consistently use user.tag_line
Even before the profile changes we sometimes used the user.summary
attribute directly but used the user.tag_line method in other places.
* Remove education
* Add comment
* WIP
* Clean up mostly_work_with
* WIP
* Update work profile field handling
* More work-related changes
* Remove settings_only from display_area enum
* Remove quickfix from _metadata partial
* Remove special attributes
* Remove leftover spec
* Retrieve location from profile, not user
* Profile.special_attributes no longer exists
* Update specs
* More spec fixes
* Update UsersController
* Update UsersController and spec
* Fix e2e seeds
* Minor cleanup
* More e2e seed fixes
* Fix profile field CSV
* Fix e2e seeds
* Move one more attribute in e2e seeds
* Remove duplicate line
* Clear inputs before typing in them
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
2021-08-18 11:44:53 +07:00
Fernando Valverde
16ddcb74dc
Avoid showing social login options in ForemWebView ( #14260 )
...
* Minimal diff commit
* Add helper specs for display_social_login?
* Fixing some specs
* Fixing specs
* Add system specs for flow A vs flow B
* Add aria-live polite
* revert unnecessary change to spec
* Update spec/system/authentication/conditional_registration_spec.rb
Co-authored-by: rhymes <github@rhymes.dev>
* Tweaks to fix specs
* Apply review feedback
* Apply suggestions from code review
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Extract helper function + refactor Regexp from display_social_login?
* Small tweak to condition
Co-authored-by: rhymes <github@rhymes.dev>
Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-07-21 09:59:12 -06:00
dependabot[bot]
816855ce3b
Bump rubocop from 1.17.0 to 1.18.0 ( #14107 )
...
* Bump rubocop from 1.17.0 to 1.18.0
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.17.0 to 1.18.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.17.0...v1.18.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* yarn install
* Fix violations
* Restore the default aligned setting
* Trigger Travis CI
* Escape HTML
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <github@rhymes.dev>
2021-07-01 13:51:49 +02:00
Michael Kohl
7fe5c54161
Consistently use ForemInstance.private? ( #14021 )
2021-06-22 08:16:19 +07:00
Anna Buianova
26592a3a9c
Removing Settings::General.email_addresses ( #13958 )
...
* Replaced Settings::General.email_addresses with Forem.email
* Removed Settings::General.email_addresses remainders
* Fixed schema.rb
* Remove Settings::General.email_addresses record
* Fixed label for default email
2021-06-11 12:34:34 +03:00
Anna Buianova
1862eb5cde
Replacing granular admin email settings with one default email ( #13853 )
...
* Replaced granular emails with the default one
* Set reply to header in emails
* Extract shared_examples from NotifyMailer
* Removed unused code
* Replaced SiteConfig with Settings::General
* Fixes related to replacing SiteConfig with Settings
* Removed duplicate line from specs
2021-05-28 12:17:08 +03:00
Michael Kohl
6dfabd578f
Rename SiteConfig to Settings::General ( #13573 )
...
* Rename SiteConfig
* More renaming
* Update spec
* Update mandatory settings mapping
* More renaming
* e2e test fixes
* You have a rename, and you have a rename
* Spec fix
* More changes
* Temporarily disable specs
* After-merge update
* Undo rename for migration
* undo rename of DUS
* Fix DUS
* Fix merge problem
* Remove redundant DUS
* Fix specs
* Remove unused code
* Change wrong class name
* More cleanup
* Re-add missing values to constant
* Fix constant
* Fix spec
* Remove obsolete fields
* Add accidentally removed field
* Update spec
* Move methods from Settings::General to ForemInstance
* Remove unneeded model
* Change mentions of 'site config'
2021-05-21 14:45:37 +02:00
rhymes
a798bd2f7d
[15 min fix] Fallback to the image URL if Cloudinary/Imgproxy are not configured ( #13767 )
...
* Fallback to the image URL if neither Cloudinary nor Imgproxy are configured
* Fix specs
* Cloudinary api_secret is required
* Update spec/models/message_spec.rb
Co-authored-by: Michael Kohl <citizen428@dev.to>
Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-19 15:03:20 +02:00
Michael Kohl
b7ff9aadd1
Clean up SiteConfig ( #13738 )
...
* Remove obsolete SiteConfig values
* Remove DUS
* fixup! Remove obsolete SiteConfig values
* fixup! Remove obsolete SiteConfig values
* Add DUS for removing SiteConfig values
* Fix specs
* Fix specs
* Clean up more DUS
* Update DUS
* Fix remaining spec
* Remove leftover spec
* Fix more specs
* Fix spec
* Remove deprecated spec
* Rearrange specs
* Temporarily disable specs
2021-05-18 09:38:31 +07:00
arunkc
47908d7a87
Update format specifiers in readable_publish_date ( #13660 )
...
* Update format specifiers in readable_publish_date
* Trigger Travis manually
* Update format specifiers in readable_publish_date
* Update format specifiers in readable_publish_date
Co-authored-by: rhymes <rhymes@hey.com>
2021-05-07 08:51:49 +02:00
Jacob Herrington
e8df3b0915
Add safe navigation operator to stop 500 errors ( #13646 )
2021-05-04 11:37:37 -04:00
Jacob Herrington
bb9780ff3d
Remove references to social link profile fields ( #13252 )
...
* Remove references to social link profile fields
* Add some dummy data
* Remove special display social links
* Remove unnecessary tests
* Add tests for profile social icons
* PR feedback
* Remove nil check from erb
* Move view method into helper
* Don't render links in user settings
2021-05-03 10:16:02 -05:00
Michael Kohl
610f6151e6
Split Settings::Community from SiteConfig ( #13403 )
...
* Add settings_community_contents model
* Add settings_communities model
* Update usage
* Add controller and update code
* Add e2e test
* Add data update script
* Update schema.rb
* Fix specs
* PR feedback
* Remove experience_* from Settings::Community
* Update spec
* Fix spec
2021-04-26 10:46:35 +02:00
Michael Kohl
28dd50e718
Create settings model for rate limits ( #13381 )
...
Co-authored-by: rhymes <rhymes@hey.com>
2021-04-20 11:29:22 +07:00
Michael Kohl
5406b0576e
Split Settings::Authentication from SiteConfig ( #13095 )
...
* Split Settings::Authentication from SiteConfig
* Move specs
* Sort fields
* Update settings usages
* Update recaptcha usages
* Add data update script
* Update spec
* Rename SiteConfigParams concern
* Fixes, new route, new controller
* Controller and service refactoring
* More controller and service updates
* Spec updates
* More spec fixes
* Move file
* Fix FeedbackMessagesController
* Update admin/configs_spec
* Fix remaining specs in admin/configs_spec
* Fix configs API
* Formatting
* Clean up old service object
* Various fixes
* Update DUS
* Add model argument to admin_config_label
* Fix key name
* Fix specs
* Add distinct request caches for settings classes
* Fix e2e tests
* Fix remaining system spec
* Make DUS idempotent
* Move routes block
* Cleanup
* Switch to ActiveSupport::CurrentAttributes
* Pinned rails-settings-cached
* Update e2e test
* Update lib/data_update_scripts/20210316091354_move_authentication_settings.rb
Co-authored-by: rhymes <rhymes@hey.com>
* Add guard to DUS
* Temporarily re-add two SiteConfig fields
* Fix config show view
Co-authored-by: rhymes <rhymes@hey.com>
2021-04-12 09:41:09 +02:00
Julianna Tetreault
945f0bebf4
Re-Add Reporter Email Form to /admin/reports ( #13011 ) [deploy]
...
* Re-add Reporter email form and add heads up banner to admin/reports
* Adjusts spec expectations to read in a nicer way
* Pulls HEREDOCs out into constants and formats email bodys inline
- Additionally, fixes inconsistent grammar within all email bodies
2021-03-22 08:19:05 -06:00
Nick Taylor
7c1343be9e
Revert "Revert "Removed service worker ( #12974 )" ( #13014 )" ( #13015 )
...
This reverts commit 2416387fb4
2021-03-17 10:57:56 -04:00
Molly Struve
2416387fb4
Revert "Removed service worker ( #12974 )" ( #13014 )
...
This reverts commit 4fb6230606
2021-03-16 18:10:01 -05:00
Nick Taylor
4fb6230606
Removed service worker ( #12974 )
2021-03-16 15:55:31 -04:00
Vaidehi Joshi
7e583be9ed
[15 Minute Fix]: Update email footer copy to account for email authentication ( #12877 )
...
* Update email footer copy to account for email authentication
Fixes https://github.com/forem/forem/issues/12546 .
2021-03-03 08:36:40 -08:00
Anna Buianova
c5c0c4a8b5
Remove old code for feedback messages email to the reporter ( #12567 )
2021-02-06 10:03:38 +03:00
Fernando Valverde
88bd3a1069
Replace authentication_enabled_providers.include? with helper method ( #12379 )
...
* Replaces authentication_enabled_providers.include? with helper authentication_provider_enabled?
* Fix typo
2021-01-22 07:54:10 -06:00
Ridhwana
65d439e70d
Attempt to fix random test failures when dealing with the ForemInstance class ( #12294 )
...
* fix: set the deployed at to nil
* chore: make sure the heroku env is also set to empty
* Sprinkle more after block
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2021-01-15 19:44:18 +02:00
Arit Amana
3a984c8ee7
[2020 EOY Issue] Modal alert when enabling Auth Provider without keys ( #12135 )
...
* Start hooking things up
* further generalize adminModal, hook up relevant code
* Complete implementation
* remove comments
* Address QA suggestions
* Address QA suggestions
* Use object parameter for adminModal
* starting the admin cypress tests
* Code review suggestions
* remove incomplete test
* rename data attributes to make more sense
* complete the work
* use destructuring
* edit warning modal text
2021-01-13 13:54:39 -05:00
Alex
b168e1529f
Move HexComparer to Hex::Comparer service ( #12202 )
...
* Move HexComparere to Hex::Comparer service
* Create USER_COLORS constant and constant specs
* Move formats to constants
* Rename Hex::Comparer to Color::CompareHex
2021-01-12 11:34:30 -05:00
Ridhwana
ebfe0ead2d
Add application deployment information to the admin page ( #12149 )
...
* WIP: release footprint in the admin UI
* feat: show the commit ID and the date
* chore: change env optional to empty string
* fix: change the FOREM_BUILD_DATE to RELEASE_FOOTPRINT
* feat: add Not Available as a last option
* test: last deployed time and latest commit id
* feat: update the way we change the env variable!
* fix: we need to set the RELEASE FOOTPRINT so that this clause is not hit - `return path if release_footprint.blank?`
2021-01-08 16:36:12 +02:00
Julianna Tetreault
ca6ba1af7d
Replace collective_noun with community_name ( #11846 ) [deploy]
...
* Removes collective_noun and collective_noun_disabled from app
* Config Generalization: replaces community_qualified_name with community_name
- Generalizes SiteConfig after the removal of collective_noun field
- Updates copy where necessary to be readable with community_name
- Makes the community_name SiteConfig description more explicit
- Adds flexibility for Admins by removing appended "community"
* Adds a data_update script to remove collective_noun and collective_noun_disabled
* Removes appended community from stories_controller.rb
* Removes unnecessary quotation marks around SiteConfig.community_name.to_s
* Makes SiteConfig community_name description more explicit
* Removes topic from #email_from and replaces arg with _
* Removes argument from #email_from (facepalm)
* Reverts changes to application_mailer and notify_mailer_spec
* Removes default "Community" topic from application_mailer and makes topic optional
* Refactors #prepopulate_new_form to resolve Code Climate failures
* Refactors #email_from even further by use of a ternary operator per review suggestion
* Simplifies the data_update script used to remove collective_noun per review request
* Adds a data_update script to append community to community_name
* Updates data_update script to correctly append Community to community_name
* Removes RemoveCollectiveNounFromConfig and updates other script
* Removes superfluous false from data_update script
* Updates data_update script to be more idiomatic
2020-12-28 09:34:17 -07:00
Arit Amana
42e10e7b42
[EOY2020 Issue] Default new forems to Email Authentication only ( #11696 )
...
* Set default Auth Providers to empty array
* complete implementation; tests remain
* tests
* fix failing specs authenticator_spec.rb
* Fix failing specs
* fix more failing specs
* fix more failing specs 2
* update failing spec
* Update app/views/admin/configs/_auth_provider_settings.html.erb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/assets/stylesheets/admin.scss
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-12-02 16:49:07 -05:00
Fernando Valverde
494af84e83
Refactor reCaptcha code and bypass in report abuse for trustworthy users only ( #10502 )
...
* Bypass recaptcha for authenticated users abuse reports
* Moves bypass_recaptcha? to helper method to have one definition of the criteria for this
* User must be 1 month old at least in order to bypass_recaptcha?
* Fixes test
* Better spec message
* Bypasses auditable users
* Adds better test coverage over recaptcha bypass cases
* include Helper removed from FeedbackMessagesController
* Adds some inline comments for clarity and banned check
2020-12-02 08:55:47 -06:00
Michael Kohl
195e228307
Move GeneratedImage to Images::GenerateSocialmage ( #11691 )
2020-12-02 11:03:14 +07:00
Michael Kohl
2939813168
Move app/labor/reaction_image.rb to helper ( #11678 )
2020-12-01 14:15:30 +07:00
rhymes
68b320a1de
Add contact email to SiteConfig and replace default where appropriate ( #11630 )
...
* Add a new contact email to use in place of default
* Replace :default with :contact email in all non transactional emails
* Add missing expectation
2020-11-27 16:39:38 +01:00
Josh Puetz
2223e5468b
Email login always on ( #11307 )
...
* Starting out
* Building away...
* Hooking buttons up
* Hook Auth Provider buttons to Array Field
* trying to fix NoNameError
* Remains InviteOnlyMode disable and tests
* Smashing remaining tasks
* Last of tasks
* add tests
* Complete specs and tests 😅
* Fix bug
* Additional guard
* pass event to functions
* Position Email Auth first
* Fix bug in Email Auth Modal
* Fix spacing issue
* Update docs for adminModal.js
* Show/hide Enabled Indicator with Enable/Undo buttons
* Complete Auth Providers functionality
* Only update `allow_email_password_registration` from admin
* Remove duplicated methods
* Some refactoring around fact that Email Login is now always on (#11382 )
* Fix merge (again!)
Co-authored-by: Arit Amana <msarit@gmail.com>
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
2020-11-12 09:32:58 -06:00
rhymes
1bb53651b0
Replace calls to Flipper with FeatureFlag ( #11386 )
2020-11-12 14:15:33 +01:00
Arit Amana
08796b5cee
[Team Email Login] Refactor Authentication Provider Enable/Disable ( #11185 )
...
* Starting out
* Building away...
* Hooking buttons up
* Hook Auth Provider buttons to Array Field
* trying to fix NoNameError
* Remains InviteOnlyMode disable and tests
* Smashing remaining tasks
* Last of tasks
* add tests
* Complete specs and tests 😅
* Fix bug
* Additional guard
* pass event to functions
* Position Email Auth first
* Fix bug in Email Auth Modal
* Fix spacing issue
* Update docs for adminModal.js
* Show/hide Enabled Indicator with Enable/Undo buttons
* Complete Auth Providers functionality
* Update app/javascript/admin/controllers/config_controller.js
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/javascript/admin/controllers/config_controller.js
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/controllers/admin/configs_controller.rb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update helper names
* better implementation of EnabledIndicator show/hide
* Small copy changes
* Update spec/helpers/authentication_helper_spec.rb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/views/admin/configs/show.html.erb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/helpers/authentication_helper.rb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-11-06 18:19:34 -05:00
Mac Siri
16c3ccb955
Replace SimpleIDN usage with Addressable ( #11238 )
2020-11-03 08:55:31 -05:00
Jacob Herrington
d479834344
Do not set SiteConfig values in specs ( #11125 )
2020-10-27 15:56:31 -04:00
Jacob Herrington
c91c07920f
Add config option for Forem collective noun ( #11107 )
...
Not everyone will want to use "Community" to describe their Forem, so
now they have some flexibility there.
2020-10-27 12:45:52 -04:00
Ben Halpern
5457f0c0b7
[deploy] Bust caches when navigation links are changed ( #10865 )
...
* Bust caches when navigation links are changed
* Remove extra line
* Add admin_action_taken_at to SiteConfig to reference later
* Format timestamp with rfc3339 and fix Specs
Co-authored-by: mstruve <mollylbs@gmail.com>
2020-10-21 21:30:31 -04:00
Lisa Sy
a64b85ff5e
Update [Rate Limit] form fields with crayons and add TITLE ( #10858 ) [deploy]
...
* Update form fields with crayons and add TITLE
* Fix merge conflicts and merge w master
2020-10-21 12:43:01 -07:00
Arit Amana
8e57cf17ad
[Team Email Login] Admin enable/disable recaptcha during email signup ( #10846 )
...
* Initial Implementation
* Complete hookup of recaptcha guard
* Write tests for recaptcha during email signup
* Addressing PR changes 1
* Create helper method and write specs
* fix bug
2020-10-19 16:20:18 -04:00
Jacob Herrington
c53522a8a8
Remove random onboarding background images ( #10683 )
...
* Fix misleading alt tags
* Make random fallback images optional
2020-10-07 10:19:18 -04:00
Ben Halpern
3a469a99e2
[deploy] Enable admin-configured app_domain ( #10206 )
...
* Move app_domain from env var to siteconfig *within app area*
* Fix SiteConfig
* Don't change URL.domain yet
* Not use in fastly cache purge yet
* Session store magoo
* Revert domain issue
* Add SetCookie middleware
* Temporarily remove cookie middleware and release tasks
* Re-enable SetCookieDomain
* Add some more comments, get it ready for testing
* Remove host from url options and temporarily show errors
* Allow forwarded host to be cookie
* Fix typo
* Change invalidAuthenticityToken
* Properly set app domain
* Proper Fastly cache
* Remove config.app_domain
* Remove config.app_domain
* Explicitely set remember_user_token
* More play with cookies
* Fiddle with remember_user_token
* Add remember_user_token changes
* Monkeypatch devise
* Sessions controller
* Include rememberable
* Include rememberable
* Proper cookie monkeypatch
* Proper cookie monkeypatch
* Proper cookie monkeypatch
* Remove extra cookie code
* User sign in tweak
* Close the loop
* Experiment with carrierwave public_url
* Finalize carrierwave monkeypatch
* Remove async controller specs
* Change some tests
* Update domain test
* Remove temporary production.rb change
* modify cookie logic
* Remove unneeded changes
* Remove unneeded changes
* Explicitely pass host
* Fix linting
* Fix social image test
* Add some cookie tests
* Modify article url
* Fix canonical urls
* Fix typo
* Remove sessions controller
* Remove devise monkeypatch
* Add monkeypatch
* Remove elsif
* Update spec/helpers/application_helper_spec.rb
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Adjust remember_cookie_sync
* Remember user token experimentation
* Fiddle with devise
* Properly configure devise
* Fix typo
* Fix formatting issue
* Add comment about middleware
* Fix typo
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Remove commented-out code
Co-authored-by: Michael Kohl <citizen428@dev.to>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-09-11 09:38:34 -04:00
Ben Halpern
310df39e27
Include locale in fragment cache key ( #10199 )
...
* Include locale in fragment cache key
* Adjust specs
2020-09-09 16:58:04 -04:00
Ben Halpern
45fb6504dc
[deploy] Replace HEROKU_SLUG_COMMIT with custom footprint (naive) ( #9904 )
...
* Replace HEROKU_SLUG_COMMIT with custom footprint (naive)
* Fully set RELEASE_FOOTPRINT with the expectation of setting it before launch
* Change tests
* Fix cache
2020-08-25 13:47:14 -04:00
rhymes
eddcb4953e
Display all authentication providers in mailer footer ( #9961 )
...
* Display all authentication providers in mailer footer
* Refactor into Authentication::Providers.enabled_for_user
2020-08-24 21:02:05 +02:00
Mac Siri
76de9a0317
[deploy] Replace #cloudinary with #optimized_image_url ( #9876 )
2020-08-21 14:46:00 -04:00
