Commit graph

3884 commits

Author SHA1 Message Date
rhymes
ba82e72aa4
Fix Rails/OutputSafety violations (#9244) 2020-07-11 11:36:24 +02:00
rhymes
101cca4a68
Rubocop: fix Performance/OpenStruct (#9241)
* Fix Performance/OpenStruct in Article and Organization

* Fix Performance/OpenStruct in Notifications::Reactions::Send

* Add missing rubocop disable for Performance/OpenStruct

* Fix serialization
2020-07-11 10:13:18 +02:00
Mac Siri
f6e2b4e034
[deploy] Update RssReader::Assembler#get_content hash syntax (#9255) 2020-07-10 16:45:39 -04:00
rhymes
8126c5c2c1
Rubocop: Address Metrics/BlockLength violations (#9246)
* Address Metrics/BlockLength violations

* Add jbuilder to package auto correct
2020-07-10 13:53:32 -04:00
Rembrandt Reyes
14b410cb39
Article page: edit and manage button spacing (#9230) 2020-07-10 11:54:57 -04:00
Brunno Souza
b5de27f1a6
Refactoring comments_controller#create reducing lines (#9162) 2020-07-10 17:24:36 +02:00
Ben Halpern
879e0ae1c8
Remove arrow-left-... from github issue embed (#9236) 2020-07-10 10:17:50 -04:00
Alex
3b1c813db7
[deploy] Revert "Add number_with_delimiter to post count (#9225)" (#9242)
This reverts commit 47b363bed7.
2020-07-10 09:45:35 -04:00
rhymes
3722355e8c
Rubocop: fix Metrics/CyclomaticComplexity and disable Metrics/AbcSize (#9221)
* Fix Metrics/CyclomaticComplexity

* Disable Metrics/AbcSize

* Refactored Articles::Builder a bit
2020-07-10 15:26:05 +02:00
Vaidehi Joshi
35b516a60d
Add metrics around welcome notifications + their click events (#9239)
* Log to DataDog when a welcome notification is created

* Fix typo in Metrics::RecordDailyUsageWorker

* Add Metrics::RecordDailyNotificationsWorker to log notification counts to DataDog

* Add specs around DataDog logging for welcome notifications + click events

* Call Metrics::RecordDailyNotificationsWorker from within log_daily_usage_measurables task

* Use user_id instead of user, move notification title into tags
2020-07-10 12:30:45 +02:00
rhymes
b3060bc475
Fix Style/SingleLineBlockParams, RSpec/MultipleExpectations and remaining Layout/LineLength (#9204)
* Fix Style/SingleLineBlockParams

* Fix RSpec/MultipleExpectations and Layout/LineLength

* Restore test to previous version for speed

* Remove useless params
2020-07-10 11:23:02 +02:00
Molly Struve
0a51540a4c
[deploy] Hotfix: Disable Article Sinking (#9237) 2020-07-09 17:19:06 -05:00
bravemaster619
7fb7b179d9
[deploy] Add markdown version for DEV badge link (#9227) 2020-07-09 17:34:03 -04:00
Alex
47b363bed7
[deploy] Add number_with_delimiter to post count (#9225) 2020-07-09 15:55:11 -04:00
Mac Siri
aa8e6e29ab
[deploy] Log instantClick errors (#9226) 2020-07-09 14:32:22 -04:00
Molly Struve
6cfbbaeb39
[deploy] Refactor:Send a Couple More Errors to Honeybadger (#9223) 2020-07-09 10:53:16 -05:00
Molly Struve
fad259b1c8
[deploy] Bug Fix: Remove Rails Validation for Follow Uniqueness, Guard against dup Follow Jobs (#9222) 2020-07-09 09:50:06 -05:00
rhymes
ffc96db209
Rubocop: fix additional violations in todo file (#9218) 2020-07-09 10:25:44 -04:00
Ridhwana
f37ffc0be9
[deploy] Replace hardcoded logo with secondary logo config (#9219)
* chore: replace the logo with secondary logo

* update the html classes
2020-07-09 09:58:28 -04:00
Molly Struve
074fe8626d
Refactor: Report Pusher Errors to Honeybadger, Remove Comment Error Logging (#9208) 2020-07-09 08:49:48 +02:00
Molly Struve
e03f337c9c
Refactor: Send RSS Reader and Payment Errors to Honeybadger (#9209)
* Refactor: Send RSS Reader and Payment Errors to Honeybadger

* remove old VCR cassettes
2020-07-09 08:48:52 +02:00
Ridhwana
6029948c1a
[deploy] Make the mobile Navigation icons configurable (#9056)
* chore: make the icons dynamic from site config

* feat: update the navbar icons

* feat: update the descriptions

* chore: update the icons

* chore: update the names to be more reflective

* chore: freeze  mutable objects assigned to constants

* chore: update Line is too long.

* icons

* update lightning icon

* chore: read from file

* path here is relative, so use Rails root

* revert to original icons and run svgo on it

* no newline

* feat: update height, width
2020-07-08 20:09:48 +02:00
Alex
bac350e877
[deploy] Add role and docs for user subscription liquid tag (#9170)
* Create new restriced_liquid_tag role

* Update role spec

* Use new role over admin

* Add documentation for user_subscription_liquid_tag

* Stub roles to help avoid flaky specs

* Add user approved liquid tags to edit view

* Remove "simply". Coding is hard, yo!

* Update liquid_help

* Update liquid help

* Update and refactor dashboard specs

* Refactor role check for liquid tag docs

* Improve docs wording
2020-07-08 14:07:53 -04:00
Molly Struve
d7f17c71ba
[deploy] Refactor: Remove Unnecessary logging from Video States, Stripe, and GA Events (#9207) 2020-07-08 11:59:31 -05:00
Molly Struve
5fcb788561
[deploy] Refactor: Remove Omniauth Error Logs, Send to Honeybadger (#9205) 2020-07-08 11:21:57 -05:00
Ben Halpern
b3f97f95e5
[deploy] Remove unnecessary ?url= param from report-abuse (#9203) 2020-07-08 10:50:21 -04:00
rhymes
5b62811c98
[deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
Alex
9f9236164c
[deploy] Add subscriptions to the dashboard (#9161)
* Add /dashboard/subscriptions route

* Dashboard controller updates

* Update ArticlePolicy with subscriptions?

* Update article row view in dashboard

* Add subscriptions view

* Add specs

* Add comment for pagination limit

* Use cached user_subscriptions count

* Add spec for cache counter

* Add path helper
2020-07-08 08:31:03 -04:00
Ben Halpern
7bb194b305
[deploy] Remove /rly code (#9192) 2020-07-08 07:55:33 -04:00
Mac Siri
f63d9a32bb
Ignore MetaMask errors on Honeybadger (#9190) 2020-07-08 12:35:43 +02:00
Alex
c8081294eb
[deploy] Only run JS on appropriate Articles (#9191) 2020-07-07 21:10:14 -04:00
Alex
ab56a1eb85
[deploy] Fix sign in flow (#9182) 2020-07-07 12:32:15 -04:00
ludwiczakpawel
9ee54bfe45
[deploy] Add crayons to pages (#9175)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .

* .
2020-07-07 09:43:54 -04:00
Michael Kohl
fb27f52ed0
[deploy] Display banner if site hasn't been configured (PRE DEPLOYMENT TASKS) (#8435) 2020-07-07 07:37:04 -05:00
ludwiczakpawel
e67df7e94d
Fix action icons in dark themes (#9177)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .
2020-07-07 14:07:47 +02:00
ludwiczakpawel
317d844b18
Indicator placement in Navigation (#9178)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* indicator placement
2020-07-07 14:07:11 +02:00
ludwiczakpawel
01f4183204
Code highlighter fix (#9176)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .

* typo

* .
2020-07-07 09:54:24 +02:00
Mac Siri
16d57a30a9
[deploy] Resoucify Page and Badge models (#9083)
* Resourcify Badge

* Resourcify Page
2020-07-06 17:17:25 -04:00
Molly Struve
66cc182fa3
Bug Fix: Prevent Duplicate Follow Attempts by Preventing Multiple Workers (#9169) 2020-07-06 16:15:39 -04:00
Brunno Souza
a5e821846a
Refactoring articles_controller reduce lines (#9166) 2020-07-06 15:50:16 -04:00
Nick Taylor
6542395b38
Upgraded to preact testing library 2.0.0 (#9103) 2020-07-06 14:53:10 -04:00
rhymes
8afc9bb0c3
[deploy] Add unique indexes to follows - part 7 (#8215) 2020-07-06 11:15:56 -05:00
Ben Halpern
f2890f7757
[deploy] Remove unnecessary fragment cache (#9159) 2020-07-06 09:26:55 -04:00
Alex
f86b8a55a4
[deploy] UserSubscription liquid tag update & re-enable JS (#9082) 2020-07-06 08:26:40 -05:00
Alex
9af9a489e5
[deploy] Cleanup existing liquid tags (#9085)
* Replace tokens with parse_context

* Underscore unused args and ensure super is called

* Cleanup GitHub tag
2020-07-06 09:17:27 -04:00
ludwiczakpawel
30c9175f80
Tags index design update (#9072)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* .

* .

* js

* little updates

* improve contrast ratio

* Remove unused id and duplicated element id

Co-authored-by: rhymes <rhymes@hey.com>
2020-07-06 11:43:58 +02:00
Thomas Bnt
6d96df538c
Delete box-shadow to .github-repos (#9120) 2020-07-06 10:12:07 +02:00
Nick Taylor
7f3217f156
Sass loader 9.0.1 upgrade (#9146)
* Bump sass-loader from 8.0.2 to 9.0.1

* Fixed breaking changes related to sass-loader@9.0.1
2020-07-06 09:40:53 +02:00
rhymes
683f45d1e7
[deploy] Fix pro link for organization users (#9144)
* Fix pro link for org users

* Remove useless empty line
2020-07-05 18:17:03 -04:00
Sarthak Sharma
3e1ab98b3c
🐞 Hotfix: Sidecar's Design issues on Small screens (#9113)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* Merge conflict resolved

* Hotfix🐞: Sidecar Design issue in Mobile

Co-authored-by: Narender Singh <narender2031@gmail.com>
2020-07-05 17:31:40 -04:00