Commit graph

1768 commits

Author SHA1 Message Date
Ben Halpern
0432da190f
Tweak black box so posts won't stick (#3312) 2019-06-26 10:15:07 -04:00
Mario See
4e75108d8b Fix escape key handling and add space in single listing view (#3306)
* add space and handle escape key down

* properly handle escape
2019-06-26 09:58:48 -04:00
Bolarinwa Balogun
dbc4abc587 Add rel="nofollow" to links in comments (#3304)
* Add rel="nofollow" to links in comments

* Improve code quality and Add tests
2019-06-26 09:02:11 -04:00
Bolarinwa Balogun
b52d8e931d Add Instagram URL to profile links (#3307) 2019-06-26 08:56:07 -04:00
Bolarinwa Balogun
a30e06d673 Allow Embed of specific gist version (#3310)
* Allow Embed of specific gist version

* Add tests and documentation
2019-06-26 08:54:26 -04:00
rhymes
7da7a16d8d Pro: add referrers to dashboard and single article stats (#3295)
* Reorganize PageViewsController

* Add domain and path to PageView model

* Add before_create callback to populate domain and path

* Add list of referrers to AnalyticsService

* Add referrers to the UI

* Remove useless referrers card and tweak table line height

* Add referrer stats to article stats page

* Add not null and empty default to domain and path

* Refactor JS analytics client

* create_list is a step back here

* Revert "Add not null and empty default to domain and path"

This reverts commit bc02440076047a887c65d300bccd4661ecc8ffd0.

* Add index on domain concurrently

* Make the script more robust
2019-06-25 13:58:09 -04:00
Andy Zhao
16b59db15c Use publish date for article notifications (#3301) 2019-06-25 11:54:33 -04:00
Sushant Bajracharya
108a961324 Use dynamic route name for sign up (#3147) [ci skip] 2019-06-25 10:01:28 -04:00
Bolarinwa Balogun
bc54f30365 Add Item Count to Reading List Header (#3162) 2019-06-25 09:41:28 -04:00
Mike Coutermarsh
8afb797ec9 Improve social card caching 🚀 (#3265)
* Add failing tests for social previews controller. HTML changes between
requests, which breaks caching.

Since we use the HTML to generate the cache key. When the views have any
randomness in them, it breaks the cache, which means we regenerate
images on each request, rather than using what's in memcached.

Adding test to protect from regressions

* Fix randomness in social card templates

The aria tags are randomly generated. Since this is for rendering
images, they aren't needed.

* Make the linter happy by using the sanitize helper
2019-06-25 08:45:30 -04:00
rhymes
e3c2bf08e6 Deduplicate history items (#3279) 2019-06-25 08:42:01 -04:00
Eduardo Alencar
6d800da4d4 Increase tag length from 20 to 30 chars (#3299)
This commit increases the tag length from 20 to 30 chars and also increases the cached_tag_list length to maintain the limit of 4 tags. Specs were adapted to respect the changes.
2019-06-24 16:43:21 -04:00
Ben Halpern
dcbb188cf1
Add pinned articles box to profiles (#3269)
* Initial pins work

* Add pin box to profiles

* Fix test snapshot spacing and optimize svg

* Fix listings spacing
2019-06-24 15:18:29 -04:00
cyrillefr
0267d4e829 Move bust_cache methods in own jobs (#3071) 2019-06-24 13:28:25 -04:00
rhymes
808b8f285c Comments: remove double stripping undoing escaping (#3270) 2019-06-24 12:00:36 -04:00
Andy Zhao
a265ab6b90 Return original body instead of nil for new comment push notifications (#3273) 2019-06-24 08:33:35 -04:00
Ben Halpern
d48ad63aea
Add comment context for notifications and comment pages (#3262)
* Add comment context for notifications and comment pages

* Fix comment spec and adjust css
2019-06-22 14:50:15 -04:00
Anna Buianova
bfa1bdc37f More specs and refactoring podcasts fetching (#3245)
* More specs and refactoring podcasts fetching

* Fixed PodcastFeed references in tests

* Pass podcast_id instead of podcast to CreateEpisode
2019-06-21 21:31:15 -04:00
rhymes
91de529705 Remove code for legacy mentoring feature (#3186) 2019-06-21 17:18:11 -04:00
Anna Buianova
f79b3cb12a Fixed rubocop issues, new .rubocop_todo.yml (#3255)
* Fixed rubocop issues, new .rubocop_todo.yml

* Refined and fixed indentation
2019-06-21 14:26:39 -04:00
Andy Zhao
cf8b4e37d3 Add context data to comment notifications (#3258)
* Add db relationship for comment and notifications

* Use delete instead of destroy

* Add comment's ancestors' data

* Delete descendant notification data appropriately

* Update notifications for comments up the tree as well

* Update descendant notifications appropriately

* Fix apostrophe edge case

* Make ancestor_data method private
2019-06-21 14:26:19 -04:00
Ben Halpern
e46bd26223
Fix logic and adjust copy for tag rewarding (#3251)
* Fix logic and adjust copy for tag rewarding

* Check for whether published
2019-06-20 20:28:33 -04:00
cyrillefr
cf3f997c98 Move HtmlVariantTrial.create delay calls to ActiveJob (#3173) (#3239) 2019-06-20 18:14:20 -04:00
Andy Zhao
4ca7197696 Delete a comment's title if it is deleted (#3249)
* Remove cursor pointer for notification cards

* Delete the comment title if deleted

* Update title to use comment's title
2019-06-20 15:48:21 -04:00
Mac Siri
8ec4e338ed Update RssReader's liquid & youtube parsing logic (#3229)
* Loosen up Liquid::Variable

* Improve RssReader's youtube id detection

* Revert "Loosen up Liquid::Variable"

This reverts commit fd385c6649a9e0ca3786588a29a3ff2b8fe98218.

* RSS: Wrap liquid variable in backtick

* User inner_html intead of text
2019-06-20 15:26:39 -04:00
Thanawat Senawat
6fc17a29cb Feature/reading list loadmore button (#3221)
* Add Load More Button to Reading List

* Set state showLoadMoreButton is false
2019-06-20 13:33:02 -04:00
Jess Lee
f00c28adf0 Update internal's listings buffer text (#3247) 2019-06-20 13:18:00 -04:00
Andy Zhao
1e61634499 Add backend functionality for muting users you follow (#3240)
* Add backend func. for muting users you follow

* Remove comment

* Add validations and update default value

* Send notifications to followers with all_articles
2019-06-20 11:28:50 -04:00
Mario See
abbc3e85d6 Manage listings as organization admin (#3228)
* adjust validations to allow org admins to edit listings

also adjusted presented elements based on bumped_at dates and published boolean status

* allow org admins to edit listings under diff user_id

adjust statement in edit so that it has to be admin not just member

* pluck via attribute not string of attribute name

* update policy for org admins

* make authorizing org admin for listing private

* update classified listing spec

user_id is required for classified listing
2019-06-20 09:39:54 -04:00
Jess Lee
464d37310e add buffered checkbox to individual articles (#3238) 2019-06-20 09:34:03 -04:00
Jess Lee
f4097714af Add missing Dev Listing logo (#3237) 2019-06-19 18:52:57 -04:00
rhymes
d74aa46bc5 Add article pro stats button in dashboard (#3230) 2019-06-19 10:13:18 -04:00
Ben Halpern
d2a78f051f
Remove hardcoded image from chat channel images (#3235) 2019-06-19 10:12:58 -04:00
rhymes
55634ad68f Display stats for organization article (#3232)
There was a bug where the frontend was not passing the organization id to the backend, and thus the fetching of the stats failed for organization articles.

This also adds a bit of error handling for `fetch` API
2019-06-19 09:17:35 -04:00
rhymes
6ce6b265df Fixed a couple of queries (#3233) 2019-06-19 09:17:03 -04:00
cyrillefr
c413cf8235 Move HtmlVariantSuccess.create delay calls to ActiveJob (#3173)
- add AJ job + job spec
  - refactor call
2019-06-18 21:36:33 -04:00
Anna Buianova
a3e246a327 Fix mention validation when validating an empty instance (#3188)
* Fix mention validation when validating an empty instance

* Fix NotifyMailer spec
2019-06-18 21:36:01 -04:00
Mazen Touati
b284c1e9df Allow stackoverflow subcommunities profiles (#3215) 2019-06-18 21:35:16 -04:00
Anna Buianova
24328417ab Don't try to register webhook when twitch returns empty data (#3219) 2019-06-18 21:34:06 -04:00
rhymes
2bf54edb9c Pro: History (#3220)
* Add base history support

* Add tags and ranking and make it work

* Fix styling

* Add article title and text excerpt to the index

* Add pagination support

* Debounce the search to 300ms

* Show history only to pro users

* Use routing helpers instead of hardcoding

* Raise the page size to 100

* Remove console log

* A bit of regrouping
2019-06-18 14:58:24 -04:00
Mario See
9e616de9f8 Listings Dashboard (#3014)
* init wip react components

* wip add dashboard to listing views

- create a html.erb view to hold listing/dashboard with javascript_pack_tag
- create listingDashboard.jsx in packs
- create listingDashboard component and dashboard folder with smaller components
- added view to controller and routes

* slowly adding some formatting

adjusted styling, info

* remove listing body from dashboard

* add some styling and adjust info

* wip adding org listings

* wip multi org in dashboard

* adjust for multi org

* add styling and better multi org support

* comment out bump and delete -- save for upcoming PR

* reduce lines

* listing form has link to listings dashboard instead of listings

* adjust header boxes flex direction for mobile

* fix organization id query

* WIP testing

needs more rigorous tests

* finalize tests
2019-06-18 14:52:59 -04:00
Anna Buianova
bd3125bcfd Update slack channel name (#3218) 2019-06-18 14:47:53 -04:00
Clara
351c1425bd Changed timestamp to creation of notifiable instead of notification itself (#3076) 2019-06-17 18:26:44 -04:00
briwa
deb83f71a8 fix(article): <hr> should be visible in night theme (#3202) 2019-06-17 14:54:53 -04:00
Ben Halpern
d55a392bed
Add organization liquid tag (#3203) 2019-06-17 13:47:42 -04:00
Tyler VanBlargan
f05cdd3b72 Add Date to Link Liquid Tag (#3126) [ci ski] 2019-06-17 12:14:39 -04:00
rhymes
f9fb76ec97 Remove double presence validator in PollVote (#3187) [ci skip] 2019-06-17 10:28:05 -04:00
Ben Halpern
13bfdf2b64
Add minimal light theme (#3179) 2019-06-16 01:37:34 -04:00
Ben Halpern
456931f208
Further generalize pages and site Twitter handle (#3177)
* Further generalize pages and site Twitter handle

* Add footer mod change

* Remove giveaways dead code
2019-06-16 00:59:11 -04:00
Ben Halpern
8ae057b06e
Beta polls feature (admin use only for now) (#3176)
* Initial poll features

* Add basic poll functionality

* Finish (maybe) beta poll functionality
2019-06-15 17:33:30 -04:00