Commit graph

1768 commits

Author SHA1 Message Date
Mario See
fc318acd97 allow codesandbox to accept runonclick (#2381)
* allow codesandbox to accept runonclick

- runonclick=1 lets the user load the codesandbox when they decide
- added runonclick tests to spec

* documentation to editor_guide
2019-04-13 15:53:28 -04:00
Ben Halpern
dec44cd34e
Move themes config into separate partial and add logo theme-ability (#2427)
* Remove honeycomb code from config.ru

* Modify pink theme and minor other theme adjustments

* Fix schema
2019-04-13 13:11:18 -04:00
Ali Spittel
409c280c10 pinkify DEV (#2425) 2019-04-13 11:25:02 -04:00
Desi Rottman
92eab3aa49 Fix grammar error in "thumbsdown" description (#2391) [ci skip] 2019-04-12 11:49:44 -04:00
Tim Lange
6daec136bf UX: Fix draft in nightmode (#2382) 2019-04-12 10:30:42 -04:00
Ben Halpern
a0b205330c
Add fragment cache to tag page (#2403)
* Add fragment cache to tag page

* Add whether user is logged in to cache key
2019-04-12 01:29:49 -04:00
Ben Halpern
9578a15579
Remove unnecessary map functions in stories controller (#2402) 2019-04-12 01:10:08 -04:00
Ben Halpern
c68228cda6
Add sidebar condition for homepage cache (#2404) 2019-04-12 01:06:41 -04:00
Ben Halpern
8c740b77ac
Add additional fragment caching to home page (#2401) 2019-04-12 00:42:28 -04:00
rhymes
0d24dee4f0 Use touch a little bit less (#2395) 2019-04-11 23:43:54 -04:00
yasmeen roumie
c373a6a2e9 Fix typos (#2396) 2019-04-11 22:12:18 -04:00
Brandon Lyons
bab2b8bcfe Fixed spacing typo (#2388) [ci-skip] 2019-04-11 17:49:01 -04:00
Alissa
4eadd21854 Update community moderation copy [ci skip] 2019-04-11 17:41:38 -04:00
Andy Zhao
d1241d3c16 Touch profile_updated_at when updating social usernames (#2386)
* Use better description for test

* Test for new profile_updated_at touches

* Touch profile_updated_at when removing an auth

* Touch profile_updated_at when authing w/ new social username
2019-04-11 16:32:45 -04:00
Kushagra Gour
8f03f87087 settings.scss: Fix color contrast in text colors (#2372)
The text colour of the alert messages was failing the accessible colour contrast requirement of 4.5:1.
2019-04-11 16:32:06 -04:00
Tim Lange
e3aefb7b18 UX: Fixed no results found in nightmode (#2384) 2019-04-11 16:30:33 -04:00
Tim Lange
696b90ec32 UX: Fixed figcaption in nightmode (#2383) 2019-04-11 16:30:13 -04:00
Jess Lee
6629404ad9 Community Moderation Page (#2364)
* add more copy about bulk updating

* add the new file whooops
2019-04-11 15:40:35 -04:00
rhymes
5782ffd7e0 Use published scope for articles (#2374)
* Use published scope for articles

* Fix variable name

* The sequencing in the union query matters

* Fix spec

* Restore a published: true condition

* This test is actually misleading due to the union

* Revert this change, not sure why it's not a relation

* Fix useless diff
2019-04-11 13:18:26 -04:00
rhymes
a09bf20503 Remove unused attr_reader (#2376) [ci skip] 2019-04-11 12:47:15 -04:00
Andy Zhao
8ef611f879 Remove Honeycomb from the app (#2366)
* Remove Honeycomb related gems

* Remove Honeycomb related code from controllers

* Remove Honeycomb from RSS Reader

* Remove Honeycomb related files

* Remove Honeycomb related tests

* Remove leftover Honeycomb methods
2019-04-11 10:49:35 -04:00
Jess Lee
f637d9e02b Manage tag and community mod lists in Mailchimp (#2362)
* add moderation email list columns

* automate tag moderator mailing list

* reorder logic for tag mod list

* add community mod list

* remove trusted privileges when reverting a user to a regular member

* automatically make tag mods community mods

* fix merge conflicts

* add community view

* make methods less complex based on code climate sugggestion

* add specs

* refactor tag moderator module

* fix spec
2019-04-10 14:45:06 -04:00
Tim Lange
1c285ba2c5 UX: Fixed comment preview in darkmode (#2363) 2019-04-10 14:44:00 -04:00
Tim Lange
cd34243a14 UX: Made sloan transparent -> now working in night theme (#2353)
* UX: Made sloan transparent -> now working in night theme

* FIX: Added fallback for color
2019-04-10 11:01:40 -04:00
Mario See
4ca70f202e add phpc.social to mastodon list (#2352) 2019-04-10 10:58:05 -04:00
rhymes
d0441bb456 Enable Rails/TimeZone cop (#2334) [ci skip] 2019-04-09 15:38:28 -04:00
Jess Lee
de76f3722f Do not require author for note to display (#2350) 2019-04-09 15:13:27 -04:00
Tim Lange
6c6a4516df Improve footer's width (#2166) 2019-04-09 14:17:41 -04:00
Ben Halpern
81c44b7bfa
Only set cache control header on videos index page (#2346) 2019-04-08 20:13:35 -04:00
Andy Zhao
53d3091f73 Add single article functionality to articles analytics (#2339)
* Add specs for single article functionality

* Add single article functionality

* Use article_id instead of single_article_id

* Add published: true when querying for one article

* Use article_id in specs oops
2019-04-08 19:57:13 -04:00
Anna Buianova
f1d371c670 Set users email to nil instead of blank (#2305)
* Set users email to nil instead of blank

* Remove uniqueness validation duplication for users

* Fix organization following test in case the name contains quotes
2019-04-08 19:12:56 -04:00
Ben Halpern
27e7d5c3b9
Remove unnecessary queries from user save (#2342)
* Remove unnecessary queries from user save

* Fix test and modify follow suggestions query
2019-04-08 19:05:58 -04:00
cyrillefr
4fd66372dc Enable Layout/AlignParameters (#2340)
Check if the parameters on a multi-line method call or definition are aligned.

Resolves: #2021
2019-04-08 18:47:34 -04:00
Andy Zhao
36a21cd0f2 Add tech admin role and allow tech admins to view /delayed_job (#2343)
* Add tech support role

* Add tech support permission method

* Enabled /delayed_job for tech support users

* Fix typo oops

* Add tests for tech support viewing /delayed_job

* Fix typo again...

* Rename tech role to tech admin
2019-04-08 18:00:59 -04:00
Ben Halpern
dfbea4c0bd
Fix social share text bugs (#2341) 2019-04-08 17:43:27 -04:00
Ben Halpern
bd95c6a8bf
Fix human language detection (#2338)
* Update language detection

* Modify feed to account for languages
2019-04-08 15:47:29 -04:00
Anna Buianova
4ef7635ae0 Don't make additional SQL query on remembering user (#2335)
* Don't save when remembering user on sign in (WIP)

* Specs for AuthorizationService
2019-04-08 10:12:19 -04:00
Sidak Singh Aulakh
dbac5f6d19 Fixed fluid-comments in dark mode (#2246)
* Fixed fluid-comments

the inline fluid-comments in dark mode are now matching the syntax followed in the default theme.

* grey -> gray

* Added lighten function to fallback variable

Added lighten function to the fallback variable for anchor tags in fluid-comments
2019-04-07 17:12:49 -04:00
rhymes
3b4bda89df Upgrade Honeycomb gem, fix and improve RssReader tests (#2319)
* Switch from deprecated honeycomb-rails to honeycomb-beeline

* Improve error handling, tests and add refactoring

* Fix multiple fetching test and add one more

The test wasn't actually testing the correct behavior, because the class
by default force fetches. It worked because it wasn't reloading the user
from the database.

* Test that Honeycomb's client is doing its thing

* Use some defensive programming to avoid any possible problem during shutdown

* Fix typo

* Use the new API to add fields to the current measured event

* Use default instrumentation and add user info to event

* Replace user.email with user.username, less personal data around

* Use mocking instead of calling Honeycomb.init

* Freeze time before traveling

* Remove a flaky test dependent on rand
2019-04-07 15:27:53 -04:00
Perlat Kociaj
b4484ba06d integrations github repos hover and text color (#2302) 2019-04-07 15:25:41 -04:00
Ben Halpern
5f3fd96960
Modify social share button and functionality (#2316)
* Modify social share button and functionality

* Some nightmode changes tossed in

* Style adjustments and test snapshot fix
2019-04-06 14:49:52 -04:00
rhymes
a1787d0702 Fixed some Style/* rubocop violations (#2314)
* Fix Style/FormatString and Style/TrivialAccessors

* Fix Style/NegatedIf and Style/DoubleNegation

* Style/ClassAndModuleChildren is already enabled by default

* Fix Style/GlobalVars

* Group all style/ cops inside rubocop config file
2019-04-06 14:24:33 -04:00
Maxime Piard
8d67a06bd9 darken following weight input background for it to be readable (#2318) 2019-04-06 11:37:23 -04:00
Ben Halpern
42a5124fe4
Clean up videos page and add tests (#2315) 2019-04-05 16:05:50 -04:00
Jess Lee
175569fb97 "/videos" (#2291)
* set up video route

* add video index

* update styling

* fix mobile full width styling

* bust cache when new video is created

* add unlimited scrolling
2019-04-05 14:02:03 -04:00
Abraham Williams
b98565a931 Update rubocop to 0.67 (#2313) [ci skip] 2019-04-05 12:55:13 -04:00
Anna Buianova
1b9f2432f6 Conditional validations for user github_username and twitter_username #2061 (#2312)
* Conditional validation for usernames

* Allow nil, not blank for usernames
2019-04-05 11:35:26 -04:00
Ben Halpern
d7e2a07064
Finalize suggest-a-tweet functionality (#2310) 2019-04-04 19:23:03 -04:00
Ben Halpern
1552df98d2
Add ability for trusted users to suggest social copy for posts (#2306)
* Add ability for trusted users to suggest social copy for posts

* Fix schema

* Fix tests

* Fix test
2019-04-04 17:01:58 -04:00
rhymes
5e9867ec56 Simplify AnalyticsService code (#2308)
* Add basic tests for Analytics service

* User/Organization are always required

* Add some data to the test

* Use queries and date times

* Fix AnalyticsService interface in the controller

* s/HTTP_API_KEY/api-key

* Defend against nils and support datetime objects

* Update app/services/analytics_service.rb

Co-Authored-By: rhymes <rhymesete@gmail.com>

* Use SQL sum, not Rails sum

* Group average_read_time

* Use SQL, not Rails

* Use ISO date

* Fix specs
2019-04-04 16:07:57 -04:00