Ben Halpern
98b600da5c
[deploy] Move spam check to after save ( #10685 )
2020-10-06 19:54:30 -04:00
Ben Halpern
6cb68f134e
[deploy] Allow pattern match for spam terms ( #10684 )
2020-10-06 19:18:29 -04:00
Ben Halpern
c77a13c0d0
[deploy] Auto-suspend multiple-spammers ( #10679 )
...
* Auto-ban multiple-spammers
* Fix xit
2020-10-06 18:07:48 -04:00
Ben Halpern
eefbe25bd3
[deploy] Add ability for admin to add anti-spam terms ( #10615 )
...
* Add ability for admin to add anti-spam terms
* Fix specs
* Fix tests
* Fix typo
* Fix test
2020-10-06 10:10:30 -04:00
rhymes
10efa25c0a
Add missing presence validators to models ( #10495 )
...
* Add missing presence validator for Tag
* Add missing presence validators to Follow
* Add missing presence validators to ProfileField
* Add missing presence validators to Comment
* Add missing presence validators to Profile
* Add missing presence validators to Organization
* Add missing presence validators to Badge
* Add missing presence validators to Webhook::Endpoint
* Add missing presence validators to NotificationSubscription
* Add missing presence validators to PodcastEpisode
* Add missing presence validators to Sponsorship
* Add missing presence validators to PollOption
* Add missing presence validators to Poll
* Add missing presence validators to Article
* Add missing presence validators to EmailAuthorization
* Add missing presence validators to AuditLog
* Add missing presence validators to DataUpdateScript
* Add missing presence validators to User
* Add missing presence validators to SiteConfig
* Fix specs
2020-10-01 16:15:32 +02:00
rhymes
2d881ef571
Routine rubocop fixes ( #10237 )
2020-09-08 12:06:47 -04:00
Rafi
84012d400d
Deleting hidden comment notification using after_update ( #9823 )
...
* Deleting comment notification using after_update
* Using conditional callback to delete notification
* Adding tests for notification deletion
2020-08-31 11:01:25 +02:00
rhymes
c9e401758a
[deploy] Add dependent clauses to Article and fix Comment validation ( #9990 )
...
* Add dependent clauses to Article model
* Comment should be valid without a commentable
* Add cleanup scripts
* Cache the comments ids before destroying the article
* Add dependent clause to Article.user_subscriptions as well
* Fix specs
2020-08-28 18:24:28 +02:00
Molly Struve
a16fc46f84
[deploy] Revert "Async Handle Notifications for Comments When Saved ( #9680 )" ( #9686 )
...
This reverts commit 852223dd86
2020-08-08 20:16:27 -05:00
Molly Struve
852223dd86
[deploy] Async Handle Notifications for Comments When Saved ( #9680 )
2020-08-08 17:59:17 -05:00
rhymes
5a2cae4fbb
Rubocop: enable and fix new Rails cops ( #9537 )
...
* Enable new Rails/* cops and use autocorrect on them
* Fixed Rails/PluckInWhere leftovers
* Fix Rails/DefaultScope
* Enable and fix Rails/PluckId
* Fix manual mistake with forcing autocorrection on Rails/PluckId
* Apply PR feedback to remove Rails/PluckId inline disables
* Apply PR feedback to get rid of Rails/PluckInWhere inline
2020-07-29 11:14:19 +02:00
rhymes
f1ec04a0c9
Rubocop: move dot in multi-line calls to leading position ( #9262 )
2020-07-16 15:51:11 +02:00
rhymes
ba82e72aa4
Fix Rails/OutputSafety violations ( #9244 )
2020-07-11 11:36:24 +02:00
rhymes
5b62811c98
[deploy] Rubocop: fix violations of Layout/LineLength ( #9197 )
2020-07-08 08:36:36 -05:00
Alex
347a4bbc75
[deploy] Add contexts and permissions to liquid tags ( #8917 )
...
* Make liquid tags adhere to context and permission
* Undo updates to all liquid tags and update error
* ACTUALLY update errors this time
* Typo
* Refactor error handling and add support for Comment
* Fix specs
* Code cleanup
* Prettify error message
* Add comment clarifying error
* parsed --> parse
* Use a policy for validating roles
* Fix pretty error message
* Return early if valid source
* Get rid of duplicate current_user
* Add comment to Pundit.authorize
* LiquidTagPolicy specs
* Update liquid tag docs
* Update docs
* Use parse_context argument for clarity
* Remove duplicate guard clause for VALID_ROLES
* Update docs
2020-06-30 14:53:18 -04:00
rhymes
948e984ef3
Add unique index to comments - part 6 ( #8214 )
2020-06-02 11:30:43 +02:00
Molly Struve
c10602f4e6
[deploy] Delay RemoveFromIndex Job to Fix Callback Race Conditions ( #7800 )
2020-05-12 14:39:16 -05:00
Molly Struve
2d7f4acbbe
[deploy] Only Calculate Comment Score on Update and Create ( #7574 )
2020-04-28 13:35:18 -05:00
rhymes
d87c3dbb18
[deploy] Improve comment posting error handling ( #7519 )
...
* Improve comment posting error handling
* Incorporate PR suggestions
2020-04-27 16:54:59 +02:00
Josh Puetz
98365c878e
Parse comment html as fragments instead of docs ( #7419 )
2020-04-21 15:01:44 -05:00
Molly Struve
b10668a454
[deploy] Create a Bulk Index Elasticsearch Worker ( #7265 )
2020-04-15 09:08:59 -05:00
Molly Struve
be3a259b8e
[deploy] Make root_exists Method Public and Use In Other Callbacks ( #7101 )
2020-04-06 14:48:41 -05:00
Molly Struve
cbe6b3bd70
[deploy] Skip updating a root comment if it doesnt exist ( #7080 )
2020-04-06 10:18:05 -05:00
rhymes
f2b0be2043
Add Slack messengers: part 2 ( #6916 )
...
* Add Slack::Messengers::ArticlePublished
* Add Slack::Messengers::ReactionVomit
* Add Slack::Messengers::CommentUserWarned
* Add missing URL helpers
* Add Slack::Messengers::ArticleFetchedFeed
* Remove callback condition
* Build, don't create
2020-04-03 17:00:06 +02:00
Molly Struve
3087d3d4d8
Index comments into FeedContent index ( #6791 ) [deploy]
2020-03-24 09:24:20 -05:00
rhymes
20fd8cdb92
Replace observers with callbacks and remove rails-observers ( #6675 )
...
* Add test for vomit reactions ping
* Remove reaction observer
* Add tests for new published article ping
* Remove reaction observer
* Remove comment observer
* Fix specs
* Remove rails-observer gem
2020-03-18 09:58:36 +01:00
rhymes
21fca3e0f2
Comments API: hide deleted and hidden comments (plus docs) ( #6482 ) [deploy]
...
* Modernize index test
* Hide comments body_html and user info if the comment is either deleted or hidden
* Shorten lines a bit
* Freeze repeated strings
* Document all /comments
* Document /comments/{id}
2020-03-07 09:02:10 +01:00
Alex
35651b26e5
Remove Algolia from Comments ( #6464 ) [deploy]
...
* Remove Algolia from comments
* Remove more references to ordered_comments index
* Remove more references to Comments Algolia index
* Fix index_worker_spec
2020-03-05 11:30:25 -08:00
cyrillefr
fe57053c44
Fixe html_safe issues from comment domain ( #6422 )
2020-03-03 15:38:15 -05:00
Ben Halpern
1dc1723709
Add field test gem to establish a/b testing ( #6283 ) [deploy]
...
* Initial field test spec work
* Clean up specs
* Fix codeclimage
* Cleanups
* Update names
* Rename and remove need to pass logged in status
* Leadup to prod: two experiments
* Move test logic to controller and add tests
Co-authored-by: Josh Puetz <josh@grorichpuetz.com>
2020-03-03 10:21:29 -05:00
Molly Struve
1fc6766ebb
use safety operator for commentable in tags tag_list ( #6411 )
2020-03-02 13:57:47 -05:00
Molly Struve
a9ffccc1ac
use safety operator when indexing comment tag list ( #6407 )
2020-03-02 10:22:00 -05:00
Spencer
010c61a44a
Allow comments without a commentable to be edited and destroyed ( #5945 )
2020-02-25 13:45:50 -05:00
rhymes
6cd46ae2f9
Enable bullet during tests to catch N+1 early (and some cleanups) ( #5930 ) [deploy]
...
* Remove unused methods
* Small refactorings
* Enable bullet in testing mode
* Remove unused eager loading for notes
* Skip bullet on rolify method
* Use .present?
* Fix method name
2020-02-07 09:02:22 -05:00
Sebastien
665f5aac0f
Refactor ProfileImage ( #5803 )
2020-02-07 08:56:16 -05:00
Lucas Hiago
d5a5c53419
Change Notifications::UpdateJob to Notifications::UpdateWorker and move to sidekiq ( #5689 ) [deploy]
2020-01-28 12:43:50 -05:00
Lucas Hiago
587d1040dc
Change ModerationNotificationJob to ModerationNotificationWorker and move to sidekiq ( #5683 ) [deploy]
2020-01-28 08:42:26 -05:00
Alex
f6c2f46fbb
Move Search::RemoveFromIndexJob to Sidekiq ( #5637 ) [deploy]
...
* Create RemoveFromIndexWorker
* Create spec for RemoveFromIndexWorker
* Update RemoveFromIndexJob to RemoveFromIndexWorker
- Update references from the job to the new worker
- Update specs to use the new worker
- Fix spec in comment_spec that causes linter/RuboCop violation
* Remove unnecessary argument nil check
* Update spec for missing data
2020-01-23 11:27:28 -08:00
Alex
4e5dc015b3
Move Search::IndexJob to Sidekiq ( #5620 ) [deploy]
2020-01-22 08:24:53 -05:00
Maykon Menezes
ef1eb8d412
Refactor/user bust cache job ( #5563 )
...
* Refactor/user bust cache job
* Remove bust cache job old spec
2020-01-20 13:46:15 -05:00
Asha Balasubramaniam
81ead4935a
Migrate Comments::BustCacheJob to Comments::BustCacheWorker and move to Sidekiq ( #5502 )
2020-01-16 10:20:13 -05:00
Asha Balasubramaniam
e5960810cc
Migrate Comments::SendEmailNotificationJob to Sidekiq ( #5427 )
...
* Add sidekiq version of the corresponding delayed job
* Switch the invocation of the delayed job from `after_create` to
`after_create_commit` to avoid the race condition where the worker can
be executed before the comment is persisted. Added covering spec
for this change.
2020-01-10 13:59:12 -06:00
Pablo Ifrán
f5d3593d4f
Change the way that id_code was created ( #5348 ) [deploy]
...
The column id_code was created with a job in an after create callback,
that was replaced by an inline creation of the attribute
2020-01-08 16:21:39 -05:00
Asha Balasubramaniam
1003f71c8f
Migrate delayed job that calculates comment score to sidekiq ( #5382 )
2020-01-08 14:11:31 -05:00
Molly Struve
a572a96921
Remove comments user_touch job and do it inline when comment is created ( #5378 ) [deploy]
2020-01-06 15:52:59 -05:00
Ben Halpern
242c6eb5dd
Change from after_create to after_create_commit for :create_first_reaction ( #5341 ) [deploy]
2020-01-02 18:15:26 -05:00
Pablo Ifrán
783d43b737
Change create first reaction job to worker ( #5327 ) [deploy]
2020-01-02 13:06:53 -05:00
Anna Buianova
bbc5f95d86
Fix Algolia deserialization errors by indexing by record_type and id rather than AR object ( #5063 ) [deploy]
2019-12-11 11:49:35 -06:00
Andy Zhao
71157c993e
Hide comment feature ( #4944 )
...
* Add MVP of hide comment feature
* Slight copy adjustments
* Remove unused file oops
* Fix strange styling issues
* Add hide/unhide comment specs
* Authenticate user for hide/unhide
* Add tests for hide/unhide functionality
* Remove opacity CSS for hidden comments
* Fix hidden comment explanation logic
* Fix some styling issues
* Fix hiding top level comment logic
* Show only hidden comments in permalink and not thread
* Hide subtree properly if hidden comment
* Fix weird CSS issue
* Properly hide comments for permalink view
* Show children comments in permalink view
* Add tests for comment hiding visibility
* Remove superfluous code and adjust copy
* Remove some more logical duplication
* Add dedicated article column for any comments hidden
* Add reload in test
2019-12-10 15:09:47 -05:00
rhymes
9c05e618db
Improve speed of model tests by around 50/60 seconds ( #5016 )
2019-12-09 16:33:48 -05:00
