Commit graph

822 commits

Author SHA1 Message Date
Ashwin Vaswani
fbdd80d5fc Add headings to header tags (#1003)
* updating all headers to have h* tags, or changing elements

* Remove commented out binding.pry

* Remove unused page

* Use article instead of div for consistency

* Update snapshot with new section tag

* Use h4 tags again for new views
2018-12-19 16:47:44 -05:00
Ben Halpern
bbbfe6af51
Add haptic feedback where it was missing (#1367) 2018-12-19 16:24:12 -05:00
Jess Lee
1586d9fd7d Include conditional for adding tag mods to connect channel (#1366)
* fix slug typo

* fix specs

* use blank? instead of nil?
2018-12-19 15:44:36 -05:00
Jess Lee
7ca3d5c542
Fix tag channel query 2018-12-19 13:47:16 -05:00
Jess Lee
d8ff236f69 Fix slug typo (#1364) 2018-12-19 13:39:50 -05:00
Andrew Bone
67ee564730 Beginning of css variable implementation (--theme-background) (#1306)
* Beginning of css variable implimentation

Added --theme-background leaving the default the same.
This will make no, visible, change to the styles currently.

* Beginning of css variable implimentation

Added --theme-background leaving the default the same.
This will make no, visible, change to the styles currently.

* Beginning of css variable implimentation

Added --theme-background leaving the default the same.
This will make no, visible, change to the styles currently.

* Beginning of css variable implimentation

Added --theme-background leaving the default the same.
This will make no, visible, change to the styles currently.

* Beginning of css variable implimentation

Added --theme-background leaving the default the same.
This will make no, visible, change to the styles currently.

* Beginning of css variable implimentation

Added --theme-background leaving the default the same.
This will make no, visible, change to the styles currently.
2018-12-19 10:16:30 -05:00
Jess Lee
1d2a6def4a Add tag moderation info page (#1360)
* clarifies tag edit form and updates photo

* add better image

* add tag moderation route and page info

* adds labor module for assigning bulk tag moderators

* Apply Peter's changes from code review

Co-Authored-By: jessleenyc <jessleenyc@gmail.com>

* fix typo

Co-Authored-By: jessleenyc <jessleenyc@gmail.com>

* replace with cloudinary image links

* add specs
2018-12-19 09:27:55 -05:00
Andy Zhao
cf36025a16 Fix reactions rendering on notifications (#1362)
* Use more specific find for looking for reactions

* Use basic notification tests

* Test for proper reaction button rendering

* Use the proper user for reaction test
2018-12-18 20:58:31 -05:00
Andy Zhao
8fb35e84c2 Add title to organization profile page (#1355)
* Add test for page title

* Add organization name as title
2018-12-18 17:14:23 -05:00
Mario See
60d38ef787 /connect rerender chat (#1359)
* check element render before scrollingto bottom

* check element render before scrollingto bottom

* remove console logs

* remove accidental quote
2018-12-18 17:13:13 -05:00
Andy Zhao
88cd4c13f3 Remove all flipflop related code (#1358)
* Remove all flipflop related code

* Undo an amend

* Comment out one last test

* Remove last test
2018-12-18 16:01:18 -05:00
Mac Siri
06e0cbabbb Revert "Replace Flipflop with Sail (#841)"
This reverts commit 21870e805a.
2018-12-18 13:44:40 -05:00
Vinicius Stock
21870e805a Replace Flipflop with Sail (#841)
* Replace Flipflop with Sail

* Address PR comments

* Bump sail version to latest

* Bump Sail to latest version

* Move setting creation to config/sail.yml

* Bump Sail to latest version

* Use correct limit for cast_type in schema

* Update Sail's route
2018-12-18 12:42:30 -05:00
Andy Zhao
651a26a514 Use latest admin page views from administrate gem (#1351) 2018-12-17 16:45:12 -05:00
Ben Halpern
28736cda20
Add missing title attribute to user profile page (#1349)
* Add missing title attribute

* Add spec

* Fix test
2018-12-17 15:04:00 -05:00
Ben Halpern
7d3da5df35
Fix twitter missing quote text (#1330) 2018-12-17 10:49:16 -05:00
Chinmay Joshi
d39d44ac07 css fix for mixed looking text while rendering articles (#502) 2018-12-15 13:18:01 -05:00
Andrew Bone
db55f871d4 Beginning of css variable implementation (#1307)
Added --theme-top-bar-background leaving the default the same.
This will make no, visible, change to the styles currently.
2018-12-15 12:48:28 -05:00
Richard Kichenama
4b8dffb4c9 Iterate on Night Theme (#1303)
*  implement night theme through css filters

* 🐛 and video

* ♻️ simplify selector

* ♻️ finer targeting and untouched graphics

* 🐛 keep it in the theme

* ♻️ remove styling for 3x inverted elements
2018-12-15 12:46:34 -05:00
Andy Zhao
b3f2789eb2 Check if author_id is nil before querying for author (#1325)
* Check if author_id is nil before querying for author

* Remove some legacy code

* Remove tests that test for unused functionality
2018-12-15 12:44:45 -05:00
rhymes
73ddff4549 Add a descriptive title to the series links (#1329)
It's easy to navigate each part of a series when there only a few of them. It's hard to jump from a part to another if there are many. This change makes it also a little friendlier to accessibility tools.
2018-12-15 12:44:29 -05:00
Anna Buyanova
074d50d2b7 Stories views reorganization (#1317)
* Added stories feature specs

* Structure feature specs

* Spec for the articles by tag page

* Spec for clicking "week" button on the tag page

* Reorganize stories views

* Feature spec for displaying sponsors on tag page

* Increase allowed rspec example length

* Spec for the users comments view

* Articles by tag: reeplace view code with rendering partials
2018-12-13 14:54:02 -05:00
Mac Siri
56ec3e55a2 Refactor Reaction (#1320)
* Refactor Reaction's spec

* Create singleton class in Reaction

* Refactor Reaction
2018-12-13 14:24:33 -05:00
Ben Halpern
9b299569cb
Modify style on show page cta (#1324) 2018-12-13 14:23:18 -05:00
Kyle Boe
f82b562cd8 Update member's only sticker pack link (#1301) 2018-12-12 17:53:59 -05:00
Mac Siri
72eb2fc7b6 Revert "Extract background jobs from Reaction (#1312)" [ci skip]
This reverts commit cd54bece92.
2018-12-12 17:10:42 -05:00
Mac Siri
cd54bece92 Extract background jobs from Reaction (#1312)
* Refactor Reaction

* Update reaction_spec

* Extract update_reactable to job class

* Create ApplicationJob

* Rename Engagement::UpdateReactableJob to ReactionCascadeJob

* Rename ReactionCascadeJob to Reaction::UpdateRecordsJob

* Refactor Reaction::UpdateRecordsJob

* Remove unused method

* Change module to class
2018-12-12 16:41:31 -05:00
Mario See
394580b8c8 connect highlight messages (#1311)
* move setstate into cases where activecontent actually changes

* remove unnecessary setstate lines

* rearrange triggerActiveContent
2018-12-12 12:42:42 -05:00
Ben Halpern
14bba5e4d5
Adjust button style/placement on desktop (#1288)
* Adjust button style/placement on desktop

* Change opacity on side comments

* Adjust css for side article actions

* Adjust opacity

* Adjust opacity

* Adjust opacity

* Fix test language

* Remove opacity deal
2018-12-11 13:08:43 -05:00
Brian Kephart
5a4f894e84 Add ruby.social to Mastadon safelist (#1302) 2018-12-11 10:30:01 -05:00
Anant Jain
6bb87b25b2 Fixes #1298: Overflowing User Bio in article sidebar. (#1300) 2018-12-10 18:51:11 -05:00
Mark Frost
bb5a999a91 [#339] fixed broken markup on /readinglist page (#435) 2018-12-10 13:23:38 -05:00
rhymes
96d01b20a2 Use allow/allowed instead of whitelist (#1296)
* Use allow/allowed instead of whitelist

* Remove duplication in comment
2018-12-10 13:16:16 -05:00
Jibran Kalia
f569f33e4f [WIP] Really simple calculate reading time function (#1283)
* Really simple calculate reading time function

* Move parse_it so that the number of methods in MarkdownParser is at 20

* Added test and default value for reading time
2018-12-09 13:42:32 -05:00
Ben Halpern
c3d5220767
Add haptic message for iOS feedback (#1287) 2018-12-09 12:30:14 -05:00
Andrew Bone
bfa6622486 Darken cta-button (#1281)
Darken cta-button to bring contrast up to 7
The new colour value is `#1b4bcb`
2018-12-09 11:17:38 -05:00
Andy Zhao
1fad5728a2 Use article.user instead of @user (#1286) 2018-12-09 11:16:22 -05:00
Mario See
b29a155edd Fix lint (#1282) 2018-12-07 14:54:00 -05:00
Andy Zhao
afce7acbf6 Fix profile's path for comment (#1280)
* Use user path instead of comment path, oops

* Fix typo

* Add 3 retries to capybara failing spec
2018-12-07 13:11:27 -05:00
Andrew Bone
d387f1a35f Add alt attributes for landing page images (#1272)
* Add alt tag

`alt` tag is blank at @Zhao-Andy's request

* Added alt tag

`alt` tag is blank at @Zhao-Andy's request

* Added alt tag

Added `alt` tag for a11y compliance
2018-12-07 12:24:33 -05:00
Conlin Durbin
121d0b1561 Add "radical.town" to Mastodon list (#1279) 2018-12-07 11:56:34 -05:00
Tomas Zemanovic
01a334735f Update badges.html.erb (#1266)
updated the Font Awesome badge accordingly to their page
2018-12-07 10:33:07 -05:00
Andy Zhao
fbe586497b Synchronously bust cache after save for comments (#1275) 2018-12-07 10:16:46 -05:00
Nick Taylor
86e55c2b6d Added toot.cafe to Mastodon whitelist (#1268) 2018-12-06 14:08:55 -05:00
Jess Lee
f96bc7c6f3 Revert banisher (#1274)
* remove stalebot from milestone issues

* simplify banisher
2018-12-06 13:44:53 -05:00
Ben Halpern
20c237d1be
Fix css z-index style bug on series indicator (#1265) 2018-12-05 15:12:25 -05:00
Ben Halpern
e0d1d749fc
Various internal functionality adjustments (#1264) 2018-12-05 13:28:46 -05:00
Andy Zhao
bfcc40779a Remove some unnecessary CSS (#1263) 2018-12-05 10:39:21 -05:00
Rozie
37fc82c409 change save button background (#1261) 2018-12-05 09:56:20 -05:00
Martin Riedel
9fb2cd8d16 Add infosec.exchange to mastodon whitelist. (#1262)
* Add infosec.exchange to mastodon whitelist.

* fix codeclimate error

alignment was off;
tab instead of spaces has been used;
2018-12-05 09:55:02 -05:00