Tom Hughes
6d919acc63
fix: prevent dashboard following lists rendering stale content ( #19397 )
...
Co-authored-by: Lawrence <lawrence@forem.com>
Co-authored-by: Rajat Talesra <rajat@forem.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
Co-authored-by: Philip How <philip.j.how@gmail.com>
2023-05-31 17:52:12 -04:00
Arit Amana
0d023163ba
Hide 'Save' button on posts that belong to the current user ( #17293 )
...
* implement change
* struggling with tests
* extend implementation to relevant views
* update Article.test.jsx snapshot
* fix failing specs
* query userData more robustly
* default saveable value in SaveButton component
* fix spec
* fetch currentUser async
2022-04-28 12:33:01 -04:00
ludwiczakpawel
43c188eafb
Updated indicators ( #16190 )
2022-01-20 06:25:10 +01:00
Josh Soref
0403e78f08
Spelling ( #15702 )
...
* spelling: access
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: additional
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: administrative
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: aggregate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: assigns
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: attributes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: autocomplete
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: because
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: between
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: bootstrap
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: calculating
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: captcha
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: character
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: chosen
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: commenter
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: competitor
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: componentize
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: contrast
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: corresponding
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: description
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: destroyed
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: destroys
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: discussion
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: episode
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: escaped
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: evaluates
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: expired
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: explicitly
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: facebook
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fragment
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: functionality
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: improper
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: incentive
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interfere
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: latest
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: message
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: minimum
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: moderator
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mouseover
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mutual
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: nonexistent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: notification
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: occasionally
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: occurrence
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: occurs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: octokit
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: offset
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: omitted
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: opacity
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: organization
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: organizations
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: overridden
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: override
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: overriding
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: prefill
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: previous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: profile
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: recycling
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: registered
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repositories
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: rescuing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: response
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: returns
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: second
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: separator
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: services
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: subscriber
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: subscription
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: success
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: successful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: successfully
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: suppress
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: test
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: thought
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: uniqueness
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unknown
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unproductive
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unreachable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unsuccessful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: utilities
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: utility
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: valid
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: voluntarily
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: vomited
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: website
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: withholding
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-12-07 06:59:10 -07:00
ludwiczakpawel
ca108aa9c8
Videos UI update ( #15177 )
...
* videos ui updates
* move cheese around
* .
* .
* thumbnail yolo
* thumbnail yolo
* object fit
* aspect ratio yolo
* .
* loading videos
* Make Travis and asset pipeline happy with .mp4 extension
* Use Cloudinary video url, testing for Travis
* Try weird things
* Try a real image url
* Use a real image instead of 'video' string
* Update views.scss
Co-authored-by: Andy Z <17884966+Zhao-Andy@users.noreply.github.com>
2021-10-28 09:34:44 +02:00
rhymes
0dd11b3da5
Replace spread syntax with Object.assign in untranspiled JS file ( #15148 )
2021-10-21 14:01:05 +02:00
Ben Halpern
09fa66a03f
Fix and clean up podcast pages ( #15004 )
...
* Fix and clean up podcast pages
* Adjust tests
* Fix a test
* Fix missing i18n
* Fix tests
* Fix tests
* Fiddle with test
* Sure up css and tests
* Add featured as allowed param
* Fix a couple tests
* xit out test
* Update app/views/podcast_episodes/index.html.erb
* Update app/views/podcast_episodes/index.html.erb
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2021-10-15 17:38:57 -04:00
Suzanne Aitchison
16cec7d93d
[15 min fix] Add aria-current attribute to current dashboard link ( #14128 )
...
* add aria-current attribute to current dashboard link
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* stub network request
* fix typo in stub
* always guard against lack of entries
Co-authored-by: rhymes <github@rhymes.dev>
2021-07-07 09:41:35 +01:00
dependabot[bot]
1a48b3151a
Bump cypress from 6.9.1 to 7.2.0 ( #13528 )
...
* Bump cypress from 6.9.1 to 7.2.0
Bumps [cypress](https://github.com/cypress-io/cypress ) from 6.9.1 to 7.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases )
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js )
- [Commits](https://github.com/cypress-io/cypress/commits/v7.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
* fix intercept and exception issues causing commentOnArticle specs to fail
* fix a typo while we're here
* stub the minimum search text
* update intercepts on post mention user
* Bump cypress from 6.9.1 to 7.2.0
Bumps [cypress](https://github.com/cypress-io/cypress ) from 6.9.1 to 7.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases )
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js )
- [Commits](https://github.com/cypress-io/cypress/commits/v7.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
* fix unhandled exceptions in initScrolling causing tests to abort
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-04-28 10:09:43 +01:00
Suzanne Aitchison
ee66e4cf7d
[15 min fix] Fix following tags input a11y errors ( #13425 )
...
* fix following tags input a11y errors
* give hidden inputs unique ids
* update html element code in initScrolling, update test with new ids
* refactor
* trigger travis
* target the textfield inside the div in the test
2021-04-23 14:40:02 +01:00
Suzanne Aitchison
1f8f348d5d
add skip link functionality to videos ( #13113 )
2021-03-26 10:23:45 +01:00
Suzanne Aitchison
5abe88c69b
Add skip links to readinglist, podcasts, and listings ( #12769 )
...
* add skip link functionality to readinglist, listings and podcasts
* fix initscrolling reference to podcasts
2021-02-23 08:33:26 +00:00
Suzanne Aitchison
c761c3f9a7
Provide skip links: Tweak skip link style, refactor main area ID ( #12694 )
...
* change home page main id to main-ontent, update scroll, refresh and shortcut handlers
* update articles by timeframe test with new main-content id
* tidy up css
* Trigger Travis CI
* undo unneeded changes
* small refactors
2021-02-17 10:15:31 +00:00
Chien-Wei Huang (Michael)
025a46e012
Update all followed tag with one click ( #11454 )
...
* Replace follows#update with follows#bulk_update
* Allow follows#bulk_update to receive multiple follows and remove follows#update
* Add FollowPolicy#bulk_update? and remove update?
* Combine save button into one in following_tag.html
* Rename follows_update_spec to follows_bulk_update_spec and update
* Update buildTagsHTML to conform to the view
* Allow scrolls down dashboard test to update multiple tag values
* Includes follower and followable in follows#bulk_update
* Mark and pass changed field.
* fix typo in html
* Update follows in transaction
* Extract js script to another file and update view
* Rename disableUnchangedButton.js to dashboardTagsDisableUnchangedButtons.js
2021-01-05 16:15:37 +01:00
ludwiczakpawel
30c9175f80
Tags index design update ( #9072 )
...
* flare tag line height
* .
* dropdown fix + actions bar fix
* actions bar on mob
* .
* .
* js
* little updates
* improve contrast ratio
* Remove unused id and duplicated element id
Co-authored-by: rhymes <rhymes@hey.com>
2020-07-06 11:43:58 +02:00
ludwiczakpawel
c9c88c7cc1
[deploy] Dashboard updates ( #8879 )
...
* flare tag line height
* .
* .
* .
* .
* specs
* spec
* .
* init
* .
* .
* js refactor
* js
* update spec
* Fix infinite scroll
* typo
* move IF
* pro analytics link fix
* Clean up tests
* Refactor adding of html
Co-authored-by: benhalpern <bendhalpern@gmail.com>
2020-06-25 13:10:17 -04:00
rhymes
ce28c0b5e5
[deploy] Remove ERB pre-processing from pure JS files and cleanup ( #8030 )
2020-05-27 08:25:39 -05:00