Suzanne Aitchison
16cec7d93d
[15 min fix] Add aria-current attribute to current dashboard link ( #14128 )
...
* add aria-current attribute to current dashboard link
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* Update app/views/dashboards/_actions.html.erb
Co-authored-by: rhymes <github@rhymes.dev>
* stub network request
* fix typo in stub
* always guard against lack of entries
Co-authored-by: rhymes <github@rhymes.dev>
2021-07-07 09:41:35 +01:00
Monica Mateiu
dbdd24c729
add org analytics menu if user has organizations ( #13995 )
...
* add organizations menu to analytics page
* Update app/views/dashboards/analytics.erb
Co-authored-by: rhymes <github@rhymes.dev>
* replace querySelector with getElementsByClassName for better performance
* Update app/javascript/packs/analyticsDashboard.js
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/dashboards/analytics.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* refactor analytics view and add specs
* skip flakey analyticsNavigation spec
Co-authored-by: rhymes <github@rhymes.dev>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-06-23 14:35:23 +02:00
Alex
b02d43ca2d
Create DiscussionLocks ( #13905 )
...
* Create DiscussionLocks
* Fix specs
* Update nullify_blank_notes_and_reason
* Update before_validation call
* Updated DiscussionLockPolicy for clarity
* Move permitted_attributes to a constant
* Update route
* Apply suggestions from code review for frontend
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Add title tags
* Wrap unlock confirm in main element
* Wrap flash messages up in div
* Actually fix title tags
* Hide comment reply button when discussion is locked
* Add E2E tests
* Try to fix E2E tests
* Cypress...you work locally but not in CI...why!?
* PR feedback
* Update E2E tests
* More E2E updates 😭
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-06-10 11:04:33 -04:00
Suzanne Aitchison
be15f31122
Optimise dropdowns for accessibility: Dashboard and Manage pages ( #13909 )
...
* use dropdownutils in dashboard and manage pages
* add tests for the toggle menu on dashboard
* add test for archiving from manage post view
* small tweak to avoid unhandled errors
* small tweaks to form methods
2021-06-04 10:19:56 +01:00
Dan Wallis
521bb09394
Add loading=lazy to image tags ( #10888 )
...
* Add loading=lazy to image tags
* Fix test
* Lazy-load some obvious templates
* Lazy-load more verified templates
2021-05-27 19:01:21 +02:00
Michael Kohl
6dfabd578f
Rename SiteConfig to Settings::General ( #13573 )
...
* Rename SiteConfig
* More renaming
* Update spec
* Update mandatory settings mapping
* More renaming
* e2e test fixes
* You have a rename, and you have a rename
* Spec fix
* More changes
* Temporarily disable specs
* After-merge update
* Undo rename for migration
* undo rename of DUS
* Fix DUS
* Fix merge problem
* Remove redundant DUS
* Fix specs
* Remove unused code
* Change wrong class name
* More cleanup
* Re-add missing values to constant
* Fix constant
* Fix spec
* Remove obsolete fields
* Add accidentally removed field
* Update spec
* Move methods from Settings::General to ForemInstance
* Remove unneeded model
* Change mentions of 'site config'
2021-05-21 14:45:37 +02:00
Jamie Gaskins
bcc42a130d
Sanitize tag urls ( #13720 )
...
* Sanitize tag URLs
For tags with non-ASCII names, we were generating busted URLs, which
would then cause errors. This commit fixes that particular error by
generating usable URLs.
* Use URL generator that will sanitize tag names
* Remove path prefix when using a URL generator
2021-05-11 11:21:03 -04:00
Michael Kohl
111b7316d9
Remove mascot footer image ( #13642 )
...
* Remove footer mascot image
* Move remaining mascot settings back to SiteConfig
* Add data update script
* Update usages
* Fix path
* Remove dead route
* Update tests
* Fix view and spec
* Fix e2e test
* Fix DUS
2021-05-11 13:55:18 +02:00
Michael Kohl
610f6151e6
Split Settings::Community from SiteConfig ( #13403 )
...
* Add settings_community_contents model
* Add settings_communities model
* Update usage
* Add controller and update code
* Add e2e test
* Add data update script
* Update schema.rb
* Fix specs
* PR feedback
* Remove experience_* from Settings::Community
* Update spec
* Fix spec
2021-04-26 10:46:35 +02:00
Michael Kohl
f2f5e911cf
Add Settings::Mascot ( #13451 )
...
* Add Settings::Mascot
* Add DUS
* Update usage
* Fix e2e test and controller
* Fix specs
* Fix remaining spec
2021-04-26 11:39:19 +07:00
Suzanne Aitchison
2447bc3a40
add skip link to stats and analytics pages ( #13487 )
2021-04-23 16:17:23 +01:00
Suzanne Aitchison
ee66e4cf7d
[15 min fix] Fix following tags input a11y errors ( #13425 )
...
* fix following tags input a11y errors
* give hidden inputs unique ids
* update html element code in initScrolling, update test with new ids
* refactor
* trigger travis
* target the textfield inside the div in the test
2021-04-23 14:40:02 +01:00
Michael Kohl
28dd50e718
Create settings model for rate limits ( #13381 )
...
Co-authored-by: rhymes <rhymes@hey.com>
2021-04-20 11:29:22 +07:00
Suzanne Aitchison
65d0183a47
fix accessible name of listings on dashboard ( #13424 )
2021-04-16 14:46:46 +01:00
Fernando Valverde
8b4e6ba91b
[Small fix] Makes stats page responsive ( #13345 )
...
* Small UI refactor that makes the stats page resonsive (to some degree)
* Add import to scss file
* Whoops
* Implement feedback from review
* Extract flex value into variable
* Update app/javascript/analytics/dashboard.js
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-04-14 14:57:35 -06:00
Andrew Bone
c9e4227c59
crayons-notice accessibility improvements (#13273 )
...
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Update app/assets/javascripts/initializers/initializeCommentsPage.js.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/badge_achievements/award.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/broadcasts/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/configs/_apple_auth_provider_settings.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/configs/_form_submission.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/pages/sponsors.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/shared/authentication/_email_registration_form.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/users/_account.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/shared/authentication/_initial_account_wizard.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/users/edit.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/configs/show.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/configs/show.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/feedback_messages/_feedback_message.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/html_variants/show.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/pages/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/pages/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/liquids/_user_subscription.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/profile_fields/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/tags/edit.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/users/gdpr_delete_requests/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/articles/_actions.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/articles/_search.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/articles/show.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/articles/show.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/articles/tag_index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/comments/_comment_quality_marker.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/comments/deleted_commentable_comment.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/users/_notes.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/dashboards/following_tags.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/devise/invitations/edit.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/events/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/listings/_form.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/listings/edit.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/pages/_editor_frontmatter_help.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-04-14 13:32:57 +01:00
Suzanne Aitchison
54c6aa484d
improve accessible names of dashboard post actions ( #13232 )
2021-04-05 09:24:39 +01:00
Vaidehi Joshi
95055b2a89
Remove pro role + expose analytics to all users via dashboard ( #13156 )
...
* Remove pro role on user, expose pro dashboard to all users as analytics
* Remove pro from Elasticsearch mappings
* Update user role docs to use :trusted over :pro
* Remove pro from Role model spec
* Remove more references to pro, as noted by @rhymes
2021-03-30 15:02:18 -07:00
Suzanne Aitchison
e382a086bc
Add skip link functionality to dashboard pages ( #13115 )
...
* add skip link functionality to dashboard pages
* add skip link to listings dashboard
* add missed follow users dashboard
2021-03-25 09:45:01 +01:00
Deepak Mahakale
7a7826fe5b
Fixes locale issue with edited_at date of post on the dashboard ( #12948 )
...
The issue is caused because published_timestamp` is converted to local date wherea the `edited_at` date is not.
Fixed by using `local_date` while presenting the `edited_at` date to keep the behaviour same.
2021-03-10 11:28:07 +01:00
Ben Halpern
e3d39e09b4
Patch: Fix UI bugs in follow adjustment form ( #12137 )
...
* Fix UI bugs in follow adjustment form
* Move to bottom
2021-01-20 17:23:18 -05:00
Alex
b168e1529f
Move HexComparer to Hex::Comparer service ( #12202 )
...
* Move HexComparere to Hex::Comparer service
* Create USER_COLORS constant and constant specs
* Move formats to constants
* Rename Hex::Comparer to Color::CompareHex
2021-01-12 11:34:30 -05:00
Chien-Wei Huang (Michael)
025a46e012
Update all followed tag with one click ( #11454 )
...
* Replace follows#update with follows#bulk_update
* Allow follows#bulk_update to receive multiple follows and remove follows#update
* Add FollowPolicy#bulk_update? and remove update?
* Combine save button into one in following_tag.html
* Rename follows_update_spec to follows_bulk_update_spec and update
* Update buildTagsHTML to conform to the view
* Allow scrolls down dashboard test to update multiple tag values
* Includes follower and followable in follows#bulk_update
* Mark and pass changed field.
* fix typo in html
* Update follows in transaction
* Extract js script to another file and update view
* Rename disableUnchangedButton.js to dashboardTagsDisableUnchangedButtons.js
2021-01-05 16:15:37 +01:00
Ben Halpern
d759ac4627
Add implicit points to follows to improve feed relevancy (in all algorithms) ( #11513 )
...
* Fix menu dropdown disable issue
* Initial base work
* Add real algorithm
* Add working object and test
* Fix schema
* Fix schema
* Fix schema
* Finalize
* Add update script and explict_points
* Proper implicit/explicit points
* Fix tests
* Add docs
* Fix tests
* Fix data update script test
* Fix data update script test
* Fix typo
* Improve efficiency and add more logic
* Changed to find_each
* Change to bulk insert
* Update tests and refactor logic
* Various improvements
* Fix typo
* Fix tests
* Remove extra line
* Fix tests
* Fix test typo
* Cache site-wide tag names
2020-11-25 16:09:51 -05:00
irmela
9af120561c
Make markup for dashboard ellipsis menu more consistent ( #10764 )
...
* Make markup for dashboard ellipsis menu more consistent
* Rename js-dashboard-row-more to js-ellipsis-menu
2020-11-15 14:26:37 +01:00
ludwiczakpawel
44466532dd
Z-index cleanups ( #11157 )
...
* tooltips 1.0.1
* tooltips 1.0.1
* cleanup css
* few more fixes
* fix
2020-10-30 16:03:23 +01:00
Molly Struve
17535cd90b
[deploy] Bug Fix:Use local_date Helper for All Published Timestamps ( #11028 )
2020-10-23 11:43:18 -05:00
Ben Halpern
467e99556c
[deploy] Fix tag display bug and crayonsify area ( #10868 )
...
* Fix tag display bug and crayonsify
* Fix some specs
* Remove unused tag js
* Adjust to remove crayons card bg
* Adjust padding
* add spacing below nav
* drop unnecessary classname
* cleanup headers
* links
* Finalize style and add hint to eliminate div jump
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-10-20 16:07:17 -04:00
Ridhwana
d2db2f683d
[deploy] Disable ability to upload videos on *some* forems Part 2 ( #10955 )
...
* feat: set the showing of the upload button on when enable_video_upload is true
* oops same here
* spec: test that the links shows and hides appropriately with enable_video_upload added
* suggestions
* chore: revert changes and make enabled its own method
2020-10-20 17:33:35 +02:00
Mac Siri
30fa3b79a3
Default to Imgproxy on Forem-cloud ( #10819 )
2020-10-14 12:54:59 -04:00
Lisa Sy
36e271e1cb
Deprecate old button stylings with Crayons buttons ( #10694 ) [deploy]
...
* Deprecate old buttons.scss file
* Replace outdated button styles with Crayons button styling
* Update additional views after removing old button styling
* Update tests
* Update test
* Update test
* Fix button placements
2020-10-14 07:28:41 -07:00
ludwiczakpawel
bf8e2e53f1
Titles & subtitles cleanup ( #10508 )
...
* .
* .
* .
2020-10-02 12:37:39 +02:00
Mac Siri
9ebd742712
[deploy] Reintroduce sticky_nav changes ( ab81f36 & 7f92855) ( #10263 )
...
* Revert "[deploy] Revert removal of unneeded eager load (if needed) (#10179 )"
This reverts commit 11c7b148da#10055 )" (#10149 )"
This reverts commit 5657067e55
2020-09-09 15:33:13 -04:00
Mark Mead
8099a91611
Strip tags from short_summary ( #10157 )
2020-09-03 16:47:05 -04:00
Molly Struve
5657067e55
[deploy] Revert "Migrate ProfileImage to Images::Profile ( #10055 )" ( #10149 )
...
This reverts commit ab81f36a38
2020-09-01 18:28:58 -05:00
Mac Siri
ab81f36a38
[deploy] Migrate ProfileImage to Images::Profile ( #10055 )
2020-09-01 17:16:03 -04:00
Mac Siri
b5be5990e4
[deploy] Expand Images::Optimizer to support imgproxy ( #9909 )
...
* Create _comment.html.erb spec
* Add imgproxy.rb
* Setup imgproxy MVP
* Expand Images::Optimizer to support imgproxy
* Enable imgproxy in dashboards/show WIP
* Create view spec
* Fix typo
* Also check for Imgproxy.config.endpoint
* Use ApplicationConfig instead of ENV
* Update Images::Optimizer#call
2020-08-25 16:00:40 -04:00
ludwiczakpawel
cbb85c430c
Long titles wrapping ( #9915 )
...
* .
* .
* ffs revert
* other places too
2020-08-22 17:18:32 +02:00
Mac Siri
a081810946
[deploy] Migrate ImageResizer to Images::Optimizer ( #9720 )
2020-08-14 09:44:30 -04:00
rhymes
b94dea9b70
Upgrade erb_lint to support latest Rubocop and fix violations ( #9663 )
...
* Upgrade erb_lint to support latest Rubocop and fix violations
* Wrong template name
2020-08-07 15:36:48 +02:00
ludwiczakpawel
dbbe158d21
Buttons: Ghost Dimmed ( #9626 )
...
* flare tag line height
* .
* dropdown fix + actions bar fix
* actions bar on mob
* ghost dimmed
* add to page/crayons
2020-08-06 11:03:06 +02:00
Raphael Noriode
269ef9c4f6
Overview of my own series #6938 ( #9054 )
...
* add series to dashboard sidebar template
* add series view to the user dashboard
* update typo
* merge master
* modify the dashboard to hold series count that link to the user's series page
* remove schema unnecessary change
* remove controller count from function
2020-08-06 10:54:59 +02:00
Michael Kohl
8425c847c3
Update CODEOWNERS and team names in TODO comments ( #9460 )
...
* Update CODEOWNERS
* Update teams in TODO comments
* Remove mentions of team cool
2020-07-24 12:17:20 +07:00
Veggier
b3d742dde3
change Label Follow Weight Scale for Tags in Dashboard ( #9247 )
2020-07-14 12:28:43 -05:00
Alex
9f9236164c
[deploy] Add subscriptions to the dashboard ( #9161 )
...
* Add /dashboard/subscriptions route
* Dashboard controller updates
* Update ArticlePolicy with subscriptions?
* Update article row view in dashboard
* Add subscriptions view
* Add specs
* Add comment for pagination limit
* Use cached user_subscriptions count
* Add spec for cache counter
* Add path helper
2020-07-08 08:31:03 -04:00
Michael Kohl
fb27f52ed0
[deploy] Display banner if site hasn't been configured (PRE DEPLOYMENT TASKS) ( #8435 )
2020-07-07 07:37:04 -05:00
ludwiczakpawel
30c9175f80
Tags index design update ( #9072 )
...
* flare tag line height
* .
* dropdown fix + actions bar fix
* actions bar on mob
* .
* .
* js
* little updates
* improve contrast ratio
* Remove unused id and duplicated element id
Co-authored-by: rhymes <rhymes@hey.com>
2020-07-06 11:43:58 +02:00
rhymes
683f45d1e7
[deploy] Fix pro link for organization users ( #9144 )
...
* Fix pro link for org users
* Remove useless empty line
2020-07-05 18:17:03 -04:00
Michael Kohl
25622fa1ff
Show org dropdown for postless users ( #9069 )
...
* Show org dropdown for postless users
* sorting and gap
* Fix typo
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-07-02 14:46:20 +02:00
Michael Kohl
db17e98804
Unique IDs for hidden article_archived fields ( #9048 )
2020-07-01 11:35:29 +02:00
