rhymes
5782ffd7e0
Use published scope for articles ( #2374 )
...
* Use published scope for articles
* Fix variable name
* The sequencing in the union query matters
* Fix spec
* Restore a published: true condition
* This test is actually misleading due to the union
* Revert this change, not sure why it's not a relation
* Fix useless diff
2019-04-11 13:18:26 -04:00
cyrillefr
4fd66372dc
Enable Layout/AlignParameters ( #2340 )
...
Check if the parameters on a multi-line method call or definition are aligned.
Resolves : #2021
2019-04-08 18:47:34 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Ben Halpern
f280d9e266
Fix a couple things and modify dev digest logic ( #1954 )
2019-03-03 18:25:39 -08:00
Ben Halpern
c93bc48010
Fix issue with boosted article in email digest ( #1936 )
...
* Adjust email digest
* Fix for missing user.experience_level
* Fix direction of greater than
* Adjust tests for new criteria
2019-03-01 13:51:06 -08:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
rhymes
1b60ee5009
Use timezone aware methods ( #893 )
...
* Use timezone aware datetime methods
* Use timezone aware date parse for GitHub issue tag
* Introduce a bit of chaos programming using Zonebie
Zonebie uses a random timezone to run tests, it's a really good way to see if the code is timezone dependent or not.
* Convert GitHub issue date as UTC
2018-10-18 16:26:29 -04:00
Arun Kumar
0a0e9fd294
Refactor ( #596 )
2018-07-23 11:49:27 -04:00
Mac Siri
40f488d991
Migrate to Travis CI (part 2) ( #591 )
...
* Update Travis.yml
* Update README
* Update README
* Adjust test to not rely on env vars
* Update encryption
* Refactor
* Update env key
* Stub AWS calls
* Create ApplicationConfig
* Fix specs
* Fix lint
* Update ApplicationConfig
* Remove travis env vars
* Fix lint
* Extend character limit to 100
* Add env to travis
* Take out auto-restart after deploy
* Immediately discarded test cache
* Stub GA in request specs
* Stub Pusher
* Fix broken specs
* Update fixture
* Add CodeClimate id
* Change CodeClimate key
* Remove merge mistakes
* WIP
* Add Envied gem & Change README
* Add missing keys
* Add missing key
* Update fixture
* Fix broken spec
* Add Slack Notification for Travis
* Fix wording
* Fix typo
2018-07-20 20:17:18 -04:00
Ben Halpern
524052234a
Add email_digest_eligible check to non-following emails ( #278 )
2018-05-03 17:34:31 -04:00
Ben Halpern
f2101410ea
[WIP] Improve article boosting abilities and insights ( #237 )
...
* Update email subjects split test
* Create alternate editor
* Add proof of concept to emails
* Add utm for internal nav
* Add ability to boost in DEV Digest
* Adjust articles.scss
* Adjust article_form.scss
* Remove unnecessary files
* Remove files from PR
* Adjust boosted email settings
* Conditionally include organization in additional box
* Modify schema.rb
2018-05-02 12:24:54 -04:00
Ben Halpern
b4695151a8
Add featured clause to email logic for non-following ( #163 )
...
* Change loop in email_digest to find_each
* Add featured clause to email logic for non-following
2018-03-30 12:18:24 -04:00
Ben Halpern
4f1c771b55
Modify fresh date to be a few days ago rather than a month ago ( #154 )
2018-03-28 15:51:14 -04:00
Ben Halpern
4fa675d792
Update email logic to not get own articles ( #153 )
...
* Add where published true clause in email logic
* Update email logic to not get own articles
* Customize email digest subject
2018-03-27 16:18:29 -04:00
Ben Halpern
a06b907536
Add where published true clause in email logic ( #152 )
2018-03-27 15:55:43 -04:00
Ben Halpern
99fd30fa25
Modify email digest and create rake task ( #151 )
2018-03-27 15:21:59 -04:00
Mac Siri
9d32af7b6c
Implement periodic email digest ( #123 )
...
* Create EmailDigest WIP
* Add email_digest_periodic to User model
* Add email digest setting to notification
* Draft thoughts (?) WIP
* Implement EmailDigest's features
* Remove hard-coded email digest vars
* Create spec for EmailDigest
* Fix something
* Temp work
* Run migration & Yarn
* Move email logic out of EmailDigest
* Improve email logic
* Improve EmailLogic'specs
* Update copy
* Change positive_reactions_count limit
For non-followed articles we should have a higher limit. So this change modifies that.
2018-03-27 13:29:08 -04:00
