dependabot[bot]
dfedeaee68
Bump jest from 27.4.7 to 27.5.0 ( #16446 )
...
Bumps [jest](https://github.com/facebook/jest ) from 27.4.7 to 27.5.0.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/compare/v27.4.7...v27.5.0 )
---
updated-dependencies:
- dependency-name: jest
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-07 12:02:10 -07:00
Arit Amana
63c957b12d
Implement Unified Embeds for StackExchange and StackOverflow URLs ( #16415 )
...
* complete implementation and add specs
* improvements
* more robust condition
* update API version; re-record VCR cassettes
* PR review comments
2022-02-07 11:21:11 -05:00
Mac Siri
0559a808c4
Allow nil pubDate in Podcast sorting ( #16349 )
...
* Allow nil pubDate in Podcast sorting
* Choose a shorter syntax
* Typo
2022-02-07 11:18:51 -05:00
Nick Taylor
0132ef67ee
Added a custom Cypress command to get the modal compoonent. ( #16439 )
2022-02-07 11:01:31 -05:00
Jeremy Friesen
30a894a6eb
Removing deprecated User methods ( #16435 )
...
* Removing deprecated User methods
Related to #15762 , #15691 , and #15624
* Bump for travis
2022-02-07 10:32:58 -05:00
dependabot[bot]
0a07ae8fe9
Bump rouge from 3.27.0 to 3.28.0 ( #16421 )
...
Bumps [rouge](https://github.com/rouge-ruby/rouge ) from 3.27.0 to 3.28.0.
- [Release notes](https://github.com/rouge-ruby/rouge/releases )
- [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rouge-ruby/rouge/compare/v3.27.0...v3.28.0 )
---
updated-dependencies:
- dependency-name: rouge
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-07 09:58:50 -05:00
Suzanne Aitchison
8a14504a8e
Add accessible color picker component ( #16385 )
...
* add colorpicker component
* add tests
* separate out label, change swatch border
2022-02-07 14:30:02 +00:00
dependabot[bot]
bac1e83131
Bump sidekiq-unique-jobs from 7.1.12 to 7.1.14 ( #16419 )
...
Bumps [sidekiq-unique-jobs](https://github.com/mhenrixon/sidekiq-unique-jobs ) from 7.1.12 to 7.1.14.
- [Release notes](https://github.com/mhenrixon/sidekiq-unique-jobs/releases )
- [Changelog](https://github.com/mhenrixon/sidekiq-unique-jobs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mhenrixon/sidekiq-unique-jobs/compare/v7.1.12...v7.1.14 )
---
updated-dependencies:
- dependency-name: sidekiq-unique-jobs
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-07 07:19:16 -07:00
Jeremy Friesen
446e74ca83
Documenting and addl testing FeatureFlag.enabled? ( #16420 )
...
Prior to this commit, we had a single test for `FeatureFlag.enabled?`,
namely that it delegates to `Flipper.enabled?`. This commit adds some
tests to both verify behavior and communicate to developers the
intentions of the related methods:
- `FeatureFlag.enabled?`
- `FeatureFlag.accessible?`
My hope is the documentation and tests will help address the horrors
mentioned in conversation in #16416 :
> I have lived the horrors of having a feature flag accidently
> flipped or incorrectly setup in the first place and half baked
> functionality going live.
Note: I'm not proposing that we test other `Flipper` methods, but
instead to ensure that we're testing and documenting the behavior of
what I believe to be the two primary mechanisms of "putting something
behind a feature flag."
Related to #16406 , #16416
2022-02-07 08:53:30 -05:00
Jeremy Friesen
75ae759465
Short-circuiting parsing any articles to update ( #16413 )
...
* Short-circuiting parsing any articles to update
Setting a field that is to help track from where we received an image.
Related to #16075 and #16407 .
See [Slack Thread][1] for all the details
[1]:https://forem-team.slack.com/archives/CSY5KKK9U/p1643916711077719
* Fix
* Apply suggestions from code review
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
2022-02-04 11:13:01 -05:00
Jeremy Friesen
765df66084
Scoping the :listing routes to feature ( #16406 )
...
This commit builds on the conditional rendering of navigation links by
adding a routing constraint to all :listing routes.
The impact is, if we were to disable the listing feature (e.g.,
`FeatureFlag.disable(:listing_feature_enabled)`) all requests to `GET
/listings` (and those drawn in the [config/routes/listings.rb][1] file)
would return a 404 response.
Related to forem/rfcs#291, #16335 , #16338 , #16362 .
Testing this change:
1. Start your local application (e.g. `$ bin/startup`)
2. Go to http://localhost:3000/listings
3. You should get a Successful response.
4. Now disable the feature (e.g. `$ bin/rails r \
"FeatureFlag.disable(:listing_feature_enabled)"`)
5. Refresh http://localhost:3000/listings
6. You should get an `ActiveRecord::RecordNotFound` error; because the
application is now looking for a user or org named "listings"; in other
words we're not routing `GET "/listings"` to `listings#index` controller
action.
7. Now enable the feature (e.g. `$ bin/rails r \
"FeatureFlag.enable(:listing_feature_enabled)"`)
8. Refresh http://localhost:3000/listings
9. You should get a Successful response.
10. Goto 4
This commit is intended to be the penultimate change before we toggle
the listings section off by default.
[1]:c2ce2c32d5/config/routes/listing.rb (L1)
2022-02-04 10:13:56 -05:00
Jamie Gaskins
a9cdb2bae2
A suspended user returns 403 instead of 500 ( #16408 )
2022-02-04 09:42:23 -05:00
Nick Taylor
52e4e571b7
Reworked some webpack aliases as prework for #16174 . ( #16412 )
2022-02-04 06:34:37 -05:00
dependabot[bot]
a309d09027
Bump simple-get from 3.1.0 to 3.1.1 ( #16411 )
...
Bumps [simple-get](https://github.com/feross/simple-get ) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/feross/simple-get/releases )
- [Commits](https://github.com/feross/simple-get/compare/v3.1.0...v3.1.1 )
---
updated-dependencies:
- dependency-name: simple-get
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-04 08:58:05 +00:00
ludwiczakpawel
baa4ea1ed0
Applying Crayons to Content Manager pages ( #16375 )
...
* .
* comments
* .
* badges new
* edit podcasts
* edit badges
* whoops
* fixes
* like
* like
2022-02-04 09:31:59 +01:00
Suzanne Aitchison
e8154fb19c
Copy organization secret code to clipboard ( #16358 )
...
* init copy to clipboard functionality for org secret code
* add cypress test
* woops
2022-02-04 08:22:03 +00:00
Daniel Uber
99307167f7
I18n's short format for times differs from "%b %e", update test ( #16414 )
...
This passed in the branch because the last commit was on a two digit
day (so the digit padding wasn't needed or expected, it checked "Jan 30" ==
"Jan 30", but today "Feb 4" != "Feb 4")
2022-02-03 15:49:09 -06:00
yheuhtozr
e45536af37
app/models i18n ( #16124 )
...
* app/models etc i18n
* delete ja.yml
* fix for PR review
* fix for spec
* delete ja.yml
* fix for spec updated
2022-02-03 13:41:42 -05:00
yheuhtozr
c4778d832e
app/controllers & decorators i18n ( #16126 )
...
* app/controllers (& decorators) i18n etc
* tidy key names
* update keys
* delete ja.yml
* delete an involved ja.yml
* fix for PR review
* fix for spec
* delete ja.yml
2022-02-03 13:35:56 -05:00
dependabot[bot]
aa7b8d9f62
Bump rubocop from 1.25.0 to 1.25.1 ( #16410 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.25.0 to 1.25.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.25.0...v1.25.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-03 13:29:40 -05:00
Jeremy Friesen
c17fa11875
Bypassing validiation for data script ( #16407 )
...
* Bypassing validiation for data script
Prior to this commit, we attempted to run a script against all articles
using validation. In the case of DEV, we have lots of articles that
would no longer validate. This change now updates the column value
without running validation.
Relates to #16075
* Bump for travis
2022-02-03 13:29:14 -05:00
dependabot[bot]
c372d0a8f7
Bump honeycomb-beeline from 2.8.1 to 2.8.2 ( #16409 )
...
Bumps [honeycomb-beeline](https://github.com/honeycombio/beeline-ruby ) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/honeycombio/beeline-ruby/releases )
- [Changelog](https://github.com/honeycombio/beeline-ruby/blob/main/CHANGELOG.md )
- [Commits](https://github.com/honeycombio/beeline-ruby/compare/v2.8.1...v2.8.2 )
---
updated-dependencies:
- dependency-name: honeycomb-beeline
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-03 11:24:11 -07:00
Anna Buianova
9a11beec50
Reorganized article published_at/dates specs ( #16403 )
2022-02-03 19:04:58 +03:00
dependabot[bot]
eb866e729f
Bump bootsnap from 1.10.2 to 1.10.3 ( #16399 )
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.10.2 to 1.10.3.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.10.2...v1.10.3 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-03 09:02:06 -07:00
Suzanne Aitchison
6d0d8f739d
address flake in top tags test ( #16405 )
2022-02-03 15:48:13 +00:00
Suzanne Aitchison
3454750ad3
Place gifs correctly regardless of center tag ( #16404 )
...
* place gifs correctly regardless of center tag
* typo
* make sure the same gif src can be used twice in a post
* approach in css
2022-02-03 15:44:44 +00:00
Michael Kohl
a1eb6358db
Easier feature flag handling for Cypress ( #16379 )
...
* Add RailsEnvConstraint for routes
* Add feature flags API
* Add Cypress commands
* Add show action, update commands, add e2e test
* Update cypress/integration/seededFlows/toggleFeatureFlags.spec.js
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Move helper from command to test file
* Update documentation
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2022-02-03 10:42:13 -05:00
VISHAL DEEPAK
14a945326d
Add boolean attribute main_image_from_frontmatter to indicate if cove… ( #16075 )
...
* Add boolean attribute main_image_from_frontmatter to indicate if cover image was set via frontmatter
* use article model spec for main_image_from_frontmatter test cases
* Add data migration script and spec for main_image_from_frontmatter for articles
* Update app/models/article.rb
Co-authored-by: Jeremy Friesen <jeremy.n.friesen@gmail.com>
Co-authored-by: Jeremy Friesen <jeremy.n.friesen@gmail.com>
Co-authored-by: Michael Kohl <me@citizen428.net>
2022-02-03 09:16:48 -05:00
Suzanne Aitchison
a168f0c85a
Change UI instances of "vomit" to "flag" ( #16397 )
...
* change UI instances of vomit to flag
* update spec
* verify tests against i18n string
2022-02-03 12:22:32 +00:00
Anna Buianova
c2ce2c32d5
Improved article date specs ( #16395 )
...
* Improved article date specs
* Say rejects
2022-02-03 10:07:42 +03:00
Fernando Valverde
b1c0a8d631
Add special case for DEV Android app ( #16382 )
2022-02-02 15:25:14 -06:00
ludwiczakpawel
e9343e2794
Applying Crayons to some Customization pages ( #16383 )
...
* display ads
* nav links
* .
* Update app/views/admin/navigation_links/_add_navigation_link_modal.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* spec
* spec
* whoops
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2022-02-02 21:33:12 +01:00
dependabot[bot]
fa7fcaa602
Bump redis from 4.5.1 to 4.6.0 ( #16398 )
...
Bumps [redis](https://github.com/redis/redis-rb ) from 4.5.1 to 4.6.0.
- [Release notes](https://github.com/redis/redis-rb/releases )
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/redis/redis-rb/compare/v4.5.1...v4.6.0 )
---
updated-dependencies:
- dependency-name: redis
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-02 11:37:25 -07:00
Suzanne Aitchison
1b98b03bde
Allow users to pause gifs in a post ( #16314 )
...
* working POC
* refactors and styling
* add some comments
* css tweaks to keep sizes in step
* add cypress test
* comment added to css
2022-02-02 13:45:55 +00:00
dependabot[bot]
c1a60539b9
Bump pg from 1.3.0 to 1.3.1 ( #16387 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-01 14:16:55 -06:00
Arit Amana
7e6be96980
update specs with loops ( #16388 )
2022-02-01 13:50:56 -05:00
dependabot[bot]
33c5680450
Bump js-routes from 2.2.1 to 2.2.2 ( #16386 )
...
Bumps [js-routes](https://github.com/railsware/js-routes ) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/railsware/js-routes/releases )
- [Changelog](https://github.com/railsware/js-routes/blob/master/CHANGELOG.md )
- [Commits](https://github.com/railsware/js-routes/compare/v2.2.1...v2.2.2 )
---
updated-dependencies:
- dependency-name: js-routes
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-01 11:34:15 -07:00
Jeremy Friesen
b4b1212a33
Adding conditional rendering of navigation links ( #16362 )
...
Prior to this commit we had an inline logic check on whether or not to
render a navigation link. As we are looking to rollout the feature flag
for Listings, we needed to add another somewhat complex conditional.
This commit moves the inline conditionals to a helper function, which
makes testing the logic far easier. Especially since we need to bombard
the tests with the combination of 3 different boolean checks. (And one
of those boolean checks requires even more but could be stubbed).
There should be no UI differences, as we're presently assuming the
Listings feature is enabled.
Related to forem/rfcs#291
2022-02-01 12:23:58 -05:00
Arit Amana
2a56c19d86
Implement Unified Embeds for Glitch URLs ( #16378 )
...
* modify GlitchTag for Unified Embed
* complete implementation and add specs
* escape dots in regex; change capture group name
* address PR review comments
* rubocop fixes
* update comment
* pr review changes
* nudge Travis
* nudge Travis
2022-02-01 12:01:26 -05:00
Daniel Uber
932a3b3575
Ensure the domain of other_url is different from top_url ( #16373 )
...
This failed in a main build today, testing shows this may give the
same domain very rarely
10_000.times.map do
Addressable::URI.parse(Faker::Internet.url).domain == Addressable::URI.parse(Faker::Internet.url).domain
end.tally
=> {false=>9998, true=>2}
Use a .dev domain (which is absent from faker's internet domain_suffix
list at
https://github.com/faker-ruby/faker/blob/master/lib/locales/en/internet.yml )
to ensure two unique domains are compared.
remove link to faker internals
2022-02-01 09:18:49 -05:00
Suzanne Aitchison
0dd77bcf52
Fixes for home nav link positioning ( #16381 )
...
* Add new DUS to fix home nav link positioning
* fix bug in local db seeding
2022-02-01 14:06:51 +00:00
dependabot[bot]
5904543295
Bump @storybook/builder-webpack5 from 6.4.14 to 6.4.17 ( #16371 )
...
Bumps [@storybook/builder-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/lib/core ) from 6.4.14 to 6.4.17.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.17/lib/core )
---
updated-dependencies:
- dependency-name: "@storybook/builder-webpack5"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-01 10:56:59 +00:00
dependabot[bot]
a0fdf079b2
Bump @storybook/preact from 6.4.10 to 6.4.17 ( #16365 )
...
Bumps [@storybook/preact](https://github.com/storybookjs/storybook/tree/HEAD/app/preact ) from 6.4.10 to 6.4.17.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.17/app/preact )
---
updated-dependencies:
- dependency-name: "@storybook/preact"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-01 10:38:33 +00:00
Jeferson S. Brito
4f67acf016
Fix text color on user confirmation alert message ( #16131 )
2022-02-01 10:29:53 +00:00
dependabot[bot]
ae33c76077
Bump canvas from 2.8.0 to 2.9.0 ( #16368 )
...
Bumps [canvas](https://github.com/Automattic/node-canvas ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/Automattic/node-canvas/releases )
- [Changelog](https://github.com/Automattic/node-canvas/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Automattic/node-canvas/compare/v2.8.0...v2.9.0 )
---
updated-dependencies:
- dependency-name: canvas
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-01 10:00:35 +00:00
dependabot[bot]
b90c46bfcd
Bump @storybook/addon-a11y from 6.4.14 to 6.4.17 ( #16367 )
...
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y ) from 6.4.14 to 6.4.17.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.17/addons/a11y )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-01 10:00:03 +00:00
Suzanne Aitchison
f1864847e7
Make home link an admin-customisable navigation link ( #16268 )
...
* move home link to a customisable navlink
* add trailing slash for path
* update specs
* replace positions, set home link to -1
* add update script for adding home navigation link
* update data update script
2022-02-01 09:27:09 +00:00
dependabot[bot]
62d3191a91
Bump @storybook/addons from 6.4.14 to 6.4.17 ( #16369 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-01 11:31:33 +07:00
Ryan Palo
09245d41d0
seeds.rb: Add registered_at to admin user to fix setup seed issue. ( #16377 )
2022-02-01 11:27:33 +07:00
Nick Taylor
8c697313df
Removed the connect feature flag from seed data. ( #16376 )
2022-01-31 21:02:05 -05:00
