Commit graph

747 commits

Author SHA1 Message Date
Ben Halpern
8c740b77ac
Add additional fragment caching to home page (#2401) 2019-04-12 00:42:28 -04:00
rhymes
5782ffd7e0 Use published scope for articles (#2374)
* Use published scope for articles

* Fix variable name

* The sequencing in the union query matters

* Fix spec

* Restore a published: true condition

* This test is actually misleading due to the union

* Revert this change, not sure why it's not a relation

* Fix useless diff
2019-04-11 13:18:26 -04:00
cyrillefr
4fd66372dc Enable Layout/AlignParameters (#2340)
Check if the parameters on a multi-line method call or definition are aligned.

Resolves: #2021
2019-04-08 18:47:34 -04:00
Ben Halpern
5f3fd96960
Modify social share button and functionality (#2316)
* Modify social share button and functionality

* Some nightmode changes tossed in

* Style adjustments and test snapshot fix
2019-04-06 14:49:52 -04:00
rhymes
3a53d5797e Upgrade Rails to 5.2.3 (#1408) 2019-04-03 13:08:59 -04:00
Ben Halpern
b0ad7f8c74
Some night theme code, other style adjustments, and extracted app name into ENV var (#2289)
* Style, theme adjustments, plus generalization work

* Modify login cta style on home page

* Modify text
2019-04-02 13:10:28 -04:00
Ben Halpern
490645ea92
Add sponsors to sponsors page and add sponsor order field (#2284)
* Add sponsorship page

* Fix schema

* dev => DEV
2019-04-01 18:24:47 -04:00
Ben Halpern
cc0e4b40dd
Allow orgs to be marked as sponsors (#2282)
* Allow orgs to be marked as sponsors

* Remove community sponsor condition
2019-04-01 16:41:25 -04:00
Mac Siri
beca74c587 Revert "Make comic sans default (#2257)"
This reverts commit 8865422bcf.
2019-04-01 12:49:46 -04:00
Ben Halpern
8865422bcf
Make comic sans default (#2257)
* Make comic sans default

* Add safe navigation for comic sans

* Add rails production clause

* Do html variant dismissal differently

* Do html variant dismissal differently
2019-04-01 08:48:51 -04:00
rhymes
b789e5d78d Add SRI to script tags where applicable (#2153)
* Add SRI to script tags

* Update app/views/articles/_hiring_form.html.erb

Good point :)

Co-Authored-By: rhymes <rhymesete@gmail.com>
2019-03-22 14:14:59 -04:00
Andrew Bone
e96bf2e329 Add discernible text for organization link (#2168) 2019-03-22 13:54:46 -04:00
Ben Halpern
7f27aa32c7
Add areas for DEV Shop displays on left sidebar (#2162)
* Add areas for DEV Shop displays

* Update display_ad spec

* Add organization to spec

* Add orgs to specs properly
2019-03-22 09:57:37 -04:00
rhymes
22ceaf7689 Remove klipse script unused partial (#2164) 2019-03-21 16:58:40 -04:00
rhymes
6435785017 Add alternative text for organization logo (#2148) [ci skip] 2019-03-21 12:52:22 -04:00
rhymes
df2621a8c0 Implement image upload's error handling (#2018) 2019-03-21 12:31:51 -04:00
Tim Lange
3494264404 Enabled rubocop/lint (#2130)
* WIP: Enabled rubocop/lint

* FIX: Fixed failing test

* FIX: Small change to return

* FIX: Changed indent
2019-03-21 10:53:44 -04:00
Ben Halpern
7bf37108b1
Night theme improvements + small fixes (#2114) 2019-03-19 13:36:30 -04:00
Ben Halpern
91bd6322ad
Add organic page view sums and modify seo boostables (#2109)
* Add organic page view sums and modify seo boostables

* Add score minimum for SEO boostable
2019-03-19 09:32:26 -04:00
Ben Halpern
e3760fc215
Add originally_published_at for more accurate crossposted info (#2076) 2019-03-16 18:11:39 -04:00
Keshav Biswa
8d57d45ecc Rubocop Style cops enabled (#2056)
* Rubocop enabled style/alias

* Enabled Style/ArrayJoin Cop

* Enabled Style/Attr

* Enabled Case Equality

* Enabled CharacterLiteral

*  Enabled ColonMethodCall Cop

* Enabled CommentAnnotation cop

* Enabled PreferredHashMethods Cop

*  Enabled DoubleNegation Cop

* Enabled EachWithObject Cop

* Enabled EmptyLiteral Cop

* Enabled EvenOdd Cop

* Enabled IfWithSemicolon Cop

* Enabled Lambda and LambdaCall Cop

* Enabled LineEndConcatenation Cop

* Enabled ModuleFunction Cop;

* Enable NegatedIf and NegatedWhile Cop

* Enabled NilComparison Cop

* Enabled Not Cop

* Enabled NumericLiterals Cop

* Enabled OneLineConditional Cop

* Enabled PercentLiteralDelimiters Cop

* Excluded internal/users_controller from negated_if cop

* Reverted the double negation change from github_issue_tag and github_issue.rb"

* Enabled PerlBackrefs Cop

* Changed Regexp.last_match(1) to Regexp.last_match(0)

* Enabled proc cop

* Enabled RaiseArgs Cop

* Reverted Regexp.last_match(0) to Regexp.last_match(1)

* Enabled SelfAssignment Cop

* Enabled SingleLineMethods Cop

* Enabled SpecialGlobalVars Cop

* Enabled VariableInterpolation Cop

* Enabled WhenThen Cop

* Enabled WhileUntilModifier Cop

* Enabled WordArray Cop

* Enabled IfUnlessModifier Cop

* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Mario See
d8709c0334 Implement open inbox for dev-connect (#1563) 2019-03-15 14:39:57 -04:00
Ben Halpern
be0f55f9f4
Remove shecoded sidebar (#2059) 2019-03-13 17:34:02 -04:00
Anna Buianova
343f109c0f Optimize stories (#1988)
* Add db index to articles path

* Slight stories optimizations

* Select only needed fields for the flare tag

* Revert the last commit (to check builds)

* Return selecting only needed fields for tag
2019-03-12 16:38:22 -07:00
Ben Halpern
ecb9f6da3d
Remove some hardcoded shecoded stuff (#2011) 2019-03-08 18:08:48 -08:00
rhymes
ca79dac1bc Fix sidebar widget header for she coded (#2004) 2019-03-08 12:26:53 -05:00
Ben Halpern
138278462a
Add shecoded sidebar/homepage decorations (#2003)
* Add shecoded sidebar/homepage decorations

* Add additional functioanlity to /shecoded

* Fix typo
2019-03-08 04:47:31 -08:00
Ben Halpern
a17cfe7d33
Add time ago to recent posts in feed (#1981)
* Add time ago to recent posts in feed

* Modify time details
2019-03-05 13:40:27 -08:00
Anna Buianova
0ac8eb1f73 Make less queries when displaying articles flare tags (#1957)
* Make less queries when displaying flare tag

* Make less sql queries to display articles flare tags
2019-03-05 07:27:51 -08:00
Ben Halpern
fd83b33603
Add shecoded template to v2 (#1972) 2019-03-04 12:41:37 -08:00
Anna Buianova
854c7a773c Rubocop fixes (#1966) 2019-03-04 06:18:09 -08:00
Steve Layton
3cc0f27eb3 Remove stray forward slash in RSS feed builder (#1943)
closes #1942

- removed stray `/` from lines 17 and 18.
2019-03-02 07:50:57 -08:00
Glenn Carremans
281330fe16 Fix linting issues in app/views/articles (#1848) 2019-02-28 17:23:06 -05:00
Ali Spittel
704b7bce9c Feature/autosave editor (#1633)
* Add myself to core contributors

* add myself to the core contributors

* implement autosave in sessionStorage

* clear sessionstorage on save

* add new changes flag

* add clear  button and css for it

* add clear button functionality

* make clear session storage only run if save is successful

* update jest snapshot for autosave

* add a few tests

* add a few tests

* add test for clear button

* make autosave work for title, tags, and cover image

* remove console.log

* make clear button into a message instead

* move to button with no styling instead of span

* remove warning on refresh

* remove warning on refresh

* move to localstorage so that persists across tabs

* fix blip on change from HTML to JSX

* make confirm work properly

* fix css jump for v2 editor

* fix v2 editor height jump

* remove unused onKeyUp prop

* indent _v2_form.html.erb file

* indent v2 editor erb

* Update package.json with missing package
2019-02-28 07:00:58 -08:00
Mario See
ae484fbead add username to author info (#1912)
in both sticky nav on the side and about the author section at the end of the article
2019-02-27 08:25:47 -08:00
Molly Struve
981f4ed893 Include Article ID in Bottom Content Cache Key (#1773) 2019-02-21 15:13:07 -05:00
Ben Halpern
20d1c8bab7
Add video to additional home feed context (#1815) 2019-02-17 15:57:25 -04:00
Anna Buianova
1cc0fccbf7 Reduce the number of sql queries for articles comments #1606 (#1766)
* Reduce the number of sql queries for articles comments

* Refactor comments tree display

* Refactor retrieving the comments tree

* Remove comments tree view object

* Update score in comments spec for consistent order
2019-02-16 18:14:15 -04:00
Ben Halpern
bce0b4fff6
Remove harsh video restriction and add video duration (#1811)
* Remove harsh video restriction and add video duration

* Fix video meta data and tests

* Modify video tests

* Rescue video duration fetch error

* Change log to puts in test
2019-02-16 17:42:44 -04:00
Ali Spittel
09c82fe69e Prevent double article submission on v1 editor (#1791) 2019-02-13 12:10:54 -05:00
Sean
1acd5b78ef Display tag moderators on tag page (#1739) 2019-02-12 14:58:31 -05:00
Phil Nash
d8de2b0d14 Use <web-share-wrapper> for article sharing (#1524) 2019-02-11 16:05:52 -05:00
Ben Halpern
92b24a9978
Add html_variant split testing to /badge (#1763)
* Add /badge html_variant

* Fix some of the linting
2019-02-08 12:45:14 -04:00
Ben Halpern
4bff494adc
Ping comments to pre-warm new comment trees (#1755) 2019-02-06 21:45:24 -04:00
Ben Halpern
71a419e5ee
Add profile_updated_at and github_repos_updated_at to avoid extra fet… (#1754)
* Add profile_updated_at and github_repos_updated_at to avoid extra fetches

* Fix variant_number issue

* Fix test
2019-02-06 20:39:15 -04:00
Ben Halpern
7d6c85a294
RSS feed optimizations (#1752)
* RSS feed optimizations

* Update app/views/articles/feed.rss.builder

Co-Authored-By: benhalpern <bendhalpern@gmail.com>

* Update app/controllers/articles_controller.rb

* Update app/controllers/articles_controller.rb
2019-02-06 20:31:58 -04:00
Peter Frank
9c0bfd6cd0 Update DigitalOcean (#1753)
- Updated DigitalOcean tagline/link
- On homepage and sponsors page
2019-02-06 19:12:53 -04:00
Ben Halpern
2d97a5d837
Improve performance for additional content boxes and tags index (#1750)
* Improve performance for additional content boxes and tags index

* Modify followed_articles endpoint with new classic article api
2019-02-06 16:50:35 -04:00
rhymes
ecad47eb3c Add title to badge images (#1738) 2019-02-05 15:16:15 -05:00
Ben Halpern
152f4a52ea
Remove unnecessary queries (#1717)
* filter unnecessary queries

* Adjust article query in a couple places

* Replace tagged_with in main tag query

* Cache_tagged_with additional queries

* Modify test

* Modify cached_tagged_with to account for single tags

* Add cached_tagged_with in a few more places
2019-02-02 21:40:34 -04:00