Commit graph

213 commits

Author SHA1 Message Date
Ben Halpern
1ae463b708
Adjust look of bottom article actions (#1085) 2018-11-08 11:10:06 -05:00
Ben Halpern
119b86c655
Fix action bar issue and adjust cache_buster (#1082) 2018-11-07 18:55:07 -05:00
Gatlee
b865ad9f69 Improve optimistic rendering to article reactions (#681)
* Refactor article reactions for increased readability and to insert optimistic rendering later. No functional changes

* Added optimistic rendering

* Fixed comments to fit with style

* Reverts state on error as well
2018-11-07 12:24:55 -05:00
Jasmeet Singh Saini
908e82cf9e Implement cancel button comment edit (#331) 2018-11-05 13:48:56 -05:00
Andy Zhao
ebd4b50f3f Use Preact for asynchronous rendering for /settings/integrations (#986)
* Set default styles and move button style out of form

* Add MVP of Preact /settings/integrations

* Change background color on hover and focus

* Remove unused constructor

* Improve optimistic rendering

* Add display name

* Use loading indicator for optimistic rendering

* WIP test

* Add basic snapshot tests
2018-10-31 15:51:07 -04:00
Florin Ionce
56ee5835e4 Fix spacing issue for the close button in the podcast bar (#1039) 2018-10-31 11:16:41 -04:00
Ben Halpern
359cc71b64
Add ability for users to publish series (#1034) 2018-10-29 13:04:42 -04:00
Ben Halpern
ae3ec2e237
Add/fix org call-to-action box/copy (#1000) 2018-10-24 13:49:57 -04:00
Mac Siri
801043ab0d
Mute Pusher errors (#993) 2018-10-24 11:12:34 -04:00
Ben Halpern
d5ceff4b12
Update/fix org settings (#992)
* Update/fix org settings

* Small adjustment to an unrelated rake task

* Update app/views/users/_org_non_member.html.erb
2018-10-23 17:21:17 -04:00
Ben Halpern
735a96432c
Add usability features to html_variants (#991) 2018-10-23 16:23:48 -04:00
Ben Halpern
90861366df
Add additional config to v2 editor (#980)
* Add additional config to v2 editor

* Fix typo
2018-10-23 12:41:19 -04:00
Ben Halpern
302e8f202d
Add HTML variants for cta optimization and other nav bar adjustments (#970)
* Add HTML variants for cta optimization and other nav bar adjustments

* Fix 1==1 non-random mistake

* Spruce up org call-to-action

* Change default text color

* Add html variant trial and success request specs

* Fix article sidebar caching issue

* One line adjustment

* Modify schema

* Add include ActionView::Helpers::TagHelper to user_tag_spec

* Modify follow_button to remove session context

* Dummy commit

* Change Edit Article to Edit Post

* Dummy commit

* Fix rubocop concerns

* Fix rubocop style
2018-10-22 17:03:57 -04:00
Nick Karnik
2136b105a3 Implement ability to style text in comments using hotkeys (#959)
* Resolves #891
    * This is applied to root level comments as well as nested replies.
    * We are handling latest browsers and special cases for FF, IE8/9/10
    * All newer browser except FF support undo/redo functionality in the exact reverse order of text insertion
    * Refactored some code
    * Support for Bold & Italic text
    * Support for Text Links
    * In a subsequent change, we can consider adding hotkey for image URL
        * Didn't add this feature at the moment since there's no universally accepted key-combination for image URL's that I know of
    * IE 8-11 is not supported because it is a bit convoluted and I don't have a way to test it reliably
        * We can revisit this if it is really needed and find a jQuery plugin to handle it
2018-10-19 15:39:22 -04:00
Mac Siri
c35544a154 Replace sprocket-es6 with new uglifier feature (#928) 2018-10-19 13:12:07 -04:00
Ben Halpern
ca403ee01e
Adjust article show view css (revert sticky css) (#954)
* Adjust article show view css

* Change color subtly
2018-10-18 16:02:54 -04:00
Juan Manuel Ramallo
6ada73136b [Article Actions] Using position sticky (#945) 2018-10-18 12:27:58 -04:00
Ben Halpern
8184baed83
Adjust analytics styling and accuracy (#951)
* Adjust analytics styling and accuracy

* Add video button back in
2018-10-18 12:19:49 -04:00
Ryan
95b2e181ff Add Medium URL to User's Profile (#943) 2018-10-18 11:39:39 -04:00
Albert Alises
63acc9b72a CSS height fix for Read Post button [Fixes #921] (#922)
* [Fix #909] [ci skip] Added links to testing libraries on testing.md, fixed typo

* Fixed height for READ POST button

* Fixed heigth for READ POST button
2018-10-15 15:21:52 -04:00
Ben Halpern
57fff54cd8
Remove es6 code from non-es6 area (#904) 2018-10-13 20:02:49 -04:00
Ben Halpern
221c363af0
Reduce queries in typical stories#show response + small fixes (#903)
* Reduce queries in typical stories#show response + small fixes

* Change const to git in non-es6 code
2018-10-13 19:38:38 -04:00
Ryan Palo
588ffeef09 Fix #848. Code inside Markdown inside Gist displays. (#902) 2018-10-13 14:28:39 -04:00
Nick Karnik
a3649b8d09 Added the ability to press Ctrl+Enter Or Command+Enter to submit comments. (#885)
* Resolves #245
    * This is applied to root level comments as well as nested replies.
    * We are ensuring that user has commented at least once which means
      they have accepted the code of conduct before

Style changes as per suggestions in code review
2018-10-13 14:24:53 -04:00
Ben Halpern
b13c09583f
Adjust modal to not interfere with pull-to-refresh (#888)
* Remove unnecessary code from onboarding

* Adjust pull-to-refresh button to account for open modal scenario
2018-10-11 16:45:43 -04:00
Ben Halpern
5194dc736c
Adjust onboarding modal styling for different screen sizes and production data (#883) 2018-10-10 16:58:04 -04:00
Ben Halpern
991458d1c3
Adjust onboarding slides (#882)
* Modify onboarding slides

* Remove user controller changes

* Modify onboarding slide font size

* Adjust small onboarding issues

* Modify onboarding styling

* Remove flash unstyles content
2018-10-10 16:00:20 -04:00
Felix Edelmann
763f97f76f Improve dashboard action buttons' styling (#808)
* Use full content width (one line with content below)
* Fix gap between actions
* Add hover color and transition for opacity
* Decrease font size a little bit
* Force break "POSTS" and "(123)" into two lines when width is 600-800px
2018-10-09 16:11:09 -04:00
Ben Halpern
28099f031c
Adjust article-form height (#870) 2018-10-09 12:03:02 -04:00
Ben Halpern
3ae3fb0652
Adjust placement of image button on small screen (#867)
* Adjust placement of image button on small screen

* Adjust orgsettings css for small screen

* Update snapshot for article form
2018-10-08 20:32:00 -04:00
Ben Halpern
e64782572e
Get way less cute with pull-to-refresh (#866) 2018-10-08 20:08:11 -04:00
Ben Halpern
e62ffd0ff5
Add editor version for users to try new editor (#861)
* Adjust form tagbar height

* Adjusted styling for various screen sizes

* Add editor_version field for users

* Adjust default opacity in v2 editor
2018-10-08 15:05:20 -04:00
Ben Halpern
0b2ecd44b3
Add pull-to-refresh for index views (#859) 2018-10-08 14:26:21 -04:00
Ben Halpern
f52f8b6437
Update image area and other editor functionality (#847) 2018-10-07 12:52:13 -04:00
Ben Halpern
87a7067a5c
Spruce up V2 editor look and feel (almost ready 🙂) (#846)
* Spruce up editor look and feel

* Update jest snapshots for editor

* Fix editor guide scoping issue
2018-10-07 11:06:52 -04:00
Arit Amana
5c245bdb4e Better alignment of "Select" and "Remove" buttons with Repo Titles in "Integrations" (#836)
* Syncing with Upstream master

* Dev Env Keys - Algolia and Github

* Pull from upstream master

* Remove commented code
2018-10-05 17:37:50 -04:00
Ben Halpern
ecb9645775
Make changes to editor (#837)
* Make changes to editor

* Make minor fixes and console log removals

* Fix test in article form

* Adjust rspec test
2018-10-05 16:03:06 -04:00
Ben Halpern
a761dfbc83
Finalize merge accounts (#820)
* Add initial remove association feature

* Add initial account deletion feature

* Add back in cursor pointer

* Update email text copy

* Update copy on email html

* Fix nav issue and add integration buttons to account
2018-10-04 12:27:37 -04:00
Benny Powers
c16e2aa480 Center article header image (#773) 2018-10-03 17:13:02 -04:00
Ben Halpern
483a7410af
Change impression event to view in Google Analytics (#805)
* Add tracking for home page featured impressions/clicks

* Change impression event to view in Google Analytics
2018-10-03 14:35:34 -04:00
Ben Halpern
a0491657dd
Add tracking for home page featured impressions/clicks (#804) 2018-10-03 14:05:00 -04:00
Jack Harner
2b0de7ee04 setting user-select to none on the top-bar profile image (#786) 2018-10-02 11:00:40 -04:00
Ben Halpern
7e48a23afa
Ben/add more recent posts to home feed (#775)
* Add meta to sidebar and adjust ranking algo

* Update home feed to show more recent posts from folks you follow

* Only show recent posts on home feed if user signed in
2018-09-30 14:05:59 -04:00
Ben Halpern
4205d50bd8
Make home feed more relevant and varied (#757) 2018-09-27 13:21:51 -04:00
38elements
e9cbbae5c5 Fix FOLLOWING button (#728) 2018-09-24 11:38:48 -04:00
Ben Halpern
160056a19d
Add organization users to sidebar and other org ajustments (#707) 2018-09-20 15:43:43 -04:00
Ben Halpern
2545b8d77f
Modify styling and classes for iOS safari /connect (#701) 2018-09-19 18:25:36 -04:00
Ben Halpern
e0c7ac970d
Modify reaction bar style (#665) 2018-09-15 13:25:38 -04:00
Ben Halpern
8074113663
Revert linting issues (#651) 2018-09-13 15:18:19 -04:00
Den McHenry
cf15295771 Fix table layout in posts (#429)
Three rules overriding table and cell defaults reduce readability of tables by

1. forcing full width irrespective of actual table contents, and
2. setting an arbitrary width of 1000px on each cell.

This seems to be the result of tinkering to improve table aesthetics by filling horizontal space, but this is a common error that seriously [degrades the readability of tabular data](https://alistapart.com/article/web-typography-tables#section2).

The first issue above is a bit confused: the width has been set to `100%`, and display has been set to `block`.

Setting a default table to 100% width will cause the children to adapt accordingly, achieving the desired result. But changing `table` to `block` breaks the relationship so that the children of the table no longer adapt to the full width. (They behave as though an anonymous parent table of the correct display type has been inserted, while the `table` element behaves like a generic block level element. They no longer will the table, though the table is technically full width.)

This probably explains the arbitrary width on data cells. It's set larger than the container, forcing the browser to resolve it against the available space and thus approximate the expected result of a default table with 100% width.

Rather than trying to fill horizontal space, it's better for readability to allow data cells to adapt to the size of their contents. A better option for aesthetics in blog posts on Dev.to is to remove the three rules deleted here that affect table layout and instead set left and right margins to `auto`, so that narrow tables are centered in posts, but wide tables can still extend beyond the normal content width of paragraphs as they do now.
2018-09-13 14:20:33 -04:00