Commit graph

1194 commits

Author SHA1 Message Date
Anna Buianova
75a977172c Fix notifications about the new child comments (#2233) 2019-03-29 12:51:10 -04:00
Jess Lee
ece498caf8 add form validation so points cannot be nil (#2236) 2019-03-28 17:42:43 -04:00
Anna Buianova
4b02fe87a4 Optimize sign in: Identity #2061 (#2231)
* Add unique index to identity

* Conditional uniqueness validations on identities

* Remove redundant Identity specs
2019-03-28 16:10:23 -04:00
Jess Lee
9f74fd3794 Clear cache when merging users (#2229) 2019-03-28 12:26:14 -04:00
Anna Buianova
9c56e4413a Rubocop fixes (#2232)
* Enable ClassVars cop

* Enable Style/MultilineBlockChain cop

* Enable Style/SignalException

* Remove config parts matching with the default config

* Fix rubocop issue

* Moved cops that need to be fixed into the .rubocop_todo.yml
2019-03-28 07:35:17 -04:00
Filip Defar
7a3b16c1e5 Extract "following" action from "show" in DashboardsController (#2212) 2019-03-27 17:03:53 -04:00
Lito
2ebd37aba2 Improved article slug generation (#2218)
* Improved article slug generation

Ruby on Rails has a built-in slug generator since Rails 2.2

This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6

* Ruby on Rails has a built-in slug generator since Rails 2.2

This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6

* Ruby on Rails has a built-in slug generator since Rails 2.2 

This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6

* Ruby on Rails has a built-in slug generator since Rails 2.2

This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6

* Ruby on Rails has a built-in slug generator since Rails 2.2 

This generator fix the slug generation when non english characters are used on title improving SEO. For example: https://dev.to/lito_ordes/redimensionando-imgenes-en-tiempo-de-ejecucin-con-packer-57c6

* Fix downcase transform on event model
2019-03-26 13:39:35 -04:00
Ben Halpern
d1e73dceba
Clean up new chat channel functionality and add tests (#2220) 2019-03-26 13:35:32 -04:00
Mario See
91968e3860 block/report abuse in dev-connect (#2074)
* block chat method

* block and report buttons

* styling

* more styling

* add id redirect

* remove whitespace

* authorize channel in block_chat method

* remove trailing whitespace

* make variable local

* validate using policy

* check channel direct

* fix comparison in chat_channel model

* fix channel variable
2019-03-26 11:53:30 -04:00
Ben Halpern
50c765ed10
Add several recommended tags for onboarding (#2217) 2019-03-26 10:51:36 -04:00
Glenn Carremans
cfd61b3b37 Inverted social icons in night theme (#2209) 2019-03-26 09:51:41 -04:00
Ali Spittel
ed1906b02e Fix dark theme issues with the pro dashboard (#2178) 2019-03-25 16:02:28 -04:00
Filip Defar
88fc2a66d3 Remove /dashboard/following_users route (#2191) 2019-03-25 14:49:09 -04:00
Anna Buianova
e1968e815b Extract new reaction notification to ActiveJob (#2122) 2019-03-25 13:54:21 -04:00
Abraham Williams
9cb40e546b Enables Rails cops (#2186)
* Enable Rails cops

* Fix Rails/DynamicFindBy

* Fix Rails/HttpStatus

* Fix Rails/Blank

* Fix Rails/RequestReferer

* Fix Rails/ActiveRecordAliases

* Fix Rails/FindBy

* Fix Rails/Presence

* Fix Rails/Delegate

* Fix Rails/Validation

* Fix Rails/PluralizationGrammar

* Fix Rails/Present

* Fix Rails/Output

* Fix Rails/Blank

* Fix Rails/FilePath

* Fix Rails/InverseOf

* Fix Rails/LexicallyScopedActionFilter

* Add Rails/OutputSafety to TODO

* Add Rails/HasManyOrHasOneDependent to TODO

* Add Rails/SkipsModelValidations to TODO
2019-03-25 09:25:55 -04:00
Glenn Carremans
9470ad8e7f Bug fix broken giphy url (#2180) 2019-03-24 08:43:35 -04:00
Brylie Christopher Oxley
1a10a344f3 Add social.coop (#2170) 2019-03-22 16:44:28 -04:00
Mike Coutermarsh
dd84051ce4 Social Card upgrade - Part 1 (#2090)
* Add HtmlCssToImage for generating images

This will be used by social_previews to convert the templates into images.

Setup a fallback image primarily for local dev, so that this won't cause
errors if authentication is missing.

Caching is setup to use contents of the html/css. So it with
autobust/generate a new image whenever the markup changes.

* Update Article social preview template to not be random

+ Being random breaks caching (since we generate cachekey by a SHA of html content)
+ Use Roboto for when generating via HTML/CSS to Image

* Update Tag social preview template to not be random

+ Make rand deterministic so it doesn't break caching

* Update user social preview template for html/csstoimage

* Update shecoded template to work with both url2png and htmlcsstoimage

* Add ability to respond to .png for social previews controller

When adding .png to the url, these routes will now generate an image and
redirect to it.

This leaves the existing pages as they were, so we're backwards
compatible with all the existing links out in the world.

* Fix merge conflicts

* Remove some duplication

* Improve spec descriptions/read better

* clean up setting template with a ternary
2019-03-22 16:28:02 -04:00
Jess Lee
1b0cb47916 Merge user and give pro users trusted role (#2176)
* remove pro privelges from other roles and add trusted role for pros

* add merge user routes and methods

* add specs

* add more specs

* update languauge on /internal for clarity

* fix code climate error
2019-03-22 16:20:31 -04:00
rhymes
b789e5d78d Add SRI to script tags where applicable (#2153)
* Add SRI to script tags

* Update app/views/articles/_hiring_form.html.erb

Good point :)

Co-Authored-By: rhymes <rhymesete@gmail.com>
2019-03-22 14:14:59 -04:00
Andrew Bone
e96bf2e329 Add discernible text for organization link (#2168) 2019-03-22 13:54:46 -04:00
Andy Zhao
1b4c50574a Update pro dashboard permissions for organization members (#2173) 2019-03-22 12:40:31 -04:00
Ben Halpern
7f27aa32c7
Add areas for DEV Shop displays on left sidebar (#2162)
* Add areas for DEV Shop displays

* Update display_ad spec

* Add organization to spec

* Add orgs to specs properly
2019-03-22 09:57:37 -04:00
Andrew Bone
d486536448 [Theme] Dashboard makeover (#2171)
* Bring variables to dashboard

* Add variables to dashboard posts
2019-03-22 09:55:22 -04:00
rhymes
22ceaf7689 Remove klipse script unused partial (#2164) 2019-03-21 16:58:40 -04:00
cyrillefr
a2fcbdc4a4 Enable performance rubocop cops (#2140) 2019-03-21 16:01:45 -04:00
Andrew Bone
dd0cfcc30e Update reading list (#2151)
Change the reading list styles to work for night mode.
2019-03-21 15:34:53 -04:00
Andrew Bone
9045715986 Remove white border (#2146)
Remove the white border from the sidebars
2019-03-21 15:34:36 -04:00
Andrew Bone
1694048a1e Change comment form styles (#2149)
Update form styles to remove white border and add colour distinction to the background
2019-03-21 15:34:10 -04:00
Filip Defar
937bc63bbb Add list of followed organizations to dashboard (#2157) 2019-03-21 15:16:23 -04:00
Andrew Bone
354f7f8e0c Fix sidebar-profile-snapshot width (#2145) [ci skip]
Width was 1px too wide
2019-03-21 13:44:37 -04:00
rhymes
116d6b3278 Replace puts with proper logging (#2139) 2019-03-21 13:00:21 -04:00
rhymes
6435785017 Add alternative text for organization logo (#2148) [ci skip] 2019-03-21 12:52:22 -04:00
rhymes
df2621a8c0 Implement image upload's error handling (#2018) 2019-03-21 12:31:51 -04:00
Tim Lange
3494264404 Enabled rubocop/lint (#2130)
* WIP: Enabled rubocop/lint

* FIX: Fixed failing test

* FIX: Small change to return

* FIX: Changed indent
2019-03-21 10:53:44 -04:00
Ben Halpern
f70852d547
Make pull to refresh night theme, plus invert icons in night theme (#2135)
* Add night theme to pulltorefresh

* Adjust opacity of pulltorefresh for style

* Invert certain images
2019-03-20 18:42:52 -04:00
Ben Halpern
ce29fcc67c
Adjust ios theme background bottom (#2136) 2019-03-20 18:17:33 -04:00
Ben Halpern
5cc21f5238
Add night theme to article actions (#2132) 2019-03-20 17:07:21 -04:00
Tim Lange
d838f17f4b UX: Changed editor_version to a select field (#2107) 2019-03-20 13:34:02 -04:00
Glenn Carremans
b5eca77d63 Refactor award_yearly_club_badges (#2035) 2019-03-20 13:26:52 -04:00
Ben Halpern
658be52814
Add night theme vars for notifications and org branding (#2127)
* Add night theme stuff to notifications

* Fix night theme for org branding on show pages
2019-03-20 13:18:39 -04:00
Jess Lee
d7860fa76c Removed unnecessary 'reason for warning' in internal (#2128) 2019-03-20 12:58:41 -04:00
Anna Buianova
f0e9c0cfef Extract sending new follower notification to a separate job (#2030) 2019-03-20 12:51:09 -04:00
Ben Halpern
c92c77396c
Add ability to set logo via ENV var (#2123) 2019-03-20 11:14:23 -04:00
Ben Halpern
1a06096b6a
Add themes to main list, notifications, and chat (#2119) 2019-03-20 09:40:58 -04:00
rhymes
27213bf6da Use ActiveRecord::RecordNotFound instead of ActionController::RoutingError for 404s (#2118) 2019-03-19 20:54:25 -04:00
rhymes
c851953d83 Fix unescaped front matter description in MarkdownFixer (#1989) 2019-03-19 18:19:23 -04:00
Dave Follett
8434833d6a Update Tag removal's textarea (#2063) 2019-03-19 16:16:25 -04:00
Edison Yap
7a0a793a89 Redirect to 404 if badge not found (#2066) 2019-03-19 16:04:43 -04:00
Kristofer Selbekk
f352344fb2 Properly pluralize words on Dashboard (#2069) 2019-03-19 15:20:03 -04:00