maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
5247 commits 1 branch 0 tags 1.6 GiB
Commit graph

7 commits

Author SHA1 Message Date
Michael Kohl
79f1f5f0c8
Change string concatenation to interpolation (#7680) 
* Change string concatenation to interpolation

* Replace more concatenation with interpolation

* Add forgotten interpolation
 2020-05-06 17:13:10 +02:00
Ben Halpern
1dc1723709
Add field test gem to establish a/b testing (#6283) [deploy] 
* Initial field test spec work

* Clean up specs

* Fix codeclimage

* Cleanups

* Update names

* Rename and remove need to pass logged in status

* Leadup to prod: two experiments

* Move test logic to controller and add tests

Co-authored-by: Josh Puetz <josh@grorichpuetz.com>
 2020-03-03 10:21:29 -05:00
Molly Struve
faa4325c1f
Only Update page_views When They Are Valid (ie created) (#5195) [deploy] 2019-12-26 11:28:18 -06:00
Ben Halpern
befefd08d0
Remove extra dependencies for PageViewsController (#4923) [deploy] 
* Remove extra dependencies for PageViewsController

* Fix strongparams and fix typo

* Fix spec

* Remove unnecessary page_view param

* Remove additional unnecessary page_view

* Create ApplicationMetalController for shared Metal behavior

* Revert rand numbers to ensure apples-to-apples perf compare

* Whoops, revert change revert

* Clarify comment
 2019-11-25 19:06:34 -05:00
Fabbri Paolo
89e893f157 Fix rubocop detected offenses (#4552) 
* Run Inspecting 1050 files
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....................................................................................................................................................................................................................................................................................................

Offenses:

spec/models/article_spec.rb:195:7: C: RSpec/NestedGroups: Maximum example group nesting exceeded [4/3]. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups)
      context "when description is empty" do
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1050 files inspected, 1 offense detected to fix autofixable errors

* Refactor  to correct test

it was braking the rule RSpec/NestedGroups: Maximum example group nesting exceeded [4/3]. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups)

* Run `rubocop --auto-gen-config` to regenrate `.rubocop_todo.yml`
 2019-10-24 11:53:03 -04:00
Ben Halpern
4b1b137c0f
Fix/augment dashboard and article view count issues (#2449) 2019-04-15 10:24:38 -04:00
Ben Halpern
825aa9be91
Add page_view model (#1985) 
* Add page_view model

* Uncomment DJ routes

* Add time on site max and don't update article page views every time
 2019-03-07 11:53:33 -08:00