rhymes
a09bf20503
Remove unused attr_reader ( #2376 ) [ci skip]
2019-04-11 12:47:15 -04:00
Andy Zhao
8ef611f879
Remove Honeycomb from the app ( #2366 )
...
* Remove Honeycomb related gems
* Remove Honeycomb related code from controllers
* Remove Honeycomb from RSS Reader
* Remove Honeycomb related files
* Remove Honeycomb related tests
* Remove leftover Honeycomb methods
2019-04-11 10:49:35 -04:00
rhymes
3b4bda89df
Upgrade Honeycomb gem, fix and improve RssReader tests ( #2319 )
...
* Switch from deprecated honeycomb-rails to honeycomb-beeline
* Improve error handling, tests and add refactoring
* Fix multiple fetching test and add one more
The test wasn't actually testing the correct behavior, because the class
by default force fetches. It worked because it wasn't reloading the user
from the database.
* Test that Honeycomb's client is doing its thing
* Use some defensive programming to avoid any possible problem during shutdown
* Fix typo
* Use the new API to add fields to the current measured event
* Use default instrumentation and add user info to event
* Replace user.email with user.username, less personal data around
* Use mocking instead of calling Honeycomb.init
* Freeze time before traveling
* Remove a flaky test dependent on rand
2019-04-07 15:27:53 -04:00
rhymes
a1787d0702
Fixed some Style/* rubocop violations ( #2314 )
...
* Fix Style/FormatString and Style/TrivialAccessors
* Fix Style/NegatedIf and Style/DoubleNegation
* Style/ClassAndModuleChildren is already enabled by default
* Fix Style/GlobalVars
* Group all style/ cops inside rubocop config file
2019-04-06 14:24:33 -04:00
Abraham Williams
9cb40e546b
Enables Rails cops ( #2186 )
...
* Enable Rails cops
* Fix Rails/DynamicFindBy
* Fix Rails/HttpStatus
* Fix Rails/Blank
* Fix Rails/RequestReferer
* Fix Rails/ActiveRecordAliases
* Fix Rails/FindBy
* Fix Rails/Presence
* Fix Rails/Delegate
* Fix Rails/Validation
* Fix Rails/PluralizationGrammar
* Fix Rails/Present
* Fix Rails/Output
* Fix Rails/Blank
* Fix Rails/FilePath
* Fix Rails/InverseOf
* Fix Rails/LexicallyScopedActionFilter
* Add Rails/OutputSafety to TODO
* Add Rails/HasManyOrHasOneDependent to TODO
* Add Rails/SkipsModelValidations to TODO
2019-03-25 09:25:55 -04:00
cyrillefr
a2fcbdc4a4
Enable performance rubocop cops ( #2140 )
2019-03-21 16:01:45 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Ben Halpern
9736d411d3
Fix get_all_articles in RssReader ( #1566 )
2019-01-15 22:25:30 -05:00
Ben Halpern
7f7a35048a
Find by title or feed source URL in rss fetch ( #1560 )
2019-01-15 15:34:13 -05:00
Ben Halpern
47e8fbc9ec
Add feed_fetched_at for users to not refetch unnecessarily ( #1555 )
...
* Fix RSS issues by not refetching users as often
* Make rss fetch not forced in rake task
* Remove unnecesary schema line
2019-01-15 13:29:11 -05:00
Mac Siri
f780e5fbc9
Refactor RssReader ( #1537 )
...
* Update RssReader::get_all_articles
* Move RssReader to services
* Create RssReader::Assembler
* Improve RssReader's spec
2019-01-14 14:25:49 -05:00
