maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1707 commits 1 branch 0 tags 1.6 GiB
Commit graph

28 commits

Author SHA1 Message Date
Keshav Biswa
8d57d45ecc Rubocop Style cops enabled (#2056) 
* Rubocop enabled style/alias

* Enabled Style/ArrayJoin Cop

* Enabled Style/Attr

* Enabled Case Equality

* Enabled CharacterLiteral

*  Enabled ColonMethodCall Cop

* Enabled CommentAnnotation cop

* Enabled PreferredHashMethods Cop

*  Enabled DoubleNegation Cop

* Enabled EachWithObject Cop

* Enabled EmptyLiteral Cop

* Enabled EvenOdd Cop

* Enabled IfWithSemicolon Cop

* Enabled Lambda and LambdaCall Cop

* Enabled LineEndConcatenation Cop

* Enabled ModuleFunction Cop;

* Enable NegatedIf and NegatedWhile Cop

* Enabled NilComparison Cop

* Enabled Not Cop

* Enabled NumericLiterals Cop

* Enabled OneLineConditional Cop

* Enabled PercentLiteralDelimiters Cop

* Excluded internal/users_controller from negated_if cop

* Reverted the double negation change from github_issue_tag and github_issue.rb"

* Enabled PerlBackrefs Cop

* Changed Regexp.last_match(1) to Regexp.last_match(0)

* Enabled proc cop

* Enabled RaiseArgs Cop

* Reverted Regexp.last_match(0) to Regexp.last_match(1)

* Enabled SelfAssignment Cop

* Enabled SingleLineMethods Cop

* Enabled SpecialGlobalVars Cop

* Enabled VariableInterpolation Cop

* Enabled WhenThen Cop

* Enabled WhileUntilModifier Cop

* Enabled WordArray Cop

* Enabled IfUnlessModifier Cop

* Enabled GuardClause Cop
 2019-03-15 18:33:54 -04:00
Mac Siri
1137d6fba4 Improve specs (#1693) 
* Lock erb_lint

* Refactor moderation spec

* Remove & replace RequestSpecHelper

* Update uid to sequence

* Lower the need for persistence in specs

* Update moderation spec

* Update shoulda-matchers

* Enable backgroundjobs and update commenct spec

* Fix fail specs

* Update comment's validations

* Remove redundent specs

* Actually turn off DJ

* Apply run_background_jobs_immediately

* Remove giveawy specs

* Create Identity spec
 2019-02-04 15:56:00 -04:00
Andrew Bone
b56865915c Jsfiddle LiquidTag (#1509) 
* Create jsfiddle_tag.rb

Add liquid tag for jsfiddle

* Create jsfiddle_tag-spec.rb

Add liquid tag for jsfiddle

* Update _editor_guide_text.html.erb

Add liquid tag for jsfiddle

* Updates for rubocop

* Edit boilerplate

Change some of the boiler plate code.

* rubocop compliance

* Fixed name

Fixed file name

* Fixed boiler plate

Changed codepen to jsfiddle

* Update guide text

Change the Guide Text to be jsfiddle specific.

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Fixed typo in spec

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Update Valid Link

* Update jsfiddle_tag.rb

* Add Approved html

* Remove double slash

* Revert change

* Fix XSS error

* Remove extra line

* Remove extra slash

* Remove extra slash

* Make DRY

* rubocop compliance

* Change test logic

* Revert test to Approvals

* Fix HTML approved
 2019-01-17 15:44:01 -05:00
Mac Siri
f4ca4a15e5 Fix liquid tag parsing error (#1481) 
* Fix liquid tag parsing error

* Update spec
 2019-01-07 15:54:57 -05:00
Arun Kumar
80a23ba403 Fix rubocop offenses (#1452) 2019-01-03 09:23:38 -05:00
rhymes
dbf5fc63ad Fix Rubocop Security/Open (#1447) 
* Re-run rubocop autogen config

* Fix Layout/* violations

* Fix Security/Open and use HEAD if GET is not needed
 2019-01-02 16:35:19 -05:00
rhymes
6553f08d94 Rubocop cleanups (#1415) 
* Update rubocop-todo.yml with new violations

* Fix Layout/EmptyLine* rules

* Fix Layout/Indentation* rules

* Fix remaining Layout/* rules

* Fix Lint/DuplicateMethods by removing unused accessor

* Fix Lint/IneffectiveAccessModifier

* Fix Lint/MissingCopEnableDirective

* Re-run rubocop auto gen config

* Fix Layout/RescueEnsureAlignment

* Fix Naming/* rules

* Fix some RSpec/* rules

* Fix typos

* Fix RSpec/LetBeforeExamples

* Series should only be an attr_writer, not an attr_accessor

* Fix RSpec/InstanceVariable

* Fix RSpec/InstanceVariable

* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample

* Fix Style/ClassAndModuleChildren

* Fix Style/ConditionalAssignment

* Fix some Style/* rules

* Trigger Travis CI build because failing tests are not failing locally

* Revert "Fix Style/ClassAndModuleChildren"

This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
 2019-01-02 11:20:02 -05:00
Jason Yu
3af90f1d0e remove punctuations in header anchor links (#1219) 
* remove punctuations in header anchor links

* remove punctuations first

* added test case for punctuation headings
 2018-11-29 15:16:09 -05:00
Gabriel Lebec
1e2749be24 feat(markdown): add ids to headers (#713) 
* feat(markdown): add anchors for headers

* Fix markdown anchors impl and spec

* Fixes tests for markdown anchors

* Use name for anchors instead of IDs

* Fix approval file

* Remove emojis in links and hyphenate only spaces
 2018-11-20 18:17:07 -05:00
Andy Zhao
a1010201f2 Notifications part 2 (#1156) 
* Remove stream and add new notification views

* Actually remove Stream

* Move followers query to async method

* Remove unused tests and fix query

* Try using without delay instead

* Add without delay and escape HTML

* Make all tests pending for now
 2018-11-19 18:14:24 -05:00
Nathan Sebhastian
76f6a8f9df codepen embed add default-tab param (#880) 
* codepen embed add default-tab param

* add codepen default-tab documentation in help tab
 2018-11-07 13:31:20 -05:00
Mac Siri
5287d4a03b Create DelayedJob config and misc DX changes (#979) 
* Change from #after_save to #after_create

* Update .babelrc

* Update cloud_name for test

* Update SlackBot's RssReader channel

* Update helpful-hints.md

* Create .gitdocs.json

* Remove serve-docs script

* Update docs/helpful-hints.md

* Update approval

* Revert "Change from #after_save to #after_create"

This reverts commit 548ee0d2c0d56a1aa67316468f4106ac9f437662.

* Create delayed_job.rb

* Bump ancestry gem to 3.0.3

* Fix broken spec

* Remove manual Delayed::Job config in test

* Update spec_helper.rb

* Fix broken specs

* Mute SlackBot in test

* Remove weekly-dgiest.yml

* Create PodcastEpisodeDecorator
 2018-10-26 13:15:14 -04:00
dgolant
3a81c82b28 Add liquid tag for Soundcloud (#844) 
* Add liquid tag for Soundcloud

Adds a liquid tag for soundcloud links. Currently does not support customizing autplay, display for comments, or color.

* Strip HTML from Soundcloud tag input

We want to prevent potential XSS exploits, so we sanitize all link input

* Add Soundcloud tag documentation to editor guide
 2018-10-09 13:51:59 -04:00
Maksim Litvinov
33db32e5f4 Fix rubocop lints (#794) 2018-10-03 13:00:09 -04:00
dependabot[bot]
eafefd7422 Bump octokit from 4.8.0 to 4.12.0 (#744) [ci skip] 
* Bump octokit from 4.8.0 to 4.12.0

Bumps [octokit](https://github.com/octokit/octokit.rb) from 4.8.0 to 4.12.0.
- [Release notes](https://github.com/octokit/octokit.rb/releases)
- [Changelog](https://github.com/octokit/octokit.rb/blob/master/RELEASE.md)
- [Commits](https://github.com/octokit/octokit.rb/compare/v4.8.0...v4.12.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Update spec
 2018-09-25 17:04:58 -04:00
Mac Siri
32d15f2820 Update test suite configuration (#702) 
* Update DatabaseCleaner

* Only retry in CI

* Update rubocop precommit hook

* Update spec

* Restructure spec configs WIP

* Restructure spec configs WIP

* Create OmniauthMacros

* Fix broken spec

* Update spec
 2018-09-24 14:40:22 -04:00
rhymes
e588fa7ece Code cleanups (#659) 
* Initial automatic cleanup with rubocop

* Fix syntax error introduced by rubocop

* Cleanup seeds file

* Cleanup lib folder

* Exclude bin folder because it contains auto generated files

* Make Rubocop a little bit more chatty

* Block length should not include comments in the count

* Cleanup config folder

* Cleanup specs

* Updated Rubocop version and generated a todo file

* Fix broken ArticlesApi spec

* Fix tests

* Restored rubocop pre-commit hook
 2018-08-07 11:00:13 -04:00
Mac Siri
40f488d991 Migrate to Travis CI (part 2) (#591) 
* Update Travis.yml

* Update README

* Update README

* Adjust test to not rely on env vars

* Update encryption

* Refactor

* Update env key

* Stub AWS calls

* Create ApplicationConfig

* Fix specs

* Fix lint

* Update ApplicationConfig

* Remove travis env vars

* Fix lint

* Extend character limit to 100

* Add env to travis

* Take out auto-restart after deploy

* Immediately discarded test cache

* Stub GA in request specs

* Stub Pusher

* Fix broken specs

* Update fixture

* Add CodeClimate id

* Change CodeClimate key

* Remove merge mistakes

* WIP

* Add Envied gem & Change README

* Add missing keys

* Add missing key

* Update fixture

* Fix broken spec

* Add Slack Notification for Travis

* Fix wording

* Fix typo
 2018-07-20 20:17:18 -04:00
Mac Siri
1555388f12 Migrate to Travis CI --skip-ci (#588) 
* Create .travis.yml

* Update .travis.yml

* Add postgresql to travis

* Change travis's postgresql version

* Add chrome addon to travis

* Adjust travis config --skip-ci

* Change travis dist

* Change travis to use Chrome --skip-ci

* Use IntegraitonHelpers --skip-ci

* Add no-sandbox option to headless chrome

* Add sudo to travis

* Fix broken spec

* Update travis.yml

* Change how travis store bundler cache

* Update chromedriver command

* Add CodeClimate to travis --skip-ci

* Remove deadcode --skip-ci

* Remove dead code

* Change rspec-retry back to 3

* Add deploy script to travis

* Safelist only master for Travis --skip-ci
 2018-07-16 17:11:42 -04:00
Ben Halpern
92a541a517
Add a couple specs for notifications and pages (#522) 
* Add a couple specs

* Remove stream VCR from notifications_spec

* Add github readme spec

* Add notifications count specs

* Add guards in notifications controller

* Fix test

* Fix test
 2018-06-29 14:14:36 -04:00
Mac Siri
808550afb0 Create 'proper_status' shared context (#506) 2018-06-29 10:43:46 -04:00
Ben Halpern
0755a07713
Add misc specs and remove banned attribute from user model (#484) 2018-06-22 16:06:04 -04:00
Mac Siri
ff36271108 Improve ArticlesController's authorization (#466) 
* Fix lint

* Add pundit-matchers gem

* Strengthen ArticlePolicy & create spec

* Change ApplicationPolicy to a closed system

* Globally handle pundit's NotAuthorizedError

* Fix lint

* Adjust /new's authorization
 2018-06-21 14:18:32 -04:00
Jess Lee
7dd8f791fc [WIP] Jess/#170 GitHub liquid tags (#272) 
* refactor github tag class

* fix github issue tag spec

* reduce github issue title text on mobile

* pull readme

* octokit wip

* Render repo with Octokit and change error handling

* start syling for github tag

* add styling for github readme tag

* Take darker of user colors

* Andy pushing WIP

* truncates and adds styling for readme

* fix relative image links

* use regex instead of URI join for relative image links

* Fix failing test and approvals
 2018-05-29 11:29:32 -04:00
Andy Zhao
c9c02ef3c0 [Done] Fix div in li issue (#320) 
* Lint and clean up github issue styles

* Use heredoc HTML for easier formatting

* Add better error handling for 404 github issues

* Use custom sanitizer for markdown render

* Refactor unless to ternary

* Rename file and tighten up sanitization

* Fix codepen and instagram tag styling
 2018-05-21 17:35:03 -04:00
Mac Siri
e3a270d317 Update blackbox's API endpoint (#259) 2018-04-30 12:24:32 -04:00
Mac Siri
84122959bf Update unsubscribed page's copy and css (#199) 
* Update unsubscribed page's copy and css

* Create view spec for email_subscriptions/unsubscribe

* Update unsubscribed's page copy

* Prevent search-engine crawlers
 2018-04-10 15:02:20 -07:00
Mac Siri
301c6080e3 Initial commit 2018-02-28 16:11:08 -05:00