Dan Wallis
521bb09394
Add loading=lazy to image tags ( #10888 )
...
* Add loading=lazy to image tags
* Fix test
* Lazy-load some obvious templates
* Lazy-load more verified templates
2021-05-27 19:01:21 +02:00
Michael Kohl
6dfabd578f
Rename SiteConfig to Settings::General ( #13573 )
...
* Rename SiteConfig
* More renaming
* Update spec
* Update mandatory settings mapping
* More renaming
* e2e test fixes
* You have a rename, and you have a rename
* Spec fix
* More changes
* Temporarily disable specs
* After-merge update
* Undo rename for migration
* undo rename of DUS
* Fix DUS
* Fix merge problem
* Remove redundant DUS
* Fix specs
* Remove unused code
* Change wrong class name
* More cleanup
* Re-add missing values to constant
* Fix constant
* Fix spec
* Remove obsolete fields
* Add accidentally removed field
* Update spec
* Move methods from Settings::General to ForemInstance
* Remove unneeded model
* Change mentions of 'site config'
2021-05-21 14:45:37 +02:00
Karel De Smet
f9e307a4bd
#13759 : hide content in print mode ( #13794 )
...
* Hide certain article elements on print
* Fix class statement
2021-05-20 10:10:46 +02:00
Michael Kohl
111b7316d9
Remove mascot footer image ( #13642 )
...
* Remove footer mascot image
* Move remaining mascot settings back to SiteConfig
* Add data update script
* Update usages
* Fix path
* Remove dead route
* Update tests
* Fix view and spec
* Fix e2e test
* Fix DUS
2021-05-11 13:55:18 +02:00
Michael Kohl
f2f5e911cf
Add Settings::Mascot ( #13451 )
...
* Add Settings::Mascot
* Add DUS
* Update usage
* Fix e2e test and controller
* Fix specs
* Fix remaining spec
2021-04-26 11:39:19 +07:00
Nick Taylor
a55943d2b6
Removed title attributes from SVGs that are purely decorative. ( #13482 )
2021-04-23 14:59:58 +02:00
Andrew Bone
c9e4227c59
crayons-notice accessibility improvements (#13273 )
...
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Add roles to crayons-notice
* Update app/assets/javascripts/initializers/initializeCommentsPage.js.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/badge_achievements/award.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/broadcasts/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/configs/_apple_auth_provider_settings.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/configs/_form_submission.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/pages/sponsors.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/shared/authentication/_email_registration_form.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/users/_account.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/shared/authentication/_initial_account_wizard.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/users/edit.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/configs/show.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/configs/show.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/feedback_messages/_feedback_message.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/html_variants/show.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/pages/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/pages/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/liquids/_user_subscription.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/profile_fields/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/tags/edit.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/users/gdpr_delete_requests/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/articles/_actions.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/articles/_search.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/articles/show.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/articles/show.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/articles/tag_index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/comments/_comment_quality_marker.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/comments/deleted_commentable_comment.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/admin/users/_notes.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/dashboards/following_tags.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/devise/invitations/edit.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/events/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/listings/_form.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/listings/edit.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/views/pages/_editor_frontmatter_help.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-04-14 13:32:57 +01:00
Arit Amana
04d5ea8e82
Update the UI for Low-Quality-Comments Notice ( #12952 )
...
* Implement change for regular comments
* Modify tests and implement for deleted-commentable-comment
* Fix stupid mistake
2021-03-16 09:40:29 -04:00
Efereyan Karen Simisola
fc7ed20a9f
Publicly indicate if someone edits their comments ( #10524 )
...
* Publicly indicate if someone edits their comments
Signed-off-by: Efereyan Karen Simisola <thedevkaren@gmail.com>
* Implement required changes for date edited
* Add methods for readable publish date and edited at in comment decorator
Signed-off-by: Efereyan Karen Simisola <thedevkaren@gmail.com>
* Fix syntax error and decorator naming error
* Add tests
* Update app/views/comments/_comment_date.erb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: Michael Kohl <me@citizen428.net>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2021-03-02 09:47:25 +07:00
Ben Halpern
d7732499b9
Improve cumulative layout shift on comment reactions + optimizations ( #12309 )
...
* Improve content layout shift on comment reactions + optimizations
* Clean ups, tests, and docs
* Fix test typo
* Update app/views/comments/_comment_footer.html.erb
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
* Update docs/technical-overview/architecture.md
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update docs/technical-overview/architecture.md
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update docs/technical-overview/architecture.md
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Refactor and add jsdoc
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2021-01-18 19:29:44 -05:00
yogeshwaran
cf0a85b3a4
Bug fix #11402 - Very wide code blocks overflow in comment preview ( #12166 )
...
* Fix #11402 - Comments with code not scroll issue
* Fix #11402 - Comments with code not scroll issue
* Fix #11402 - Comments with code not scroll issue
* #12166 - PR Review changes
* Fix #11402 - Comments with code not scroll issue
* #12166 - PR Review changes
2021-01-12 10:45:25 +01:00
Ben Halpern
9b5e694e9c
Ben/new branch noindex spam comments ( #12210 )
...
* noindex google any comment permalinks with negative score
* Add commentable noindex
* Give dummy score to podcast episodes
2021-01-11 16:17:52 -05:00
Julianna Tetreault
ca6ba1af7d
Replace collective_noun with community_name ( #11846 ) [deploy]
...
* Removes collective_noun and collective_noun_disabled from app
* Config Generalization: replaces community_qualified_name with community_name
- Generalizes SiteConfig after the removal of collective_noun field
- Updates copy where necessary to be readable with community_name
- Makes the community_name SiteConfig description more explicit
- Adds flexibility for Admins by removing appended "community"
* Adds a data_update script to remove collective_noun and collective_noun_disabled
* Removes appended community from stories_controller.rb
* Removes unnecessary quotation marks around SiteConfig.community_name.to_s
* Makes SiteConfig community_name description more explicit
* Removes topic from #email_from and replaces arg with _
* Removes argument from #email_from (facepalm)
* Reverts changes to application_mailer and notify_mailer_spec
* Removes default "Community" topic from application_mailer and makes topic optional
* Refactors #prepopulate_new_form to resolve Code Climate failures
* Refactors #email_from even further by use of a ternary operator per review suggestion
* Simplifies the data_update script used to remove collective_noun per review request
* Adds a data_update script to append community to community_name
* Updates data_update script to correctly append Community to community_name
* Removes RemoveCollectiveNounFromConfig and updates other script
* Removes superfluous false from data_update script
* Updates data_update script to be more idiomatic
2020-12-28 09:34:17 -07:00
ludwiczakpawel
70706d0a62
Comments UI update ( #11283 )
...
* tooltips 1.0.1
* tooltips 1.0.1
* init
* .
* drop not needed files
* .
* init
* init
* .
* comments
* border
* missing bits
* build comment JS
* .
* .
* specs
* sloan avatar fix
* bunch of fixes
* specs and fixes
* specs
* .
* swap order of links
* contrast
* js for dropdown
* icons
* op-author
* three dots icon
* reverts
* test: capybara- make sure that we click the dropdown before clicking on edit
* permalink --> link
* tiny fixes
* aria-label on form
* proper alt on user's avatar
* aria has popup
* use UL > LI instead of DIV
* add aria-labels to dropdown items
* another aria-label
* better links: nav
* contrast
Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
2020-11-18 18:21:19 -05:00
rhymes
f9506affb5
Use faster JS selection methods ( #11409 )
...
* Add JS tips section to frontend documentation
* Replace document.getElementsByTagName('body') with document.body
* Replace querySelectorAll with faster selecting methods where appropriate
* Replace querySelector with faster selecting methods where appropriate
* Fix typo
* Fix forEach and getElementsByClassName
* Change querySelector* to faster methods in erb files
* Change querySelector* to faster methods in ruby files
* Fix runkit tag
* Various fixes
* Update app/assets/javascripts/initializers/initializeEllipsisMenu.js
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Update app/assets/javascripts/utilities/slideSidebar.js
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Commenting out flaky spec
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2020-11-16 17:35:50 +01:00
Nizar
7058d628af
Added Copy Permalink Functionality to Comment Dropdown ( #8311 )
...
* Added Copy Permalink Functionality to Comment Dropdown
Copy functionality is similar to the way 'copy article link' is implemented. It checks for the android bridge first, then the navigator, then fallsback to the default document copy command
Since the codes were really similar, I moved the copy functionality to a function of its own with callbacks and fallbacks as lambdas, and triggered it with the copyArticleLink and the copyPermalink
* Replaced Copy Permalink Callbacks with Promises
* Keep anchor tags instead of buttons (#1 )
* copy permalink using anchor tag
* Missing closing button tag
* Adds 'Copied to Clipboard' Snackbar Message
* Patches bug introduced in #10323
Patch suggested in following comment: https://github.com/forem/forem/pull/8311\#pullrequestreview-492011202
* Removes import statement for addSnackbarItem and Suppresses ESLint Error
Initializer runs in global scope
* Unhandles exception when copying permalink so Honeybadger can handle it
* Replaces ButtonListener suffix for copyPermalink method with Listener
Co-authored-by: Fernando Valverde <fernando@visualcosita.com>
2020-11-11 08:32:10 -05:00
Ben Halpern
ec5d0d0d93
Wrap siteconfig images in optimizer ( #11276 )
...
* Wrap siteconfig images in optimizer
* Add to admin area
2020-11-05 12:35:07 -05:00
Mac Siri
7c954fa16e
Remove social icons from comment liquid tag ( #11186 )
2020-11-02 09:57:08 -05:00
Ivan
3ad0e27f8c
fix for code fullscreen action on comment page ( #11224 )
2020-11-02 10:57:45 +01:00
ludwiczakpawel
44466532dd
Z-index cleanups ( #11157 )
...
* tooltips 1.0.1
* tooltips 1.0.1
* cleanup css
* few more fixes
* fix
2020-10-30 16:03:23 +01:00
Rafal Trojanowski
4bc8b80a90
Introduce tweet_timeline liquid tag ( #7605 ) ( #10825 )
2020-10-30 11:03:40 +01:00
ludwiczakpawel
1636bdf4c8
Autoresize on comment textarea + comment submit on CMD/CTRL+Return ( #11115 )
...
* .
* whoops
* revert typo
* Handle glitches and edge cases.
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-10-29 09:33:11 +01:00
Lisa Sy
36e271e1cb
Deprecate old button stylings with Crayons buttons ( #10694 ) [deploy]
...
* Deprecate old buttons.scss file
* Replace outdated button styles with Crayons button styling
* Update additional views after removing old button styling
* Update tests
* Update test
* Update test
* Fix button placements
2020-10-14 07:28:41 -07:00
Julien Maury
fc933b991a
[deploy] fix dropdown svg for dark themes - comment section ( #10769 )
...
* fix dropdown svg for dark themes - comment section
* missing classes on buttons
* delete class ghost
* test svg on all themes
2020-10-13 17:08:00 +02:00
Vaidehi Joshi
c4efee10bf
Do not require meta_keywords to be set ( #10721 )
...
* Remove extra character from meta_keywords in /listings/index.html.erb
* Remove meta_keywords from MANDATORY_CONFIGS
* Add and use meta_keywords_tag helper
* Use modern tag syntax instead of deprecated syntax
* Add and use meta_keywords_default helper
* Add and use meta_keywords_article helper
* Remove * from meta_keywords_field.label
* Update meta_keyword specs to account for no keywords being set
2020-10-08 10:51:25 -04:00
Ben Halpern
c0d5486023
[deploy] Fix current_user cache issue in comments ( #10609 )
2020-10-05 10:52:12 -04:00
ludwiczakpawel
1375e8a4df
[deploy] Redesigned Comment Form ( #10355 )
...
* init
* .
* .
* better
* last bits
* specs
* merge
* fix response templates for replies
* copy
* active inactive buttons + cleanup
* labels
* specs
* specs
* response templates fix
* ....
* wtf
* .
2020-10-05 12:01:48 +02:00
Arit Amana
877e9a13b1
Fix bug that arises when a previously tagged comment is deleted ( #10486 )
...
* Starting to dig
* Stil figuring out
* Complete implementation; remains tests
* Modify comment_tag specs
2020-09-29 13:43:25 -04:00
ludwiczakpawel
3e9b56a7dd
[deploy] Frontend cleanups ( #10416 )
2020-09-24 08:15:12 -05:00
Mac Siri
9ebd742712
[deploy] Reintroduce sticky_nav changes ( ab81f36 & 7f92855) ( #10263 )
...
* Revert "[deploy] Revert removal of unneeded eager load (if needed) (#10179 )"
This reverts commit 11c7b148da#10055 )" (#10149 )"
This reverts commit 5657067e55
2020-09-09 15:33:13 -04:00
Molly Struve
5657067e55
[deploy] Revert "Migrate ProfileImage to Images::Profile ( #10055 )" ( #10149 )
...
This reverts commit ab81f36a38
2020-09-01 18:28:58 -05:00
Mac Siri
ab81f36a38
[deploy] Migrate ProfileImage to Images::Profile ( #10055 )
2020-09-01 17:16:03 -04:00
Andrew Bone
3174058aa6
Add comments-dedicated-page-container class ( #10012 )
...
Patch for #9991
2020-08-26 09:48:17 -04:00
Mac Siri
09dd4fd750
[deploy] Add missing .call ( #9791 )
2020-08-14 15:59:25 -04:00
Mac Siri
a081810946
[deploy] Migrate ImageResizer to Images::Optimizer ( #9720 )
2020-08-14 09:44:30 -04:00
rhymes
085c60992b
Rubocop: Enable and fix Style/OptionalBooleanParameter cop ( #9711 )
...
* Enable and fix Style/OptionalBooleanParameter cop
* Keep regular parameters for workers
* Keep regular parameters for workers
* Fix spec
* Trigger Travis correctly
2020-08-10 19:35:55 +02:00
Brunno Souza
b5de27f1a6
Refactoring comments_controller#create reducing lines ( #9162 )
2020-07-10 17:24:36 +02:00
Ben Halpern
2a31f7b9de
[deploy] Remove report-abuse link from base HTML document into JavaScript ( #9059 )
2020-07-01 16:29:22 -04:00
Ben Halpern
26d54e72cf
[deploy] Small mod fixes ( #8885 )
2020-06-24 10:45:11 -04:00
Ben Halpern
dda6422e22
[deploy] Use fragment for linking to comments for SEO ( #8882 )
2020-06-24 10:09:41 -04:00
Raphael Noriode
463cd07597
modify meta tag according to the twitter doc to return large images ( #8858 )
2020-06-23 13:03:28 -04:00
Michael Kohl
359f2cb2c5
Style hide link with Crayons ( #8820 )
2020-06-22 08:27:38 -04:00
Ben Halpern
2deadc2385
Change three-dots svg ( #8746 )
2020-06-17 15:53:55 -04:00
ludwiczakpawel
16f4d7d46a
[deploy] Article Design update ( #8234 )
...
* flare tag line height
* .
* init
* widgets
* widgets lists
* new tabs on home
* instantclick
* .
* rethinking css
* .
* .
* empty space
* init
* campaign widget
* .
* merge
* .
* update layout
* fix sidebars on home page
* .
* fix onboarding x
* test
* spec
* test
* toolbar fix
* more
* test
* better handling ads
* .
* spec
* card border
* .
* .
* actions bar
* cleanup
* animation
* test
* button width
* .
* better responsiveness and author boxes
* meta info
* padding
* better animation
* optimize videos
* fixes
* spec
* .
* codeblocks in comments
* whoops
* Use .present? correctly as it preloads items
* sticky nav
* Update app/views/articles/_sticky_nav.html.erb
I don't know what I'm doing but @benhalpern says so! e8c0f337a5 (r440248874)e8c0f337a5 (r440247802)
2020-06-17 09:57:57 -04:00
Ben Halpern
b51647c59a
[deploy] Remove unnecessary comment links and clean up logic ( #8686 )
...
* Remove unnecessary comment links and clean up logic
* Fix links
2020-06-15 17:40:21 -04:00
Alberto Pérez de Rada Fiol
2ef30f6656
Fix remaining erblint errors ( #8405 )
...
* Fix remaining erblint errors
* Fix last error
2020-06-11 20:03:19 +02:00
Ben Halpern
c1dca335c7
[deploy] Allow users to set a payment pointer for their content ( #8304 )
...
* Initial user payment pointer work
* Finalize functionality and tests
* Fix schema
* Update app/views/shared/_payment_pointer.html.erb
* Add function to list
2020-06-09 16:28:16 -04:00
Ben Halpern
3c840610a1
[deploy] Remove unnecessary bulk from image assets ( #8306 )
...
* Remove unnecessary bulk from image assets
* Swap background-image
* Fix test
* Fix test
2020-06-05 17:51:06 -04:00
benhalpern
cca7729198
Add page view tracking to comment permalinks
2020-05-23 14:08:28 -04:00
cyrillefr
8bb865b10b
[deploy] Fixes some html_safe in Articles ( #6500 )
2020-05-13 09:22:52 -05:00
