Commit graph

2010 commits

Author SHA1 Message Date
RakChamp25
e00e7c3412 Refactor : BodyPreview.JSX (#4348) 2019-10-10 13:21:53 -04:00
Jeremy Schuurmans
96eb1a070a Fix ESLint errors in initializeBodyData.js (#4267)
* fix use global form of use strict error

* fix errors involving functions being used before being defined

* fix undefined function and == errors

* fix redeclared variable name error

* use arrow functions to fix unnamed function warnings

* specify global function at top of file instead of disabling line in eslint, change meta variable name
2019-10-10 13:17:16 -04:00
Juliette de Rancourt
d8e04a0a09 Remove duplication in users_controller.rb (#4337)
* Remove duplication

* Naming
2019-10-10 10:48:23 -04:00
negue
043b7da8de Remove white background in chat (#4182) [ci skip] 2019-10-09 16:53:20 -04:00
Leonid Trofymchuk
5e347a6f94 Simplify key codes expression in Tags component (#4248)
* Simplifying this key codes expression in Tags component

* Refactor KeyboardEvent keyCode to key

* Simplify cyrillic letter regexp

* Wrap condition in 2 lines
2019-10-09 16:50:48 -04:00
Yash Dave
e7c4310211 Fix eslint issues in initializeSettings.js (#4329)
- eslint configuration moved comments to a seperate line
  in pre commit hook allowing the eslint-disable-line to
  not work correctly.
- switched to eslint-disable-next-line to fix the same
2019-10-09 16:05:07 -04:00
Yash Dave
d125d94cbb Fix lint in initializeCommentPreview.js (#4320) [ci skip] 2019-10-09 14:35:37 -04:00
Yash Dave
350e43e62b Fix lint in initializeCommentDate.js (#4319) [ci skip] 2019-10-09 14:33:52 -04:00
Michel
7d530cf002 Fix invalid anchored links due to "//" prefix. (#4340) 2019-10-09 13:57:58 -04:00
rhymes
e579b03af1 Add an alt text and some type="button" attributes (#4331)
* Add alt text to rainbow dev logo

* Add type=button to buttons
2019-10-09 13:16:02 -04:00
Sagar Choudhary
1aa0d95de3 Refactor: initializeDashboardSort.js (#4313)
* Refactor: initializeDashboardSort.js

* change: onchange method to native js eventListener
2019-10-09 10:32:27 -04:00
Yash Dave
fd1b003334 Refactor/fix initializeCommentDropdown.js (#4318)
* Fix eslint issues in initializeCommentDropdown.js
- file was already compliant, just needed to add
  'use strict'.

* remove unnecessary eslint rule
2019-10-09 08:19:08 -04:00
Ben Halpern
3db3f6fdc2
Fix gotchas with color preview and some style adjustments and add documentation (#4322) 2019-10-08 21:32:31 -04:00
Andrew Brown
fd5c338659 Allow combining tags together in a search query (#2322) 2019-10-08 18:34:55 -04:00
Arun Kumar Mohan
08f397b36b Delete messages without instantiating ActiveRecord objects (#4183) 2019-10-08 17:29:38 -04:00
Duc Nguyen
2ebe70039a Feat: #3498 Display episode's published_at (#4272)
* feat: #3498 Display episode's published_at

* feat: #3498 Move methods to decorator

* feat: #3498 Add check if published_at present

* feat: #3498 Add testcase for showing published_at

* Fix build failure #3498

https://travis-ci.com/thepracticaldev/dev.to/builds/130734935

* feat: #3498 Fix testcase failed on Travis 130738295

* feat: #3498 Address comments on PR #4272

* feat: #3498 Delete unused

* feat: #3498 Refactor the use of decorate
2019-10-08 17:06:46 -04:00
Araslanov Evgeny
14796a9b84 Fix how white space is detected in frontmatter (#4265) 2019-10-08 16:53:10 -04:00
Araslanov Evgeny
60d8a07276 Fix invalid body_markdown in article with video (#4258) [ci skip] 2019-10-08 15:41:44 -04:00
Saurabh Daware
81e3f65965 Add preview for color changes in profile edit (#4212) 2019-10-08 14:52:07 -04:00
Akshay Mahajan
1cf125cb4f Add mod_roundrobin_notifications to user_policy.rb (#4226) [ci skip] 2019-10-08 13:52:20 -04:00
aRtoo
bec5b79120 Fix Github Liquid Tag alignment in notifications page (#4270) [ci skip] 2019-10-08 13:43:26 -04:00
Mac Siri
56bdf6f846
Create scoped policy for internal/comment (#4311) 2019-10-08 12:33:59 -04:00
Sagar Choudhary
a8b61bf781 Refactor: initializeCreditsPage.js (#4312) [ci skip] 2019-10-08 12:33:28 -04:00
Glenn Carremans
179c3150dd [PWA] Add purpose tag to 192x192 (#4220) [ci skip] 2019-10-08 11:31:35 -04:00
Ben Halpern
c0faa20c90
Add more info to architecture (#4233)
* Add more info to architecture

* Fix various typos and improve clarity in docs
2019-10-08 11:29:44 -04:00
Victoria Fluharty
e111951ceb fixes bug in tag search feature (#4222)
* fixes bug in tag search feature
now allows user to type in full name of tag and it does not disappear
makes other changes to pass eslint failing tests
moves methods around according to eslint tests
makes use of prevState callback method due to eslint tests

* updates handleKeyDown method
removes complex logical expression comparison from !== to !=
changes made due to failing task in pull request

* removes commented out code that I added to test code
updates logic to fix searchResults
removes .filter()

* adds comments to fixed code for clarification
2019-10-08 09:40:53 -04:00
Yash Dave
49fbf280c3 Refactor initializeArticleReactions.js (#4303)
* Refactor initializeArticleReactions.js
- Refactors file according to eslint rules
- Add showModal and sendHapticMessage to globals
  in eslintrc.js
- Shorten initializeArticleReactions() by distributing
  parts of it into jumpToComments() and requestReactionCounts()
- requestReactionCounts() makes an ajax request to get the
  reaction counts
- jumpToComments() jumps to comments element directly if the
  element jump-to-comments is present

* Fix reactionOnClick function to work correctly
- Move sendHapticMessage and showModal global declaration to file
- name function on reaction button on click as addReactionOnClick
  which then calls reactToArticle()
2019-10-08 08:41:43 -04:00
Karin Hendrikse
a9adeee11f [SPEC] Add tests for sidebarUser component (#4301) [ci skip] 2019-10-07 16:01:59 -04:00
Abbas
dce1b8d2da Update badge index's css (#4278) [ci skip] 2019-10-07 13:59:33 -04:00
Yehuda Neufeld
b5b98c3a37 added print styles to hide header & footer (#4249) 2019-10-07 12:57:36 -04:00
Akshay Mahajan
7b95c0edd9 Remove invert filter from profile header social icons (#4225) [ci skip] 2019-10-07 10:27:59 -04:00
Anna Buianova
cbfe53e81b Rescue SocketError when trying to fetch a podcast (#4274) [ci skip] 2019-10-07 10:26:22 -04:00
Regina Alyssa
8b4f7faf6b Comment Social Preview (#4260)
* Add route for comment social preview

* Add method comment to social_previews_controller

* Add view for comment social preview

* Fix spacing in meta keywords

* Update comments page keywords

* Create helper for comment social media image

* Use comment social image, add published condition for article social image

* Add tests for comment social preview

* Remove not_found fallback for social previews controller

* Remove cached_tag_list

* Update typos of word 'image' in spec
2019-10-07 10:03:03 -04:00
Yash Dave
328d27ff41 Fix links without http(s) (#4155) [ci skip] 2019-10-07 09:52:07 -04:00
ΔNDRΞW
9338e30303 Remove unneeded margin-left in @media tag (#4153) [ci skip] 2019-10-07 09:50:20 -04:00
Adam Moore
0b8b00c96b Adjust notifcations menu's css (#4167) [ci skip] 2019-10-07 09:46:57 -04:00
Anna Buianova
a73a5c0f06 Bust non-article comment cache without issues (#4275) 2019-10-07 09:42:54 -04:00
Karin Hendrikse
14c9adefd5 Test: add test for opening help window on articleForm (#4237) 2019-10-07 08:49:44 -04:00
Glenn Carremans
580fd11bb9 Fix text color Load more listings button (#4246) 2019-10-06 18:13:10 -04:00
Araslanov Evgeny
2af439c261 Added link to podcats from episodes feed (#4205) 2019-10-06 17:37:09 -04:00
Jake Wesorick
8cc051e882 Add badges index page. (#4236)
* Add badges index page.

* remove empty style rule.

* Add spec for badges index. Fix case when not logged in.
2019-10-06 17:34:52 -04:00
Nick Taylor
30cc799240 Mini refactor to make var names clearer. (#4257) 2019-10-06 17:04:14 -04:00
Jacob Herrington
2b324df96f Remove commented out SCSS (#4256) 2019-10-06 17:03:32 -04:00
Attila Blascsak
66faaccdd8 Fix lints in notificationSubscriptionHander.js (#4172) [ci skip] 2019-10-04 13:08:59 -04:00
Akshay Mahajan
5d207c34c5 Fix embedded comment date alignmemt issue (#4209) 2019-10-04 09:42:30 -04:00
Bradley Wells
30620d1d85 Make /credits more mobile friendly (#4213) [ci skip] 2019-10-03 16:21:12 -04:00
Melissa
9f37f27c2d Fix tabbing order of article engagement icons (#4192) [ci skip] 2019-10-03 16:05:07 -04:00
Paula
bff87da43c Add cybre.space instance (#4218) 2019-10-03 12:55:35 -04:00
Antony Garand
54c7e096c9 Remove useless argument in liquid template (#4200) [ci skip] 2019-10-03 12:52:56 -04:00
cyrillefr
82cca496fd Add collection ids to Api (reading + filtering) (#4180)
* Add collection ids to Api (reading + filtering)

  - refactored controller
  - modifyied views
  - added tests

* Add collection ids to Api (reading + filtering): requested changes

  - changed order in service
  - proper test in filtering
2019-10-03 11:26:39 -04:00