Marcy Sutton
b04b5bcb57
Headings and alt text roundup ( #11721 )
...
* Adjust heading order
No skipping levels, adding an h1 for the homepage
* Add missing image alt text
* Update after PR review
* Update test snapshot
Co-authored-by: rhymes <rhymes@hey.com>
2020-12-04 09:41:45 -05:00
Julianna Tetreault
28f3dbb13b
Bug Fix: First Published Post Not Showing Properly in the Feed ( #11710 ) [deploy]
...
* Adds a ternary operator to determine where to splice in Feed.jsx
* Add comments to Feed.jsx to explain featuredStory and deleteCount
2020-12-03 08:59:29 -07:00
Arit Amana
42e10e7b42
[EOY2020 Issue] Default new forems to Email Authentication only ( #11696 )
...
* Set default Auth Providers to empty array
* complete implementation; tests remain
* tests
* fix failing specs authenticator_spec.rb
* Fix failing specs
* fix more failing specs
* fix more failing specs 2
* update failing spec
* Update app/views/admin/configs/_auth_provider_settings.html.erb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/assets/stylesheets/admin.scss
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-12-02 16:49:07 -05:00
Lisa Sy
ea00c808bd
Storybook: Add DocsPage and test out static content ( #11397 )
...
* Update naming of guidelines section and improve Introduction page
* Add Docs
* Add docs
* Install Docs add-on
- Rename top-level folders and sort manually
- Add MDX static pages
* Updated all Storybook addons to 6.1.3 except for notes as it's currently 5.3.21
* Fixed naming of section for the select component.
* Updated yarn.lock file.
* Added missing dependency @storybook/addon-docs
Co-authored-by: Nick Taylor <nick@dev.to>
2020-12-02 09:56:38 -08:00
Nick Taylor
3785274199
Cleaned up tests I wrote for #11525 . ( #11685 )
2020-12-01 06:14:13 -05:00
ludwiczakpawel
d43ff0d46c
Series overflow fix ( #11683 )
...
* tooltips 1.0.1
* tooltips 1.0.1
* series selector
2020-11-30 17:12:10 +01:00
Nick Taylor
df31a94f2e
Prep work to sync mobile search in #10424 ( #11525 )
...
* Prep work to sync mobile search in #10424
* Added a comment about the custom search event.
* Refactor to fix already defined error caused by const and InstantClick.
* Moved <SearchFormSync /> out of the pack file.
* Fixed broken tests.
* Renamed getInitialSearchTerm utility function to getSearchTermFromUrl
* Added some API docs to getSearchTermFromUrl
* Fixed a typo.
* Added some more API docs.
* Switched to a custom event so a custom payload can be passed.
* Added some API docs.
* Fixed bad destructuring statement.
* wip for some more tests.
* Refactored getSearchTermFromUrl to use URLSearchParams
* lazy loaded state for search term initial value.
* test broken still. Need to think on it.
* filterXSS is now set up in testSetup.js
* Fixed tests.
* Added the @utilities alias to Storybooks webpack config.
* Almost 100% coverage with two useful tests.
* Added some comments explaining document.body usage in the tests.
* Fixed issue where search attemps to get results on first load.
* Small refactor for setting the window.location in tests.
* Clarified an explanation in a comment.
2020-11-30 06:13:06 -05:00
Nick Taylor
6feb2351e7
Fixed Error: Not implemented: window.computedStyle(elt, pseudoElt) console error in frontend tests. ( #11633 )
2020-11-26 16:55:33 -05:00
Nick Taylor
d623157eee
Fixed some frontend tests causing unhandled rejection errors ( #11627 )
...
* Fixed unhandled rejection in <ImageUploader /> test.
* Fixed <FollowUsers /> tests.
* Fixed the tests for the <RequestManager /> component.
* Fixed unhandled rejection in search utilities.
* Added an unhandledRejection listener so tests will fail if a Promise fails.
* Added a comment about why you might get an unhandled rejection exception.
2020-11-26 06:11:25 -05:00
Nick Taylor
779551916a
Fix frontend test setup file ( #11623 )
2020-11-25 15:27:06 -05:00
Thomas Bnt
3d8049697a
Edited URLs settings/ux to settings/customization ( #11618 )
2020-11-25 12:29:12 -05:00
Mac Siri
5ef6106045
Update JS dependencies with yarn upgrade ( #11589 )
2020-11-24 11:17:25 -05:00
Michael Kohl
2fd724d191
Update empty reading list copy ( #11565 )
...
* Change wording
* Add icon
* Update app/javascript/readingList/readingList.jsx
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-11-24 09:40:04 +07:00
Nick Taylor
bf7780cd2c
Ran prettier on *.js, *.jsx and *.md files. ( #11586 )
2020-11-23 20:45:50 -05:00
Nick Taylor
8c22bbd17b
filterXSS is now set up in testSetup.js ( #11579 )
2020-11-23 14:08:13 -05:00
Nick Taylor
8fabccec4e
Add Preact dev tools to development bundles ( #11459 )
...
* Now Preact dev tools are injected into development bundles.
* Updated frontend debugging documentation.
* Updated frontend debugging documentation wording.
2020-11-18 14:20:58 +01:00
Nick Taylor
ed7f4561e3
Fixed <Snackbar /> component displayName property. ( #11460 )
2020-11-18 06:41:00 -05:00
Ben Halpern
f3a69bbd84
Allow Forems to specify which domains are allowed for registration ( #11442 )
...
* Allow authors to restrict which emails can sign up
* Add form and tests
* Check for email presence in allowed email flow
* Fix test domains
* Fix codeclimate issue
2020-11-17 08:43:46 -05:00
Ben Halpern
eaf3403091
Fix document.body.getElementById is not a function ( #11446 )
2020-11-16 16:21:52 -05:00
rhymes
f9506affb5
Use faster JS selection methods ( #11409 )
...
* Add JS tips section to frontend documentation
* Replace document.getElementsByTagName('body') with document.body
* Replace querySelectorAll with faster selecting methods where appropriate
* Replace querySelector with faster selecting methods where appropriate
* Fix typo
* Fix forEach and getElementsByClassName
* Change querySelector* to faster methods in erb files
* Change querySelector* to faster methods in ruby files
* Fix runkit tag
* Various fixes
* Update app/assets/javascripts/initializers/initializeEllipsisMenu.js
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Update app/assets/javascripts/utilities/slideSidebar.js
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Commenting out flaky spec
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2020-11-16 17:35:50 +01:00
Rafi
eab507604d
Removing data-testid from Article component ( #10249 )
2020-11-16 10:23:44 -05:00
Andy Zhao
97e6c2295d
Filter by tags of reading list items not tags you follow ( #11394 )
...
* Filter by tags of reading list items not tags followed
* Sort the reading list tags
2020-11-13 10:45:32 -05:00
Josh Puetz
2223e5468b
Email login always on ( #11307 )
...
* Starting out
* Building away...
* Hooking buttons up
* Hook Auth Provider buttons to Array Field
* trying to fix NoNameError
* Remains InviteOnlyMode disable and tests
* Smashing remaining tasks
* Last of tasks
* add tests
* Complete specs and tests 😅
* Fix bug
* Additional guard
* pass event to functions
* Position Email Auth first
* Fix bug in Email Auth Modal
* Fix spacing issue
* Update docs for adminModal.js
* Show/hide Enabled Indicator with Enable/Undo buttons
* Complete Auth Providers functionality
* Only update `allow_email_password_registration` from admin
* Remove duplicated methods
* Some refactoring around fact that Email Login is now always on (#11382 )
* Fix merge (again!)
Co-authored-by: Arit Amana <msarit@gmail.com>
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
2020-11-12 09:32:58 -06:00
Jacob Herrington
9f62711123
Convert inline JS to Stimulus ( #11364 )
...
* Convert inline JS to Stimulus
* Use Stimulus targets over element IDs
2020-11-11 21:25:04 -06:00
Rafi
0bc475254b
Adding select option to storybook ( #11338 )
2020-11-11 11:36:11 -05:00
Robin Gagnon
27a3df7d73
A11y: Add keyboard navigation to article feed ( #10468 )
...
Co-authored-by: Andrew Bone <AndrewB05@gmail.com>
Co-authored-by: Nick Taylor <nick@dev.to>
2020-11-10 22:38:15 -05:00
Nick Taylor
af58e7c1a9
Set default timeout to 0 ms for keyboard shortcuts. ( #11363 )
2020-11-10 18:32:29 -05:00
Andrew Bone
75bec9b705
Add chaining to shortcuts ( #11113 )
...
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2020-11-10 09:21:39 -05:00
Arit Amana
4d93112084
Make final Auth Provider Refactor code changes ( #11303 )
2020-11-07 07:49:16 -05:00
Arit Amana
08796b5cee
[Team Email Login] Refactor Authentication Provider Enable/Disable ( #11185 )
...
* Starting out
* Building away...
* Hooking buttons up
* Hook Auth Provider buttons to Array Field
* trying to fix NoNameError
* Remains InviteOnlyMode disable and tests
* Smashing remaining tasks
* Last of tasks
* add tests
* Complete specs and tests 😅
* Fix bug
* Additional guard
* pass event to functions
* Position Email Auth first
* Fix bug in Email Auth Modal
* Fix spacing issue
* Update docs for adminModal.js
* Show/hide Enabled Indicator with Enable/Undo buttons
* Complete Auth Providers functionality
* Update app/javascript/admin/controllers/config_controller.js
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/javascript/admin/controllers/config_controller.js
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/controllers/admin/configs_controller.rb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update helper names
* better implementation of EnabledIndicator show/hide
* Small copy changes
* Update spec/helpers/authentication_helper_spec.rb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/views/admin/configs/show.html.erb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Update app/helpers/authentication_helper.rb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-11-06 18:19:34 -05:00
Rafi
d80f918efa
Fixing flag user modal ( #11221 )
2020-11-05 10:05:37 -05:00
Sarthak Sharma
708791f986
🚀 Feature: Give Tab Notification on New Message ( #9847 )
...
Co-authored-by: Narender Singh <narender2031@gmail.com>
2020-11-04 16:34:01 -05:00
Lisa Sy
8d08191e9a
[Front-End Q/A] Config Authentication view ( #11169 )
...
* Update spacing and add Crayons classes
* Update modal interaction and style
* WIP Hide collapsed container
* Refactor invite only mode UX using tooltip
* Fix recaptcha toggle
* Implement button-text change and enabled-indicator hide
* Remove small icon alignment
* Update app/views/admin/configs/show.html.erb
* Fix icon and row alignment
* Fix enabled-indicator bug
Co-authored-by: Arit Amana <msarit@gmail.com>
2020-11-03 20:12:19 -08:00
Rafi
9b02f1619b
Fixing tags in listing modal ( #11251 )
2020-11-03 12:01:55 -05:00
Krzysztof Rybka
e3495be608
Render followed tags only if container available ( #11054 )
2020-11-02 16:43:37 -05:00
Ivan
3ad0e27f8c
fix for code fullscreen action on comment page ( #11224 )
2020-11-02 10:57:45 +01:00
ludwiczakpawel
44466532dd
Z-index cleanups ( #11157 )
...
* tooltips 1.0.1
* tooltips 1.0.1
* cleanup css
* few more fixes
* fix
2020-10-30 16:03:23 +01:00
Rafal Trojanowski
4bc8b80a90
Introduce tweet_timeline liquid tag ( #7605 ) ( #10825 )
2020-10-30 11:03:40 +01:00
Arit Amana
e00cb5df17
[Team Email Login] Genericize AdminConfig Modal ( #11145 )
...
* Genericize AdminConfig Modal
* Rename function, add JSDoc documentation
* Tests for modal-building function
* Still trying to get jest test to pass
* Fix failing jest test
2020-10-29 15:01:37 -04:00
ludwiczakpawel
dc3bcd8913
Drop custom color pickers ( #11154 )
...
* tooltips 1.0.1
* tooltips 1.0.1
* drop custom js color picker
2020-10-29 14:35:47 +01:00
Rafi
52f2627e6c
Refactoring EditorAction ( #10894 )
...
* Refactoring EditorAction
* Removing useCallback
* Renaming variables to isVersionX
2020-10-29 09:06:30 +01:00
Mac Siri
8ba2c03360
[deploy] Encode domain name in pusher channels ( #11136 )
...
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2020-10-28 14:52:38 -04:00
Arit Amana
1912ffdc46
[Team Email Login] Refactor the Email Authentication flow ( #11090 )
...
* Hooked "Enable" button to hidden checkbox
* Hooked "Close" button to close email settings and show "Enable/Edit" button
* Additional hookups
* Start building generalized Modal blocks
* Everything hooked up except styling and a few Qs
* last of the hookups; ensure logic flow
* clean up
* specs to cover email auth refactor
* Fix bug surfaced by Vaidehi
* Incorporate PR feedback
* prevent email auth disable if invite-only-mode
* adjust emailAuthModal body text
* Sundry improvements
* Last-mile tweaks
* Trying to get 3rd party auth deselect to work
* delete unnecssary function
* remove superfluous comment
* Move inline styling into CSS file
* Incorporate PR feedback
* Incorporate more PR feedback
* Make Confirm btn intent clearer
* Add TODO comment
2020-10-28 13:37:11 -04:00
Rafi
c9014a7835
Removing email prop and fixing test ( #11108 )
2020-10-27 15:38:31 -04:00
Jacob Herrington
c91c07920f
Add config option for Forem collective noun ( #11107 )
...
Not everyone will want to use "Community" to describe their Forem, so
now they have some flexibility there.
2020-10-27 12:45:52 -04:00
Robin Gagnon
10d7da2878
feat: Add shortcut to bookmark an article ( #11116 )
2020-10-27 12:44:03 -04:00
Lisa Sy
126c2401e3
Improve small screen display of Mod Center ( #10621 ) [deploy]
...
* Add page-header padding and overflow-x for tabs
* Split into two moderator files and move into Views folder
* Add page-header padding style
* Increase font size of crayons-tag on small screen
* Improve small screen view of menu and grid rows in mod center
* Fix date alignment
* Update after first PR revision
* Re-update
* Fix stylesheet reference
2020-10-27 07:46:52 -07:00
Cassey Lottman
64dce93088
clarify how to add multiple tags ( #11082 )
2020-10-26 14:57:51 +01:00
Nick Taylor
d5dcda6af6
Renamed internal.js pack file to admin.js ( #11046 )
2020-10-23 17:57:39 -04:00
Nick Taylor
82d659be8f
Fix Search Navigation Disconnect Between URL and Search Input ( #11009 )
2020-10-22 12:37:26 -04:00
