Jacob Herrington
a5b2d109d5
Rename banned and comment_banned roles ( #12270 )
...
* Rename banned and comment_banned roles
* Add data update script to rename roles containing 'ban'
* Add named error for Suspended users
* Update unidiomatic method names
* Rename misc banned to suspended
* Apply suggestions from code review
Co-authored-by: Michael Kohl <me@citizen428.net>
* Add unit tests for suspended methods
This commit also adds TODO comments for removing banned and
comment_banned from the codebase after data update scripts have
successfully run on all of our Forems.
Co-authored-by: Michael Kohl <me@citizen428.net>
2021-04-06 10:12:14 -05:00
Ridhwana
07fcbb6f0e
Parenthesis consistency for add_role and remove_role ( #12661 )
...
* chore: use consistent code styles for the parenthesis around arguments
* Revert "chore: use consistent code styles for the parenthesis around arguments"
This reverts commit 281c899a5cff0480b182fef45b10ef69979166cb.
* chore: add consistent parenthesis
2021-02-15 20:35:25 +02:00
Arit Amana
c1fe6a6488
[deploy] [Moderation] Allow admins to delete comments ( #9628 )
...
* Styling of Delete Comment
* Start hooking DELETE action up
* Add new route
* Add new action
* Update comment_policy.rb
* Update specs for comment_policy.rb
* Some more specs
* Update api call
* Building delete functionality
* Still building...
* Complete implementation
* Changes from PR review
* Fix failing spec; rework admin_delete method
* Protect redirect
* Improve admin_delete method
* Protect redirect
* Refactor JS file and admin_delete method
* Fix flash messages issues
* Fix confirm dialog
* Final QA changes
2020-08-13 10:15:48 -04:00
rhymes
f1ec04a0c9
Rubocop: move dot in multi-line calls to leading position ( #9262 )
2020-07-16 15:51:11 +02:00
rhymes
5b62811c98
[deploy] Rubocop: fix violations of Layout/LineLength ( #9197 )
2020-07-08 08:36:36 -05:00
Molly Struve
5d22e71ad6
nothing to see here....except maybe reverting a push to master ( #8308 )
...
🙈
2020-06-05 20:34:21 -05:00
mstruve
533cab50d6
synchronous roles
2020-06-05 20:02:41 -05:00
Andy Zhao
f5ec83653c
[deploy] Finalize and add response templates feature ( #7068 )
2020-04-16 15:53:29 -04:00
Anna Buianova
dcfa6d29b8
Fix Rubocop lints ( #5155 )
2019-12-19 10:09:37 -05:00
Andy Zhao
71157c993e
Hide comment feature ( #4944 )
...
* Add MVP of hide comment feature
* Slight copy adjustments
* Remove unused file oops
* Fix strange styling issues
* Add hide/unhide comment specs
* Authenticate user for hide/unhide
* Add tests for hide/unhide functionality
* Remove opacity CSS for hidden comments
* Fix hidden comment explanation logic
* Fix some styling issues
* Fix hiding top level comment logic
* Show only hidden comments in permalink and not thread
* Hide subtree properly if hidden comment
* Fix weird CSS issue
* Properly hide comments for permalink view
* Show children comments in permalink view
* Add tests for comment hiding visibility
* Remove superfluous code and adjust copy
* Remove some more logical duplication
* Add dedicated article column for any comments hidden
* Add reload in test
2019-12-10 15:09:47 -05:00
rhymes
62edf443f3
Add FKs to notifications_subscriptions, page_views and users_roles ( #4999 ) [deploy]
2019-12-04 10:14:57 -06:00
Mac Siri
64f70fff8f
Use build_stubbed in Policy specs ( #4017 ) [ci skip]
2019-09-13 11:38:58 -04:00
rhymes
9d2c89fd2f
Upgrade factory_bot_rails to 5.2.0 ( #2532 ) [ci skip]
2019-04-23 13:21:22 -04:00
Andy Zhao
c4677071a7
Mute notifications for a comment thread ( #1636 )
...
* Use idempotent update instead of toggle
* Update editor guide with new comment instructions
* Render the settings button on page load
* Add settings button to comment dropdown
* Update styles to properly render
* Add comment mute function and settings page
* Clean up erb spacing
* Remove unneccessary user_id param
* Add receive_notifications for policy spec
* Update name for accuracy
* Add request spec for comments_mute
* Remove unused permitted attributes
* Add actually used permitted attributes
2019-01-24 17:20:38 -05:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Andy Zhao
c888fd6faa
Add ability to prevent comment creation ( #554 )
2018-08-31 12:11:21 -04:00
rhymes
e588fa7ece
Code cleanups ( #659 )
...
* Initial automatic cleanup with rubocop
* Fix syntax error introduced by rubocop
* Cleanup seeds file
* Cleanup lib folder
* Exclude bin folder because it contains auto generated files
* Make Rubocop a little bit more chatty
* Block length should not include comments in the count
* Cleanup config folder
* Cleanup specs
* Updated Rubocop version and generated a todo file
* Fix broken ArticlesApi spec
* Fix tests
* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Andy Zhao
0785720908
Add comment policy and specs ( #475 )
...
* Fix edge case with apostrophes
* Add comment policy and specs
* Add login for deleting comment spec
* Change test to raise pundit error instead of 404
* Clean up comment destroy request specs
* Remove redundant raise
2018-06-21 17:20:34 -04:00
