Commit graph

193 commits

Author SHA1 Message Date
Ben Halpern
57fff54cd8
Remove es6 code from non-es6 area (#904) 2018-10-13 20:02:49 -04:00
Ben Halpern
221c363af0
Reduce queries in typical stories#show response + small fixes (#903)
* Reduce queries in typical stories#show response + small fixes

* Change const to git in non-es6 code
2018-10-13 19:38:38 -04:00
Ryan Palo
588ffeef09 Fix #848. Code inside Markdown inside Gist displays. (#902) 2018-10-13 14:28:39 -04:00
Nick Karnik
a3649b8d09 Added the ability to press Ctrl+Enter Or Command+Enter to submit comments. (#885)
* Resolves #245
    * This is applied to root level comments as well as nested replies.
    * We are ensuring that user has commented at least once which means
      they have accepted the code of conduct before

Style changes as per suggestions in code review
2018-10-13 14:24:53 -04:00
Ben Halpern
b13c09583f
Adjust modal to not interfere with pull-to-refresh (#888)
* Remove unnecessary code from onboarding

* Adjust pull-to-refresh button to account for open modal scenario
2018-10-11 16:45:43 -04:00
Ben Halpern
5194dc736c
Adjust onboarding modal styling for different screen sizes and production data (#883) 2018-10-10 16:58:04 -04:00
Ben Halpern
991458d1c3
Adjust onboarding slides (#882)
* Modify onboarding slides

* Remove user controller changes

* Modify onboarding slide font size

* Adjust small onboarding issues

* Modify onboarding styling

* Remove flash unstyles content
2018-10-10 16:00:20 -04:00
Felix Edelmann
763f97f76f Improve dashboard action buttons' styling (#808)
* Use full content width (one line with content below)
* Fix gap between actions
* Add hover color and transition for opacity
* Decrease font size a little bit
* Force break "POSTS" and "(123)" into two lines when width is 600-800px
2018-10-09 16:11:09 -04:00
Ben Halpern
28099f031c
Adjust article-form height (#870) 2018-10-09 12:03:02 -04:00
Ben Halpern
3ae3fb0652
Adjust placement of image button on small screen (#867)
* Adjust placement of image button on small screen

* Adjust orgsettings css for small screen

* Update snapshot for article form
2018-10-08 20:32:00 -04:00
Ben Halpern
e64782572e
Get way less cute with pull-to-refresh (#866) 2018-10-08 20:08:11 -04:00
Ben Halpern
e62ffd0ff5
Add editor version for users to try new editor (#861)
* Adjust form tagbar height

* Adjusted styling for various screen sizes

* Add editor_version field for users

* Adjust default opacity in v2 editor
2018-10-08 15:05:20 -04:00
Ben Halpern
0b2ecd44b3
Add pull-to-refresh for index views (#859) 2018-10-08 14:26:21 -04:00
Ben Halpern
f52f8b6437
Update image area and other editor functionality (#847) 2018-10-07 12:52:13 -04:00
Ben Halpern
87a7067a5c
Spruce up V2 editor look and feel (almost ready 🙂) (#846)
* Spruce up editor look and feel

* Update jest snapshots for editor

* Fix editor guide scoping issue
2018-10-07 11:06:52 -04:00
Arit Amana
5c245bdb4e Better alignment of "Select" and "Remove" buttons with Repo Titles in "Integrations" (#836)
* Syncing with Upstream master

* Dev Env Keys - Algolia and Github

* Pull from upstream master

* Remove commented code
2018-10-05 17:37:50 -04:00
Ben Halpern
ecb9645775
Make changes to editor (#837)
* Make changes to editor

* Make minor fixes and console log removals

* Fix test in article form

* Adjust rspec test
2018-10-05 16:03:06 -04:00
Ben Halpern
a761dfbc83
Finalize merge accounts (#820)
* Add initial remove association feature

* Add initial account deletion feature

* Add back in cursor pointer

* Update email text copy

* Update copy on email html

* Fix nav issue and add integration buttons to account
2018-10-04 12:27:37 -04:00
Benny Powers
c16e2aa480 Center article header image (#773) 2018-10-03 17:13:02 -04:00
Ben Halpern
483a7410af
Change impression event to view in Google Analytics (#805)
* Add tracking for home page featured impressions/clicks

* Change impression event to view in Google Analytics
2018-10-03 14:35:34 -04:00
Ben Halpern
a0491657dd
Add tracking for home page featured impressions/clicks (#804) 2018-10-03 14:05:00 -04:00
Jack Harner
2b0de7ee04 setting user-select to none on the top-bar profile image (#786) 2018-10-02 11:00:40 -04:00
Ben Halpern
7e48a23afa
Ben/add more recent posts to home feed (#775)
* Add meta to sidebar and adjust ranking algo

* Update home feed to show more recent posts from folks you follow

* Only show recent posts on home feed if user signed in
2018-09-30 14:05:59 -04:00
Ben Halpern
4205d50bd8
Make home feed more relevant and varied (#757) 2018-09-27 13:21:51 -04:00
38elements
e9cbbae5c5 Fix FOLLOWING button (#728) 2018-09-24 11:38:48 -04:00
Ben Halpern
160056a19d
Add organization users to sidebar and other org ajustments (#707) 2018-09-20 15:43:43 -04:00
Ben Halpern
2545b8d77f
Modify styling and classes for iOS safari /connect (#701) 2018-09-19 18:25:36 -04:00
Ben Halpern
e0c7ac970d
Modify reaction bar style (#665) 2018-09-15 13:25:38 -04:00
Ben Halpern
8074113663
Revert linting issues (#651) 2018-09-13 15:18:19 -04:00
Den McHenry
cf15295771 Fix table layout in posts (#429)
Three rules overriding table and cell defaults reduce readability of tables by

1. forcing full width irrespective of actual table contents, and
2. setting an arbitrary width of 1000px on each cell.

This seems to be the result of tinkering to improve table aesthetics by filling horizontal space, but this is a common error that seriously [degrades the readability of tabular data](https://alistapart.com/article/web-typography-tables#section2).

The first issue above is a bit confused: the width has been set to `100%`, and display has been set to `block`.

Setting a default table to 100% width will cause the children to adapt accordingly, achieving the desired result. But changing `table` to `block` breaks the relationship so that the children of the table no longer adapt to the full width. (They behave as though an anonymous parent table of the correct display type has been inserted, while the `table` element behaves like a generic block level element. They no longer will the table, though the table is technically full width.)

This probably explains the arbitrary width on data cells. It's set larger than the container, forcing the browser to resolve it against the available space and thus approximate the expected result of a default table with 100% width.

Rather than trying to fill horizontal space, it's better for readability to allow data cells to adapt to the size of their contents. A better option for aesthetics in blog posts on Dev.to is to remove the three rules deleted here that affect table layout and instead set left and right margins to `auto`, so that narrow tables are centered in posts, but wide tables can still extend beyond the normal content width of paragraphs as they do now.
2018-09-13 14:20:33 -04:00
Ben Halpern
dd32580ab1
Make article actions bar sticky (#648)
* Make article actions bar sticky

* Fix article load edge case

* Fix logic check
2018-09-13 13:52:35 -04:00
Ben Halpern
eeb408511a
Add extra caching to home query (#643)
* Update home feed logic and display

* Remove console log

* Add extra caching to home query

* Fix conflict
2018-09-12 16:34:10 -04:00
Ben Halpern
91f99036df
Update feed for slightly more customized top articles (#642)
* Update home feed logic and display

* Remove console log
2018-09-12 15:27:54 -04:00
Andy Zhao
a4c3d97aa9 Fix Liquid Filters and Fix DevComment Tag (#608)
* Update standard filters

* Update comment tag and rename devcomment tag

* Update tests with new file name

* Refactor liquid tags into null tag

* Fix renaming issue and refactor

* Fix useless assignment via codeclimate

* Add test for null tag

* Update LiquidTags.scss with new file name
2018-09-05 17:42:47 -04:00
Ben Halpern
9009a1a977 Fix button height and modify video styling (#609) 2018-09-05 16:51:01 -04:00
Gaurav Shankar
99d98d75b4 Fix long username in navbar (#588)
* Fixed the overflowing user name in the top bar under profile thumbnail

* Fixed by adding hidden and ellipsis
2018-09-05 11:58:07 -04:00
Ben Halpern
044be9e162
Modify instantclick to follow 404/500/302 statuses etc. (#593) 2018-09-04 17:20:13 -04:00
Andy Zhao
7d7863da1f Add nofollow to /moderate links (#592) 2018-09-04 17:09:28 -04:00
Yash Ghelani
9795b192a3 Upgrade to a font stack that uses better system fonts (#512) 2018-09-01 12:17:05 -04:00
Andy Zhao
ceb8a70103 Fix typo on offline page (#553) 2018-08-30 12:01:14 -04:00
Edison Yap
ee5efe4c4a Fix chat channels being blocked by footer (#513) 2018-08-29 18:24:17 -04:00
Ben Halpern
0bc9a8d306 Remove open source announcement box (#534) 2018-08-29 11:40:11 -04:00
AshWhitear
ce45d0ef81 Update all necessary follow buttons on click (#433) 2018-08-28 15:34:09 -04:00
Ben Halpern
95908ddde1
Fix /live styling issues (#519) 2018-08-28 11:50:25 -04:00
Ali Spittel
f509607eb9 Create new offline page (#463)
* Update offline.html

* Update serviceworker.js.erb
2018-08-24 15:09:00 -04:00
Andy Zhao
fb22171267 Update ORLY Pages (#432) 2018-08-21 18:27:47 -04:00
rhymes
14fb6e4a8d Fix images button style in new editor (#381) 2018-08-17 10:48:33 -04:00
Jonny Buchanan
34efec4b5d Stop using the Fake Notifications Dark Pattern (#288) 2018-08-08 18:31:35 -04:00
Ben Halpern
524d8a8aea
Add open source moment gif (#673) 2018-08-08 11:33:21 -04:00
Ben Halpern
2cae371044
Remove event ping tracking because it was confusing us (#662) 2018-08-06 13:53:22 -04:00